Commit graph

2020 commits

Author SHA1 Message Date
ytaous
2ce90cff4c
PR comments (#3374)
* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-04-01 10:36:16 -07:00
Sherlock
614eb438ae
Update Op's Domain and Version (#3356)
* Update Nccl ops domain opset

* Update ZeroGradient Domain OpSet

* Update InPlaceAccumulator Domain OpSet

* Update SoftmaxGrad Domain and OpSet

* Update LayerNormalizationGrad Domain and OpSet

* Update BatchNormGrad Domain and Opset

* Update IsAllFinite Domain and Opset

* Update DivGrad Domain and Opset

* Update GatherGrad Domain and Opset

* Update IsFinite Domain and OpSet

* Update ReduceAllL2 Domain and Opset

* Update MixedPrecisionScale Doman and Opset

* Update AllOp Domain and Opset

* Update GroupOp Domain and OpSet

* Update ViewOp Domain and OpSet
2020-04-01 10:10:38 -07:00
Xueyun Zhu
efc8bd738f
add pipeline graph split script (#3275)
* pipeline graph cut

* add element type

* add input wait event and shape info

* shape inference

* support multiple cuts

* format script

* address feedback

* address feedback
2020-03-31 19:30:18 -07:00
edgchen1
fb2f97a002
Address master merge PR comments (#3348)
Address some comments from https://github.com/microsoft/onnxruntime/pull/3174.

- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r396855459
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r396855630
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r396857140
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r398094858
- https://github.com/microsoft/onnxruntime/pull/3174#issuecomment-599024924
2020-03-30 18:52:48 -07:00
ytaous
d8f0a0f223
Address PR comments (#3352)
* PR comments

* revert code for a couple comments

* add negative test case

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-29 12:34:54 -07:00
Weixing Zhang
1bbc421884
Don't cast to fp16 in LayernormGrad (#3328)
Co-authored-by: Weixing Zhang <wezhan@microsoft.com>
2020-03-28 19:07:32 -07:00
Sherlock
ffb2a3359e
Implement WhereGrad (#3343) 2020-03-27 19:10:40 -07:00
Tixxx
49e6043d07
support Huggingface's adamw (#3318)
* add weight decay mode to support both pytorch and huggingface's adamw
2020-03-27 08:04:27 -07:00
ytaous
131c65d23d
Addressing PR comments (#3334)
* PR comments

* PR comments

* PR comments

* error out bad shape

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-26 18:43:30 -07:00
Xueyun Zhu
0a6ec0df56
Merge pull request #3285 from microsoft/xuzhu/merge_from_master
Merge from master to ort_training
2020-03-26 12:10:13 -07:00
Sherlock
d143b41b81
Expose frozen_weights in PyTorch Frontend (#3317) 2020-03-26 11:26:54 -07:00
ytaous
66c7579c93
address PR comments (#3312)
* address PR comments

* PR comments

* PR comments

* disable logging

* typo

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-25 19:35:12 -07:00
Xueyun Zhu
a031af8cfc fix windows build 2020-03-25 19:18:50 +00:00
Xueyun Zhu
9eb792a5b3 move env to .cc file 2020-03-25 16:57:05 +00:00
Wei-Sheng Chin
b38fc0d541
Add bias correction in Adam & Lamb for C++ frontend & python frontend (#3301) 2020-03-25 09:46:44 -07:00
Xueyun Zhu
e9877850a4 fix python error 2020-03-25 01:59:37 +00:00
Bowen Bao
6474801ceb
Update ort_trainer.py with lazy onnx export (#3244)
* Delay onnx export to avoid extra info

* handle cases where onnx model is provided at initialization

* address comments

* fix rebase error
2020-03-24 13:34:15 -07:00
Li-Wen Chang
98c28060b0
Aggregated Send/Recv (#3232)
* Aggregated Send/Recv

* fix typos

* CR refine

* CR refine

* CR refine

* Add scalar check.

* typo

* reformat

* CR refine

* Forgot to swap order in the implementation after spec changed

* CR refine

* Cr refine

* add Send's input type checking
2020-03-24 10:20:11 -07:00
KeDengMS
d15c74e713
Implement pipeline event generator (#3206)
Implement pipeline event generator with OneFWOneBW schedule in timeline. Each stage of pipeline contains FW and BW of a subset of the model and are scheduled in one worker thread for each microbatch.
2020-03-23 17:32:54 -07:00
Xueyun Zhu
8f7bd51f7a fix pybind issue introduced by merge 2020-03-23 23:23:34 +00:00
Tixxx
7f610caca0
Make gradient clipping configurable. (#3243)
* Make gradient clipping configurable.
add control flag to c++ and python frontend
2020-03-23 12:21:48 -07:00
Xueyun Zhu
9dbc50c438 fix build break 2020-03-21 02:16:00 +00:00
Xueyun Zhu
ccc3535e72 resolve conflict 2020-03-20 20:20:35 +00:00
Dmitri Smirnov
b880c48c4c
Make reduction ops handle Scalar input (#3260)
Handle Scalar values for CPU and GPU
  Ifdef CUDA nd TVM as they require more changes.
2020-03-20 12:04:47 -07:00
ytaous
5c52332223
unittests comments (#3278)
Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-20 11:56:50 -07:00
Ye Wang
c5149e89d9
Wangye/shortgraindropper (#3273) (#3274)
* Featurizer Library update

* update Featurizer Library

* add short_grain_dropper_transformer

* resolve comments

* resolve comments

* resolve comments
2020-03-20 11:48:31 -07:00
Tianlei Wu
1d9be2baed
Add Notebook for Bert Model exported by Keras2onnx (#3271)
* Add notebook for bert squad model exported by python 1.4

* update bert performance test tool:
(1) set OpenMP environment variable before importing onnxruntime.
(2) launch new process for each test.

* Add notebook
Reduce combinations in perf test

* update readme

* fix quote

* Allow test multiple batch_size

* Add latency percentile

* Add warm up run
Reset logger for notebook

* refine default settings to test for cpu/gpu

* Add script to dump machine info

* Add notebooks for PyTorch SQuAD model GPU and CPU inference

* Update machineinfo.py: add license header; format by yapf

* Do not reset log handler. Skip adding handler if existed.

* Add comments about GPU result diff.
Filter rows of batch set to keep only one setting.

* update according to review feedback

* Download script from master branch

* Add notebook for bert model exported by keras2onnx

* format columns in result table

* re-run and update notebook
2020-03-20 11:37:25 -07:00
Yufeng Li
a69d859912
fix quantize_bias (#3270) 2020-03-20 11:36:47 -07:00
liqunfu
d521efd904
refactor frontend (#3235)
* refactor frontend

* remove training python files from inferencing build

* update according to reviewer's comments

* merge pybind_state.cc

* refactor pybind_state.cc

* code clean up

* missed a forward declaration in ort_pybind_state.cc

* passed pytest

* move training_session.py into a subfolder per reviewer's comment

* add copyright

Co-authored-by: liqun <liqun@OrtTrainingDev4.af05slrtruoetgaxwwjv5nsq5e.px.internal.cloudapp.net>
2020-03-19 20:59:41 -07:00
edgchen1
d9f628cb1d
Remove orttraining/tools/scripts/profile directory. (#3268) 2020-03-19 14:13:05 -07:00
Scott McKay
6dc25a60f8
Make the reduction ops more consistent in checking if no transpose is required and skipping the copy of the input data if that is the case. Significantly better performance when this is done (2x faster for model calling ReduceSumSquare with input of {2048,10}). (#3265) 2020-03-20 06:55:38 +10:00
ytaous
ca7985fd9f
Address PR comments (#3256)
* comments

* fix path

* fix path

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-19 10:40:00 -07:00
Changming Sun
8f00147c14 Fix a few warnings 2020-03-19 09:22:28 -07:00
Tiago Koji Castro Shibata
3bdb0b620a
Fix WCOS/Win32 linking bugs (#3126)
* Fix WCOS/Win32 linking bugs

* Remove unused NODEFAULTLIB flags

* Avoid plain target_link_libraries signature

* Avoid plain target_link_libraries signature

* Fix library list escaping

* Use library list instead of string

* Remove duplicate link to windowsapp.lib

* Remove Win32 build workarounds

* Specify CMake policies before initializing language

* Expose Win32 header definitions during build

* Force set API family

* Enable Win32 APIs in featurizer

* Use MT dynamic CRT

* Expose Win32 specific functions

* Disable app container globally

* Disable default wide functions in featurizers

* Add featurizers to test include path

* Workaround https://gitlab.kitware.com/cmake/cmake/issues/19428

* Revert pipeline debugging hacks

* Skip /FI in CUDA sources

* Default to Win32 builds

* Enable WCOS when using WinML

* Use generator expression to apply CMAKE_MSVC_RUNTIME_LIBRARY to C++ only
2020-03-19 08:52:40 -07:00
edgchen1
61e8a24340
Address PR comments (#3255)
* Added comment for ntfw_remove().

* Rewrite WindowsEnv::DeleteFolder(), some other clean up.
2020-03-18 17:57:57 -07:00
edgchen1
d82f72e65c
Add ort_training build status file. (#3257) 2020-03-18 17:39:57 -07:00
Pranav Sharma
435f014d71
Add support for sessions to share a global threadpool. (#3177)
* Add support for sessions to share a global threadpool.

* Fix build issues

* Add tests, fix build issues.

* Added some documentation

* Fix centos issue when threadpools become nullptr due to 1 core.

* Fix mac and x86 build issues

* Address some PR comments

* Disabled test for android, added few more tests and addressed more PR comments.

* const_cast
2020-03-18 15:42:46 -07:00
Sherlock
03d14bae2b
Register ONNX Training Ops (#3252) 2020-03-18 12:36:57 -07:00
edgchen1
e03b8a1e2f
Move path_lib from onnxruntime/core/framework to onnxruntime/core/platform. (#3253)
Moved path_lib.h/cc from onnxruntime/core/framework to onnxruntime/core/platform and from the onnxruntime_framework to the onnxruntime_common libraries.
2020-03-18 11:53:46 -07:00
Xiang Zhang
61621d4053
Add extra fields to ORT telemetry (#3234)
* Add extra fields to ORT telemetry

* fix linux build failure caused by using HRESULT

* little refactor
2020-03-18 09:37:35 -07:00
Xavier Dupré
bd348ec6ca
Add unit test to cover TreeEnsembleClassifier applied to binary classification and 2 classes (#3230)
* Add unit test to cover TreeEnsembleClassifier for binary classification
2020-03-18 11:32:58 +01:00
jaka.katrasnik
88c65f8add Fixes GTest deprecation warnings 2020-03-17 16:38:55 -07:00
edgchen1
c5576d70a6
Fix build issues (#3214)
* Fixed issues with Python and inference-only build.

* Handle ImportError for training imports.

* fix windows build

* fix compile error

* fix centos build

* fix windows build

* fix compile error

* Use SafeInt for allocation calculation, fix typo.

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-17 16:10:23 -07:00
Tianlei Wu
0700d13ece
Add Bert Optimization Notebooks (#3204)
* Add notebooks for GPU and CPU inference of PyTorch BERT SQuAD model
* update bert_optimization.py: Do not add duplicated logger handler
* Add machineinfo.py to show machine configuration for notebook.
* Update bert performance test tool:
(1) Set OpenMP environment variable before importing onnxruntime.
(2) Use sub-process for each test
(3) Allow test multiple batch_size
(4) Add latency percentile
(5) Add warmup
2020-03-17 11:56:36 -07:00
Faith Xu
8bc4e3195d
Updates to roadmap (#3155)
* Updates to roadmap

* remove redundant directML

* Add JS to future investments
2020-03-16 18:19:07 -07:00
Ori Levari
e63f817eb6
avoid IDXGIFactory 6 where possible to enable WinML GPU Path downlevel to RS3 (#3180) 2020-03-16 15:25:32 -07:00
Xiang Zhang
682dde2b3b
add dml_ep_lock (#3200)
* add dml_ep_lock

* Move Winml process-wide lock back to individual sessions
2020-03-16 14:32:12 -07:00
Sherlock
4b2c8e884e
Udpate License Header (#3212) 2020-03-16 10:24:31 -07:00
Xavier Dupré
6319357a99
Reduce number of allocations in TreeEnsemble (#3217)
* reduce number of allocations in TreeEnsemble

* Fix probabilities for binary case.

* fix outbound access

Co-authored-by: xavier dupré <xavier.dupre@gmail.com>
2020-03-16 12:22:15 +01:00
Changming Sun
0fceb33288
Fix onnxruntime server docker file build failure (#3219)
1. Fix onnxruntime server docker file build failure. Tested with the notebook in ONNX tutorial, it works well.
2. Delete the docker files for the other EPs, because currently they don't work and I don't have enough time to update them.
2020-03-15 14:46:46 -07:00