Commit graph

401 commits

Author SHA1 Message Date
bunnie
8a574f937f bump for xous-rs version pin update 2023-04-27 22:18:30 +08:00
bunnie
1392fdcf33 bump pins for updated log API 2023-04-16 02:27:37 +08:00
bunnie
cb3c81d0fb fix #357: regenerate password if password field is blank in vault 2023-04-12 23:19:11 +08:00
bunnie
849c136b90 bump versions because API crate changed 2023-04-12 23:02:30 +08:00
bunnie
8357ab31a5 bump all pins because utralib got updated 2023-04-09 00:48:35 +08:00
bunnie
9c94d6b4c0 bump versions because xous-rs API changed for gdb-stub 2023-04-08 23:49:24 +08:00
bunnie
e469eba167 bump version for utralib patch 2023-04-04 02:13:02 +08:00
bunnie
cd0269036d WIP: #334
I don't have a way to test this, but maybe you can give it a try
and see if it fixes as described in the issue.
2023-03-24 23:08:50 +08:00
bunnie
704aaf98af bump versions for kernel interface changes 2023-03-22 02:48:55 +08:00
bunnie
303f595d6f bump versions to cleanup renode.rs sync issue 2023-03-14 16:34:53 +08:00
bunnie
82e3aa322f bump toml files in prep for publish 2023-03-08 03:54:37 +08:00
bunnie
b329023091 workaround trng trait inconsistency
0.5.1 rand_core needed for the dalek crates
0.6.3 traits everywhere else
what a mess

turns out i can just use fill_via_next() to do the same thing
without having to step on cross-generation traits. whew.

(also not in tree but doing a quick manual test that fill_via_next()
is not totally broken)
2023-02-27 02:09:07 +08:00
bunnie
4fa4becc58 fix #310 + revert other "fixes"
Turns out the testbench failures are due to the testbench
being out of date. OpenSK is correct, the tests are wrong.

See discussions here:

https://github.com/google/OpenSK/issues/586
https://github.com/google/OpenSK/issues/584
https://github.com/google/OpenSK/issues/582

We'll await updates to the test tool and fold those into CI,
and leave the current failures standing.
2023-02-07 23:03:29 +08:00
bunnie
9256e7cc09 bump versions to absorb xous-names fix 2023-01-31 15:07:32 +08:00
bunnie
84368c3f3a bump versions for publication 2023-01-31 02:18:12 +08:00
bunnie
2191503f0c fix #304
this adds a "kicker" thread that gets updated with a target time
to kick the UX by the FIDO2 USB handler. When the target time is
met, an "update" command is issued to the UX.

This hopefully creates an efficient mechanism for triggering a
UX redraw that also has an acceptable delay.
2023-01-30 23:14:16 +08:00
bunnie
797bb0adc6 fix https://github.com/google/OpenSK/issues/584
I suspect this fix is actually the correct solution to the problem,
but refer to the issue above for tracking.
2023-01-30 18:34:43 +08:00
bunnie
b4ce65cb8e possible fix for https://github.com/google/OpenSK/issues/586
This may not be the correct fix, but it causes the test bench to pass.
This will be revisted once I hear back from the OpenSK maintainers.

I strongly supect the issue is actually a bug in how permissions are cleared
after a user presence test, and not that the checks themselves are
incorrect.
2023-01-30 18:33:33 +08:00
bunnie
e64351569f update ctap timeouts in the main loop
This is necessary because there are some timed permissions that
must expire over time that are not asynchronous like the
user presence tests.
2023-01-30 18:32:26 +08:00
bunnie
b1362c0ca4 chore: add a comment 2023-01-30 18:31:53 +08:00
bunnie
c237ff7b46 fix https://github.com/google/OpenSK/issues/582
See the above issue for more details
2023-01-30 18:31:12 +08:00
bunnie
d77552899b add some code to help find OOM keys 2023-01-29 04:16:56 +08:00
bunnie
25cc571228 chore: remove warning, and old notes 2023-01-27 02:23:53 +08:00
bunnie
9ea5182103 cleanup minor UX issue (disappearing title when no items present) 2023-01-27 02:23:34 +08:00
bunnie
20a2388b5d update commit ref of opensk code 2023-01-27 01:47:48 +08:00
bunnie
99995f963d use bulk delete to speed up the reset process
this is necessary to pass the test after creating
dozens of credentials; it takes too long to process the
deletion if it's done one at a time
2023-01-27 01:42:50 +08:00
bunnie
50458e837b improve debug output in storage layer 2023-01-26 23:34:08 +08:00
bunnie
dee4bac956 add some more time allowance for resets to process from boot 2023-01-26 23:33:38 +08:00
bunnie
c21f1069bc make reset timing a bit looser
currently 10 seconds from boot before cred reset can be issued;
automated testing can't always keep up with that. expand to
20 seconds. This is not "standards compliant" but the idea that
you unplug the device and it stays on is also not "standards compliant".
2023-01-26 17:59:52 +08:00
bunnie
f1f486e9fb fix PIN permissions; add support for autotest reset 2023-01-26 04:42:40 +08:00
bunnie
10a64da826 allow vendor commands; get vaultbackup-rs working 2023-01-26 02:38:03 +08:00
bunnie
fd4e402d98 refine the heuristic for detecting keys 2023-01-25 22:41:03 +08:00
bunnie
e9ae3fe72b fix key deletion in fido2 2023-01-25 22:36:15 +08:00
bunnie
8974a86f24 add migration from old to new version
confirmed this works for U2F and FIDO2 keys

however, the PIN is reset.
2023-01-25 15:34:54 +08:00
bunnie
5ce6e1b766 initial integration of fido2.1 now passing some basic tests 2023-01-25 00:55:12 +08:00
bunnie
2fb776b2a6 first cut at porting in FIDO2.1 features from OpenSK
Code now builds, but, it doesn't fully work. Also,
the vault backup vendor routines have yet to be wedged in.

On the other hand, this edit is much more targeted than
the first one, so hopefully future port-ins of OpenSK
will be much smoother. In particular, OpenSK has a nice
`env` abstraction that has enough power now for us to
stick most of the Xous-specific stuff in there. There's
still a few patches needed to the main code loop, mainly
to accommodate our ability to display more information
than flash an LED.

The storage layer is also migrated to a totally new
dictionary, because the latest version also completely
redoes the storage with some sort of key/value system,
which maps nicely into the PDDB.
2023-01-24 03:56:30 +08:00
bunnie
f542943df1 fix search criteria to match case-insensitive listing 2023-01-20 18:13:39 +08:00
bunnie
20270609b9 fix cached state to match disk state in UX for edit/delete in passwords 2023-01-20 05:06:16 +08:00
bunnie
d811ef0d2e fix deletion UX in vault 2023-01-20 02:00:35 +08:00
bunnie
232a4b6c6c bump xous version 2023-01-18 00:02:46 +08:00
bunnie
41d4837551 bump versions to absorb WDT change 2023-01-06 17:48:12 +08:00
bunnie
bb5d7b3adf bump versions to absorb hosted mode fix 2023-01-05 14:07:24 +08:00
bunnie
ec5435bd58 add basis cache clear on basis change callback as well 2023-01-04 04:15:44 +08:00
bunnie
57254ce47c clear local caches when basis state changes 2023-01-04 04:13:14 +08:00
bunnie
c3ecaa00eb refactor: remove allocs from vault inner loop
`vault` is changed so that instead of clearing the list of
data each time the screen is updated, it tries to compare it
against the existing data and modifies the record if it needs to,
or leaves it untouched.

Furthermore, at least in the password path, temporary strings
are pre-allocated and re-used, instead of freed and re-allocated
every time through the main loop.

The combination of these optimzations reduces the time to re-parse
a couple hundred records from about 1000ms to 200ms, reducing the
overall time to retrieve the database from 1.8s to 1.0s. It also
makes the loop much more stable over time; previously, as the heap
fragmented, performance would slowly degrade. Now that most
records are static and re-used, the performance seems to stay
constant.

The framwork is also put in place to re-use TOTP/U2F records,
but the code still uses the legacy method of clearing the
entire stored list and rebuilding it. However, it wasn't deemed
a priority to fix this because generally I haven't seen use cases
where users have hundreds of tokens or TOTP's; so long as the
number is about 20 or so, the performance difference should
be imperceptible with or without optimization.
2023-01-04 03:03:19 +08:00
bunnie
10b921e4e8 cleanup another format, add some more analytics 2023-01-03 23:36:46 +08:00
bunnie
36398810dd bump version numbers to absorb new syscalls 2022-12-30 15:24:36 +08:00
bunnie
5370ce396d bump all revs due to SoC artifact update 2022-12-12 16:07:20 +08:00
bunnie
53c9af1033 bump readme's 2022-12-02 23:00:38 +08:00
bunnie
c8ec87b2d6 apply persistent field to other authentication methods 2022-11-30 15:11:56 +08:00
bunnie
d7a3f8962d update vault's password edit to use the new persistent field 2022-11-30 15:00:20 +08:00
bunnie
e8671650e3 add more test cases 2022-11-30 12:13:27 +08:00
bunnie
bf19a60369 add docs for CSV flow 2022-11-30 12:13:15 +08:00
bunnie
e63aaf8832 change wording of error on skipped entry 2022-11-30 12:12:43 +08:00
bunnie
a312432135 fix up some formatting & one missed string in the refactor 2022-11-30 11:31:57 +08:00
bunnie
9699cb761a avoid use of format!() to improve performance (#260) 2022-11-30 00:56:08 +08:00
bunnie
79c773e245 add basic CSV to password support 2022-11-29 23:53:27 +08:00
bunnie
c696f4eff0
Merge pull request #279 from gsora/feat/hotp-vaultbackup
fix: support HOTP codes in `vaultbackup`
2022-11-25 18:12:20 -08:00
bunnie
1d1b3a35b7 commit version bump 2022-11-26 10:00:44 +08:00
bunnie
aa9977cc58 bump all the things because we changed utralib again 2022-11-17 22:13:40 +08:00
bunnie
dabbfd6c35 bump all the things to absorb the SoC change 2022-11-17 19:39:18 +08:00
Gianguido Sorà
279ecbc748 fix: support HOTP codes in vaultbackup
While `vault` supports HOTP codes, `vaultbackup` didn't.

This commit brings it to feature parity.
2022-11-16 15:56:18 +01:00
bunnie
474a02c2cb refactor all vault db retrieval to use new API
This refactors the remaining vault accessor routines to use
the new more efficient key pre-fetching routine. This also
fixes up an error in test case generation and hopefully resolves
an issue with concurrency errors using the older version of
the access routine.
2022-11-09 15:06:51 +08:00
bunnie
e7e110ce76 cleanup and enhance test cases 2022-11-09 14:25:05 +08:00
bunnie
a7162fd03c bump xous-names dependents 2022-11-07 22:19:38 +08:00
bunnie
880675c238 remove UX delays between dialog boxes 2022-11-06 18:44:56 +08:00
bunnie
30583bdf07 bump versions with xous change 2022-11-06 03:48:12 +08:00
bunnie
1ca0ef7b1f clean up warning 2022-11-05 16:30:29 +08:00
bunnie
601f3476f4 initial delay on NTP poller
no point in clogging up the boot sequence with requests that
will almost certainly fail.
2022-11-05 16:19:15 +08:00
bunnie
ba28dd8795 bump to absorb utralib straggler configs 2022-10-28 15:11:17 +08:00
bunnie
e60f7cc855 Merge branch 'i18n/adds-french-localization' into main 2022-10-28 15:00:27 +08:00
bunnie
dfb10ed7f2 bump crate numbers to publish lang-fr change into xous-rs 2022-10-28 14:01:09 +08:00
Tom Marble
006a69105c
Completes the i18n_helper.py tool
Added 'fr' translation
Added *.json to .gitattributes

Signed-off-by: Tom Marble <tmarble@info9.net>
2022-10-27 16:07:05 -05:00
bunnie
c82a79dab9 add performance monitoring in for bulk reads 2022-10-27 16:45:04 +08:00
bunnie
475e464efe bump versions due to svd2utra change 2022-10-27 03:04:22 +08:00
bunnie
bef734553e clarify some comments and clean up debug messages 2022-10-27 02:53:38 +08:00
bunnie
3d1885e165 add test code
results are slightly better on the first run (3700ms instead of 4900ms)
but there seems to be really excessive allocations using the heap
allocated serializer by rkyv. We really need to use the bufserializer
I think for this to work.
2022-10-27 01:10:17 +08:00
bunnie
0ee9ec1d80 bump version numbers for crate publication 2022-10-25 22:38:58 +08:00
bunnie
30ea893c74
Merge branch 'main' into xous-rs-os-selection 2022-10-25 17:28:33 +08:00
bunnie
d331d405ee bump version numbers for publication 2022-10-25 17:23:40 +08:00
bunnie
67fc21fbdd harmonize hosted mode selection, but retain an explicit hosted flag
In general, hosted mode is assumed "by default" if the target
is not Xous. This allows packages to be built cleanly on command
lines that don't know to pass a --feature flag to specify a target.

However, an explicit "hosted" flag is still retained so that we
can confirm the build system intent. This saves us from the failure
mode that we thought we were building for target A, but accidentally
ommitted the flag, and instead we've been silently building for
"hosted" mode without any warning. The main consumer of the "hosted"
flag is now just the build.rs script inside of the utralib.
2022-10-25 17:21:02 +08:00
bunnie
65e9e2399d more detail on where time is being spent in the vault 2022-10-24 02:36:07 +08:00
bunnie
1256f6f713 add vault-perf to profile performance issues in vault 2022-10-24 00:37:18 +08:00
bunnie
805a7d528c flip back to using remote references 2022-10-20 16:30:06 +08:00
bunnie
8e05925cfa somehow the transition to local paths got missed in the merge 2022-10-18 00:39:01 +08:00
bunnie
0584ad2f2c switch to local paths to see if this helps the build 2022-10-18 00:26:56 +08:00
bunnie
4d1da235a9 bump revs that depend on susres to absorb changes 2022-10-17 05:11:09 +08:00
bunnie
4b368d71db bump versions of crates 2022-10-15 01:31:54 +08:00
bunnie
63a87ca1bc bump all the versions 2022-10-14 16:54:43 +08:00
bunnie
ff30131f43 absorb more fixes into the kernel 2022-10-13 04:08:56 +08:00
bunnie
3503965f98 bump versions to absorb xous-rs changes 2022-10-13 03:41:16 +08:00
bunnie
be239f9812
Merge pull request #238 from Foundation-Devices/from-into
Implement From instead of Into.
2022-10-12 11:49:19 -07:00
Jean-Pierre De Jesus DIAZ
5971507410
apps/vault: Implement Display instead of Into
Avoid allocations in some cases, for example, when formatting
to an I/O buffer. Or when formatting an string.

Signed-off-by: Jean-Pierre De Jesus DIAZ <me@jeandudey.tech>
2022-10-12 15:39:01 +02:00
Jean-Pierre De Jesus DIAZ
01bc25c55d
apps/vault: Implement From instead of Into
Signed-off-by: Jean-Pierre De Jesus DIAZ <me@jeandudey.tech>
2022-10-12 15:38:37 +02:00
bunnie
f8a2ea51bb remove rkyv warnings from xous-api-names 2022-10-10 03:16:40 +08:00
bunnie
02b80425f5 bump xous-rs to absorb change in language specification 2022-10-10 03:07:44 +08:00
bunnie
3bca9de2a0 bump version numbers for xous-kernel patch
this fixes tests in CI
2022-10-05 23:51:35 +08:00
bunnie
969f93b001 cross-repo update versions from xous-rs bump 2022-10-05 18:32:44 +08:00
bunnie
9dcc0a3386 absorb ticktimer api bump, propagated from susres bump 2022-10-03 04:40:06 +08:00
bunnie
d2b2383d1a bump susres version 2022-10-03 04:36:32 +08:00
bunnie
b184bfbe6a move ticktimer to remote api 2022-10-03 03:37:38 +08:00
bunnie
89ca75c4bf move over to remote susres api 2022-10-03 02:24:44 +08:00
bunnie
6123e8ff9b xous-names conversion to crates.io 2022-10-03 01:18:20 +08:00
bunnie
de514ac66f rename packages in prep for upload to crates.io 2022-10-03 00:24:45 +08:00
bunnie
4e40ae6c5d move from target selectors to feature selectors for back-ends
This will allow for e.g. xous on riscv32-imac but not a precursor
target, for example: by using feature selectors we get to have
a bigger range of targets that we support, such as for implementations
that haven't been upstreamed or have official target-triples.

The downsides are:

- patch override libraries don't absorb feature flags. so, for
example, the AES crate that is used to patch other crates won't
be aware of the target features without modifying the referencing
crates.

- features are normally meant to be additive, but target features
are mutually exclusive. The mutex is enforced by a check in
utralib that throws a panic on build if two targets are accidentally
selected at the same time.
2022-10-02 02:56:44 +08:00
bunnie
52728bce1f more xous-ipc bumps 2022-09-27 01:15:00 +08:00
bunnie
f188e0f866 re-bump xous-ipc to 0.9.9 2022-09-26 16:50:38 +08:00
bunnie
507ab42836 downgrade xous-ipc to 0.9.7 until i have permissions to push a new version 2022-09-26 16:11:26 +08:00
bunnie
3579dfdd17 update xous-ipc and xous versions 2022-09-26 16:07:35 +08:00
bunnie
114d60bc53 migrate logserver API to external package 2022-09-26 14:06:46 +08:00
bunnie
72859d18dd fix UX update issue on FIDO adding records.
maybe need to also chase this down in the password add new area too?

need to check.
2022-09-23 00:37:15 +08:00
bunnie
278570d8d3 progress on issue #223
This adds the abort flow to the U2F approvals. Needs more testing.
2022-09-23 00:27:14 +08:00
bunnie
13402b99b9 fix #224
was a logic bug where the database name was not updated while
doing some refactoring previously
2022-09-22 22:05:57 +08:00
bunnie
8fe4c50373 improve error reproting on #206 2022-09-20 23:24:42 +08:00
bunnie
ba45fc2685 fix validator issue on hotp count 2022-09-20 23:13:18 +08:00
bunnie
9225cbaba3 resolve issue #206 by adding check for existing basis 2022-09-20 23:06:22 +08:00
bunnie
22a440f75f Add HOTP initial count feature; try to fix HOTP panic
- HOTP now prompts for an initial count
- Found a code path where improperly formatted HOTP field can
lead to a 0-value being passed to a totp generator
- Added guardrails around the TOTP generator so it can't divide by 0:
it issues a warning instead.
2022-09-19 23:44:45 +08:00
bunnie
47ce1e3149 add version history for TOTP records 2022-09-18 21:53:35 +08:00
bunnie
d1cda8f669 add hotp support
hotp is merged as a "minor" feature off of totp. In other words,
the default mode is totp, but one can specify a totp record
to be an hotp record and it will behave as an hotp record.

We re-use the "step_seconds" field to specify the count parameter.
There is no separate initial count / count field -- the two are
tracked in a single u64 that is stored in the "step_seconds" field
of what would be a totp record.

This also revs the TOTP record to v2. This *should* not break
anything:

- v1 records deserialize as totp records into v2 (which is correct,
as there are no hotp in v1)
- when a v1 record is saved to disk, it is stored in v2 format
- v1 records that are not edited stay as v1
2022-09-17 00:39:47 +08:00
bunnie
fad3aa6ec0 fix fido readback from test vectors made in hosted mode 2022-09-17 00:39:19 +08:00
bunnie
b22e3a1b43 fix dependabot security issue in base64 dependency 2022-09-11 21:48:20 +08:00
bunnie
3899f25837 add a usability note 2022-09-09 15:35:16 +08:00
bunnie
7902676918 note dependency for protobuf-compiler for the upload tool to work 2022-09-09 15:33:10 +08:00
Nickolai Zeldovich
6e1e2acd28 minor cleanup 2022-08-31 15:33:27 -04:00
Nickolai Zeldovich
b604b746e9 format conversion for importing Google Authenticator TOTP 2022-08-31 14:38:06 -04:00
bunnie
9a4933b648 Merge branch 'main' into rustls-exp2 2022-08-16 15:13:56 +08:00
bunnie
1ff85cab41 add note about host readout to the README.md 2022-08-14 00:21:53 +08:00
bunnie
a9e9592094 improve error messaging when host readout is not enabled 2022-08-14 00:20:46 +08:00
bunnie
eb2fda3c6c
Merge pull request #213 from gsora/feat/vault-bitwarden-import
feat(vault): support Bitwarden export formatting for Vault
2022-08-14 00:01:07 +08:00
bunnie
e7576ebb42 reduce debug level on vault 2022-08-13 23:55:40 +08:00
bunnie
8570449b04 make vendor backup locked out by default; hook to UX enable dialog box
also halts updates of the TOTP timer bar while this is happening
to avoid overflowing the server queue with unanswered redraw
requests
2022-08-13 23:54:36 +08:00
Gianguido Sorà
5acb0af82b feat(vault): support Bitwarden export formatting for Vault
Allows folks with Bitwarden data to (mostly) import it in Vault, both
passwords and TOTPs.
2022-08-13 17:40:25 +02:00
Gianguido Sorà
1defdff915 chore(vault): add serde_repr for vaultbackup-rs 2022-08-13 17:40:02 +02:00
Gianguido Sorà
9a219d8aba chore(vault): add default for PasswordEntries 2022-08-13 17:39:37 +02:00
bunnie
56172e37a9 shift vendor command space to 0x70 range
this avoids conflicts with OpenSK and open-ssh's handling
of their vendor commands.
2022-08-13 22:25:07 +08:00
Gianguido Sorà
dca1ec86de fix(vault): don't panic when reading backup::PayloadType off an empty
vec
2022-08-13 16:01:51 +02:00
bunnie
9e0b63c871 make the "hash" arguments match the display UX values
that way any entries that would show up "exactly" as the same
description would flag as conflicts on re-upload
2022-08-13 21:46:06 +08:00
bunnie
7ec39e4be6 strip out the random-guid code 2022-08-13 21:37:56 +08:00
Gianguido Sorà
cd42cf6395 fix(vault): storage for totp and passwords derive pddb key from their
unique content

Instead of generating a unique GUID every time a new record gets
created, hash known unique content for every entry and use that as key.

The StorageContent trait now has a hash() method that returns a Vec
containing the SHA-256 hash of the object's unique content.

Hashing is done by re-using the same calls that ctap uses.

This allows dupes detection when restoring a backup, allowing us to
employ a "never overwrite" policy: Precursor is the main source of truth
for such data.
2022-08-13 13:29:42 +02:00
Gianguido Sorà
cdfae27afc feat(vault): implement basics of dupe detection
Still needs a way to deterministically generate a key for each entry.

Idea: a `hash() -> String` method on StorageContent so that new_record
can call it, store said object with the newly-generated key.

Since this is a deterministic operation, restoring a backup with dupes
would not overwrite what's present in PDDB already.
2022-08-12 18:47:38 +02:00
Gianguido Sorà
473e1cf77b chore(vault): address warnings 2022-08-12 17:37:51 +02:00
Gianguido Sorà
51b04fe14e Merge branch 'main' into feat/vault-usb-totp-loading 2022-08-12 17:16:30 +02:00
Gianguido Sorà
29dfe4eb98 feat(vault): add logging, support Wire format 2022-08-12 16:57:47 +02:00
Gianguido Sorà
115781b979 feat(vault): implement VendorSession for backup/restore calls that span
multiple CTAPHID sessions
2022-08-12 16:57:05 +02:00
Gianguido Sorà
a594342d03 feat(vault): add bulk new record method on storage abstraction
Instead of syncing for each new record, new_records() only syncs:
- when it's writing an entry that has index multiple of 10
- when it's the last packet in sequence
2022-08-12 16:55:59 +02:00
Gianguido Sorà
2e50699c82 feat(vault): add Wire type for >7601 bytes of CTAPHID payload 2022-08-12 16:55:12 +02:00
Gianguido Sorà
5758b1d4c0 feat(vault): handle usb restore for >7601 bytes of payload 2022-08-12 16:54:26 +02:00
bunnie
2e0f1df894 intermediate commit through experiments 2022-08-12 15:56:05 +08:00
bunnie
6fff73ace8 fix missing path to try_send_message 2022-08-11 03:11:47 +08:00
bunnie
cfa65a3a72 add some notes about integration with #205 2022-08-11 02:48:56 +08:00