clean up the warnings that are deemed safe to clean up

one warning remains, will address this in a future PR.
This commit is contained in:
bunnie 2023-07-16 17:55:28 +08:00
parent e65398815a
commit 9932d971c4
3 changed files with 2 additions and 3 deletions

View file

@ -921,7 +921,7 @@ impl<'a> ActionManager<'a> {
#[cfg(feature="vaultperf")]
self.perfentry(&self.pm, PERFMETA_NONE, 2, std::line!());
if let Some(mut prev_entry) = il.get(self.mode_cache, &lookup_key) {
if let Some(prev_entry) = il.get(self.mode_cache, &lookup_key) {
#[cfg(feature="vaultperf")]
self.perfentry(&self.pm, PERFMETA_STARTBLOCK, 3, std::line!());
prev_entry.dirty = true;

View file

@ -162,7 +162,6 @@ pub(crate) fn list_path(
utils::split_basis_and_dict(path, || basis_cache.basis_latest().map(|m| m.to_owned()))
.or(Err(crate::PddbRetcode::InternalError))?;
core::mem::drop(path);
core::mem::drop(reader);
let mut writer = backing

View file

@ -2613,7 +2613,7 @@ impl<'a> RootKeys {
pub fn commit_signature(&self, sig: Signature, len: u32, sig_type: SignatureType) -> Result<(), RootkeyResult> {
let mut sig_region: [u8; core::mem::size_of::<SignatureInFlash>()] = [0; core::mem::size_of::<SignatureInFlash>()];
// map a structure onto the signature region, so we can do something sane when writing stuff to it
let mut signature: &mut SignatureInFlash = unsafe{(sig_region.as_mut_ptr() as *mut SignatureInFlash).as_mut().unwrap()}; // this pointer better not be null, we just created it!
let signature: &mut SignatureInFlash = unsafe{(sig_region.as_mut_ptr() as *mut SignatureInFlash).as_mut().unwrap()}; // this pointer better not be null, we just created it!
signature.version = SIG_VERSION;
signature.signed_len = len;