From 9932d971c432bc83d4e67a2b3093f2c3cf629321 Mon Sep 17 00:00:00 2001 From: bunnie Date: Sun, 16 Jul 2023 17:55:28 +0800 Subject: [PATCH] clean up the warnings that are deemed safe to clean up one warning remains, will address this in a future PR. --- apps/vault/src/actions.rs | 2 +- services/pddb/src/libstd/mod.rs | 1 - services/root-keys/src/implementation.rs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/vault/src/actions.rs b/apps/vault/src/actions.rs index 485b14202..d3301dafd 100644 --- a/apps/vault/src/actions.rs +++ b/apps/vault/src/actions.rs @@ -921,7 +921,7 @@ impl<'a> ActionManager<'a> { #[cfg(feature="vaultperf")] self.perfentry(&self.pm, PERFMETA_NONE, 2, std::line!()); - if let Some(mut prev_entry) = il.get(self.mode_cache, &lookup_key) { + if let Some(prev_entry) = il.get(self.mode_cache, &lookup_key) { #[cfg(feature="vaultperf")] self.perfentry(&self.pm, PERFMETA_STARTBLOCK, 3, std::line!()); prev_entry.dirty = true; diff --git a/services/pddb/src/libstd/mod.rs b/services/pddb/src/libstd/mod.rs index 0cd11956b..efa664143 100644 --- a/services/pddb/src/libstd/mod.rs +++ b/services/pddb/src/libstd/mod.rs @@ -162,7 +162,6 @@ pub(crate) fn list_path( utils::split_basis_and_dict(path, || basis_cache.basis_latest().map(|m| m.to_owned())) .or(Err(crate::PddbRetcode::InternalError))?; - core::mem::drop(path); core::mem::drop(reader); let mut writer = backing diff --git a/services/root-keys/src/implementation.rs b/services/root-keys/src/implementation.rs index f857e8fd3..ca9c99a1d 100644 --- a/services/root-keys/src/implementation.rs +++ b/services/root-keys/src/implementation.rs @@ -2613,7 +2613,7 @@ impl<'a> RootKeys { pub fn commit_signature(&self, sig: Signature, len: u32, sig_type: SignatureType) -> Result<(), RootkeyResult> { let mut sig_region: [u8; core::mem::size_of::()] = [0; core::mem::size_of::()]; // map a structure onto the signature region, so we can do something sane when writing stuff to it - let mut signature: &mut SignatureInFlash = unsafe{(sig_region.as_mut_ptr() as *mut SignatureInFlash).as_mut().unwrap()}; // this pointer better not be null, we just created it! + let signature: &mut SignatureInFlash = unsafe{(sig_region.as_mut_ptr() as *mut SignatureInFlash).as_mut().unwrap()}; // this pointer better not be null, we just created it! signature.version = SIG_VERSION; signature.signed_len = len;