saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[caffe2] Remove cxx override to c++17 (#108687)

Browse source 
Summary: Allow the user to specify the cxx version to use when compiling. For applications that compile with C++20, we wish to also compile this library with C++20 to avoid subtle ODR violations with using different library standards.

Test Plan: Built the project successfully.

Reviewed By: smeenai

Differential Revision: D48636406

Pull Request resolved: https://github.com/pytorch/pytorch/pull/108687
Approved by: https://github.com/davidberard98
This commit is contained in:
Vincent Lee 2023-09-12 02:54:59 +00:00 committed by PyTorch MergeBot
parent b1f21399c8
commit 15202cc80c
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
buckbuild.bzl
View file

@ -186,9 +186,7 @@ def third_party(name):
def get_pt_compiler_flags():
return select({
"DEFAULT": _PT_COMPILER_FLAGS + [
"-std=gnu++17", #to accommodate for eigen
],
"DEFAULT": _PT_COMPILER_FLAGS,
"ovr_config//compiler:cl": windows_convert_gcc_clang_flags(_PT_COMPILER_FLAGS),
})