From 15202cc80c0c73bf87b95ef82cb0bc74316f465b Mon Sep 17 00:00:00 2001 From: Vincent Lee Date: Tue, 12 Sep 2023 02:54:59 +0000 Subject: [PATCH] [caffe2] Remove cxx override to c++17 (#108687) Summary: Allow the user to specify the cxx version to use when compiling. For applications that compile with C++20, we wish to also compile this library with C++20 to avoid subtle ODR violations with using different library standards. Test Plan: Built the project successfully. Reviewed By: smeenai Differential Revision: D48636406 Pull Request resolved: https://github.com/pytorch/pytorch/pull/108687 Approved by: https://github.com/davidberard98 --- buckbuild.bzl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/buckbuild.bzl b/buckbuild.bzl index 87d8bfd2b68..36ffb4f17b7 100644 --- a/buckbuild.bzl +++ b/buckbuild.bzl @@ -186,9 +186,7 @@ def third_party(name): def get_pt_compiler_flags(): return select({ - "DEFAULT": _PT_COMPILER_FLAGS + [ - "-std=gnu++17", #to accommodate for eigen - ], + "DEFAULT": _PT_COMPILER_FLAGS, "ovr_config//compiler:cl": windows_convert_gcc_clang_flags(_PT_COMPILER_FLAGS), })