saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
pytorch/.flake8

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

77 lines
2.9 KiB
Text
Raw Normal View History

[pep8] Fix most lint automatically with autopep8 Here's the command I used to invoke autopep8 (in parallel!): git ls-files | grep '\.py$' | xargs -n1 -P`nproc` autopep8 -i Several rules are ignored in setup.cfg. The goal is to let autopep8 handle everything which it can handle safely, and to disable any rules which are tricky or controversial to address. We may want to come back and re-enable some of these rules later, but I'm trying to make this patch as safe as possible. Also configures flake8 to match pep8's behavior. Also configures TravisCI to check the whole project for lint.
2017-01-27 20:52:21 +00:00
[flake8]
Enable ruff in lintrunner (#99785) ### This change - Implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does **both linting and fixing**. 🔧 - Migrated all flake8 configs to the ruff config and enabled it for the repo. ✅ - **`ruff` lints the whole repo in under 2s** 🤯 Fixes https://github.com/pytorch/pytorch/issues/94737 Replaces #99280 @huydhn @Skylion007 <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 6b982dd</samp> ### Summary 🧹🛠️🎨 <!-- 1. 🧹 This emoji represents cleaning or tidying up, which is what `ruff` does by formatting and linting the code. It also suggests improving the code quality and removing unnecessary or redundant code. 2. 🛠️ This emoji represents tools or fixing, which is what `ruff` is as a code formatter and linter. It also suggests enhancing the code functionality and performance, and resolving potential issues or bugs. 3. 🎨 This emoji represents art or creativity, which is what `ruff` allows by providing a consistent and configurable style for the code. It also suggests adding some flair or personality to the code, and making it more readable and enjoyable. --> Add `[tool.ruff]` section to `pyproject.toml` to configure `ruff` code formatter and linter. This change aims to improve code quality and consistency with a single tool. > _`ruff` cleans the code_ > _like a spring breeze in the fields_ > _`pyproject.toml`_ ### Walkthrough * Configure `ruff` code formatter and linter for the whole project ([link](https://github.com/pytorch/pytorch/pull/99785/files?diff=unified&w=0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R22-R79)) Pull Request resolved: https://github.com/pytorch/pytorch/pull/99785 Approved by: https://github.com/malfet, https://github.com/Skylion007
2023-04-24 15:37:13 +00:00
# NOTE: **Mirror any changes** to this file the [tool.ruff] config in pyproject.toml
# before we can fully move to use ruff
[BE] Add flake8-logging-format linter (#94840) Follow up to #94708 Pull Request resolved: https://github.com/pytorch/pytorch/pull/94840 Approved by: https://github.com/ezyang
2023-02-15 17:54:50 +00:00
enable-extensions = G
[BE]: Enable a few additional ruff rules (#130700) Enables a few extra ruff rules, most of which do not have any violations as I already cleaned them with earlier PRs, these just turns them on to enforce them. Adds 1 noqa as we want the suboptimal lambda generation + call kept as a test. Also enables the test in flake8 Pull Request resolved: https://github.com/pytorch/pytorch/pull/130700 Approved by: https://github.com/justinchuby, https://github.com/ezyang
2024-07-17 02:06:02 +00:00
select = B,C,E,F,G,P,SIM1,SIM911,T4,W,B9,TOR0,TOR1,TOR2,TOR9
[pep8] Fix most lint automatically with autopep8 Here's the command I used to invoke autopep8 (in parallel!): git ls-files | grep '\.py$' | xargs -n1 -P`nproc` autopep8 -i Several rules are ignored in setup.cfg. The goal is to let autopep8 handle everything which it can handle safely, and to disable any rules which are tricky or controversial to address. We may want to come back and re-enable some of these rules later, but I'm trying to make this patch as safe as possible. Also configures flake8 to match pep8's behavior. Also configures TravisCI to check the whole project for lint.
2017-01-27 20:52:21 +00:00
max-line-length = 120
Suppress C408 lint (don't use dict constructor) (#17813) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/17813 We have a lot of manually written out dict() constructors, and (1) I don't think use of curly brace syntax is much of an improvement and (2) it seems like a waste of time to fix them all. Reviewed By: eellison Differential Revision: D14390136 fbshipit-source-id: 6199bef4dea75b6079bcb9d9e8acf20a2e1a86e1
2019-03-08 20:15:49 +00:00
# C408 ignored because we like the dict keyword argument syntax
Enable flake8-bugbear line length checking. (#18138) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/18138 ghimport-source-id: be62a71ef98714e6f168a00f84120f612363528e Stack from [ghstack](https://github.com/ezyang/ghstack): * **#18138 Enable flake8-bugbear line length checking.** flake8-bugbear's line length checker (B950) which permits violations of up to 10% but specifies the "true" limit when you go over. I had to ignore a bunch of flake8-bugbear's other checks when I turned this on. They're good checks though (they're turned on in fbcode) and we should fix them eventually. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Reviewed By: salexspb Differential Revision: D14508678 fbshipit-source-id: 2610ecc0dd43cc0788d77f4d024ebd85b26b8d41
2019-03-19 20:25:04 +00:00
# E501 is not flexible enough, we're using B950 instead
ignore =
[BE]: Enable F821 and fix bugs (#116579) Fixes #112371 I tried to fix as many of the bugs as I could, a few I could not figure out what the proper fix for them was though and so I left them with noqas. Pull Request resolved: https://github.com/pytorch/pytorch/pull/116579 Approved by: https://github.com/ezyang
2024-01-01 08:40:46 +00:00
E203,E305,E402,E501,E721,E741,F405,F841,F999,W503,W504,C408,E302,W291,E303,
Upgrade lint. (#39483) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/39483 I fixed all of the new errors that occurred because of the upgrade. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D21884575 Pulled By: ezyang fbshipit-source-id: 45c8e1f1ecb410c8d7c46dd3922ad70e982a0685
2020-06-04 19:53:53 +00:00
# shebang has extra meaning in fbcode lints, so I think it's not worth trying
# to line this up with executable bit
EXE001,
Completely synchronize behavior of Facebook flake8 and public flake8. (#18538) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/18538 ghimport-source-id: 665b09f158d1c5dd94686d4212792504b55b7f73 Stack from [ghstack](https://github.com/ezyang/ghstack): * **#18538 Completely synchronize behavior of Facebook flake8 and public flake8.** Previously, developers at Facebook had the very funny experience wherein /usr/local/bin/flake8 behaved differently than a freshly installed flake8 from pip. In this commit, I add enough ignores to .flake8 and install enough plugins to make the Facebook flake8 and public flake8 line up exactly. These means you don't have to care which flake8 you use; they all will report accurate information on your Python files. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: D14652336 fbshipit-source-id: ba7776eaa139cf2e3df2e65349da6fd7c99acca4
2019-03-28 02:46:23 +00:00
# these ignores are from flake8-bugbear; please fix!
fix: Flake8-BugBear code B-026 for PyTorch (#111362) Fixes #106571 I have fixed the B-026 error codes for Flake8 tests on the codebase. Please review and tell me anything else to do. Thanks and excited for this first contribution to PyTorch. Also I refer this issue which introduced [B-026](https://github.com/PyCQA/flake8-bugbear/issues/286) in `pytest-bugbear` and discuss the error code. Pull Request resolved: https://github.com/pytorch/pytorch/pull/111362 Approved by: https://github.com/Skylion007
2023-11-07 21:38:13 +00:00
B007,B008,B017,B019,B023,B028,B903,B904,B905,B906,B907
Completely synchronize behavior of Facebook flake8 and public flake8. (#18538) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/18538 ghimport-source-id: 665b09f158d1c5dd94686d4212792504b55b7f73 Stack from [ghstack](https://github.com/ezyang/ghstack): * **#18538 Completely synchronize behavior of Facebook flake8 and public flake8.** Previously, developers at Facebook had the very funny experience wherein /usr/local/bin/flake8 behaved differently than a freshly installed flake8 from pip. In this commit, I add enough ignores to .flake8 and install enough plugins to make the Facebook flake8 and public flake8 line up exactly. These means you don't have to care which flake8 you use; they all will report accurate information on your Python files. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: D14652336 fbshipit-source-id: ba7776eaa139cf2e3df2e65349da6fd7c99acca4
2019-03-28 02:46:23 +00:00
# these ignores are from flake8-comprehensions; please fix!
[BE] Enable C419 rule for any all shortcircuiting (#99890) Apparently https://github.com/pytorch/pytorch/pull/78142 made torch.JIT allow for simple generator expressions which allows us to enable rules that replace unnecessary list comprehensions with generators in any/all. This was originally part of #99280 but I split it off into this PR so that it can be easily reverted should anything break. Pull Request resolved: https://github.com/pytorch/pytorch/pull/99890 Approved by: https://github.com/justinchuby, https://github.com/kit1980, https://github.com/malfet
2023-04-25 15:02:13 +00:00
C407,
[BE] Add flake8-logging-format linter (#94840) Follow up to #94708 Pull Request resolved: https://github.com/pytorch/pytorch/pull/94840 Approved by: https://github.com/ezyang
2023-02-15 17:54:50 +00:00
# these ignores are from flake8-logging-format; please fix!
[BE]: Enable Ruff + Flake8 G201,G202 logging format rule. (#114474) Standardizes logging calls to always use logging.exception instead of logging.error where appropriate and enforces it with a lint. Pull Request resolved: https://github.com/pytorch/pytorch/pull/114474 Approved by: https://github.com/jansel, https://github.com/malfet
2023-11-27 17:38:08 +00:00
G100,G101,G200
[BE] Enable flake8-simplify checks (#97984) Enable some sensible flake8-simplify rules. Mainly wanted to enable the SIM101, and `yield from` SIM103 checks. @kit1980 since you wanted to be tagged on this CI check. Enabling this check also helped flag one logical bug so it's definitely beneficial (also fixed in this PR). Pull Request resolved: https://github.com/pytorch/pytorch/pull/97984 Approved by: https://github.com/ezyang
2023-03-31 03:40:21 +00:00
# these ignores are from flake8-simplify. please fix or ignore with commented reason
[BE] Fix SIM109 `compare-with-tuple` (#100337) Use {replacement} instead of multiple equality comparisons Pull Request resolved: https://github.com/pytorch/pytorch/pull/100337 Approved by: https://github.com/Skylion007
2023-04-30 17:16:52 +00:00
SIM105,SIM108,SIM110,SIM111,SIM113,SIM114,SIM115,SIM116,SIM117,SIM118,SIM119,SIM12,
[BE] Enable flake8-simplify checks (#97984) Enable some sensible flake8-simplify rules. Mainly wanted to enable the SIM101, and `yield from` SIM103 checks. @kit1980 since you wanted to be tagged on this CI check. Enabling this check also helped flag one logical bug so it's definitely beneficial (also fixed in this PR). Pull Request resolved: https://github.com/pytorch/pytorch/pull/97984 Approved by: https://github.com/ezyang
2023-03-31 03:40:21 +00:00
# flake8-simplify code styles
SIM102,SIM103,SIM106,SIM112,
Add TorchFix to the CI (#113403) Enable flake8 plugin for https://github.com/pytorch/test-infra/tree/main/tools/torchfix - TorchFix 0.1.1. Disable TorchFix codes that don't make sense for PyTorch itself. Update deprecated TorchVision APIs to make TorchFix pass. Pull Request resolved: https://github.com/pytorch/pytorch/pull/113403 Approved by: https://github.com/Skylion007, https://github.com/malfet
2023-11-14 01:26:01 +00:00
# TorchFix codes that don't make sense for PyTorch itself:
# removed and deprecated PyTorch functions.
TOR001,TOR101,
Update TorchFix to 0.2.0 (#114190) Pull Request resolved: https://github.com/pytorch/pytorch/pull/114190 Approved by: https://github.com/malfet
2023-11-21 03:46:24 +00:00
# TODO(kit1980): fix all TOR102 issues
# `torch.load` without `weights_only` parameter is unsafe
TOR102,
Update to TorchFix 0.4.0 (#119424) `torch.library.Library` updated to `torch.library._scoped_library` in files with many tests where it seems obvious to do, otherwise `noqa: TOR901` added - see https://github.com/pytorch/pytorch/pull/118318 for more context. Pull Request resolved: https://github.com/pytorch/pytorch/pull/119424 Approved by: https://github.com/zou3519
2024-02-12 23:30:08 +00:00
# TODO(kit1980): resolve all TOR003 issues
# pass `use_reentrant` explicitly to `checkpoint`.
TOR003
[torchgen] Introduce Executorch types and signatures (#90781) Retry of #90591, which is a retry of #89595. Reverted due to dependency PR breaking internal fbcode. ## Forked BaseCppType Created a module for Executorch: `torchgen.executorch`. ## In `torchgen.executorch.api.types.types`: * Define `BaseCppType` with `torch::executor` namespace. ## In `torchgen.executorch.api.et_cpp`: * Help generate `NamedCType` for `ExecutorchCppSignature` arguments. ## In `torchgen.executorch.api.types.signatures`: * Define the signature using these types. (`ExecutorchCppSignature`) ## In `torchgen.executorch.api.types.__init__`: * Suppress flake8 error for `import *`. Pull Request resolved: https://github.com/pytorch/pytorch/pull/90781 Approved by: https://github.com/ezyang
2022-12-14 00:55:39 +00:00
per-file-ignores =
__init__.py: F401
[BE]: Enable F821 and fix bugs (#116579) Fixes #112371 I tried to fix as many of the bugs as I could, a few I could not figure out what the proper fix for them was though and so I left them with noqas. Pull Request resolved: https://github.com/pytorch/pytorch/pull/116579 Approved by: https://github.com/ezyang
2024-01-01 08:40:46 +00:00
test/**: F821
test/**/__init__.py: F401,F821
[torchgen] Introduce Executorch types and signatures (#90781) Retry of #90591, which is a retry of #89595. Reverted due to dependency PR breaking internal fbcode. ## Forked BaseCppType Created a module for Executorch: `torchgen.executorch`. ## In `torchgen.executorch.api.types.types`: * Define `BaseCppType` with `torch::executor` namespace. ## In `torchgen.executorch.api.et_cpp`: * Help generate `NamedCType` for `ExecutorchCppSignature` arguments. ## In `torchgen.executorch.api.types.signatures`: * Define the signature using these types. (`ExecutorchCppSignature`) ## In `torchgen.executorch.api.types.__init__`: * Suppress flake8 error for `import *`. Pull Request resolved: https://github.com/pytorch/pytorch/pull/90781 Approved by: https://github.com/ezyang
2022-12-14 00:55:39 +00:00
torch/utils/cpp_extension.py: B950
torchgen/api/types/__init__.py: F401,F403
torchgen/executorch/api/types/__init__.py: F401,F403
Enhance torch.vmap support from inside torch.compile (#116050) This work rewrites vmap support in torch.compile by inlining most of the frames into the existing FX graph. It also unlocks to PyTorch to support features that were previously missing, such as keyword args. Fixes: https://github.com/pytorch/pytorch/issues/114306 Pull Request resolved: https://github.com/pytorch/pytorch/pull/116050 Approved by: https://github.com/zou3519
2024-01-19 15:36:51 +00:00
test/dynamo/test_higher_order_ops.py: B950
torch/testing/_internal/dynamo_test_failures.py: B950
Update to TorchFix 0.4.0 (#119424) `torch.library.Library` updated to `torch.library._scoped_library` in files with many tests where it seems obvious to do, otherwise `noqa: TOR901` added - see https://github.com/pytorch/pytorch/pull/118318 for more context. Pull Request resolved: https://github.com/pytorch/pytorch/pull/119424 Approved by: https://github.com/zou3519
2024-02-12 23:30:08 +00:00
# TOR901 is only for test, we want to ignore it for everything else.
# It's not easy to configure this without affecting other per-file-ignores,
# so we explicitly list every file where it's violated outside of test.
torch/__init__.py: F401,TOR901
torch/_custom_op/impl.py: TOR901
torch/_export/serde/upgrade.py: TOR901
torch/_functorch/vmap.py: TOR901
torch/_inductor/test_operators.py: TOR901
torch/_library/abstract_impl.py: TOR901
torch/_meta_registrations.py: TOR901
torch/_prims/__init__.py: F401,TOR901
torch/_prims/rng_prims.py: TOR901
torch/ao/quantization/fx/_decomposed.py: TOR901
torch/distributed/_functional_collectives.py: TOR901
torch/distributed/_spmd/data_parallel.py: TOR901
Ignore torch/distributed/_tensor/_collective_utils.py for TOR901 (#125082) Fixes https://github.com/pytorch/pytorch/issues/125050 Pull Request resolved: https://github.com/pytorch/pytorch/pull/125082 Approved by: https://github.com/malfet, https://github.com/Skylion007
2024-04-27 20:14:00 +00:00
torch/distributed/_tensor/_collective_utils.py: TOR901
Enforce PEP263 for PyTorch python codebase (#55346) Summary: All python files containing non-ASCII characters should be correctly annotated with `# -*- coding: utf-8 -*-` comment Delete number of superfluous UTF-8 characters, most commonly UTF-8 opening closing quotation mark U+2019 (’) instead of ascii apostrophe ', for example `Module’s`->`Module's` Pull Request resolved: https://github.com/pytorch/pytorch/pull/55346 Reviewed By: samestep Differential Revision: D27582044 Pulled By: malfet fbshipit-source-id: c1cd89655915858ff3a41f675cdfffff795a8e44
2021-04-07 01:29:56 +00:00
optional-ascii-coding = True
Exclude test/generated_type_hints_smoketest.py from flake8 (#50497) Summary: Similar to https://github.com/pytorch/pytorch/issues/48201, this PR excludes a file that is auto-generated by [`test/test_type_hints.py`](https://github.com/pytorch/pytorch/blob/5834438090a1b3206347e30968e48f44251a53a1/test/test_type_hints.py#L109-L111), which doesn't happen to be run before the Flake8 check is done in CI. Also, because the `exclude` list in `.flake8` has gotten fairly long, this PR splits it across multiple lines. Pull Request resolved: https://github.com/pytorch/pytorch/pull/50497 Test Plan: Run this in your shell: ```sh python test/test_type_hints.py TestTypeHints.test_doc_examples flake8 ``` - _Before:_ `flake8` prints [these 169 false positives](https://pastebin.com/qPJY24g8) and returns exit code 1 - _After:_ `flake8` prints no output and returns exit code 0 Reviewed By: mrshenli Differential Revision: D25903177 Pulled By: samestep fbshipit-source-id: 21f757ac8bfa626bb56ece2ecc55668912b71234
2021-01-13 20:22:50 +00:00
exclude =
Fix accidental Flake8 excludes (#55178) Summary: [Currently](https://github.com/pytorch/pytorch/blob/faa4da49ff6fdde8411572fe907e861e95ce2c85/.flake8#L22), our `.flake8` config file has the `exclude` pattern `scripts`. I'm guessing that this is just meant to exclude the top-level `scripts` dir from Flake8, but it also applies to the following (apparently erroneously): - `.circleci/scripts` - `.github/scripts` - `test/scripts` This PR corrects the problem by making all the `exclude` patterns (except for the wildcard `*.pyi` pattern) relative to the repository root. Also, since this PR already touches all the `exclude` lines, it also sorts them to help reduce merge conflicts when `.flake8` is edited in the future. This sorting happened to reveal that the `build` pattern was previously present twice, so now it has been deduplicated. Pull Request resolved: https://github.com/pytorch/pytorch/pull/55178 Test Plan: Locally: ``` flake8 ``` And also [in CI](https://github.com/pytorch/pytorch/pull/55178/checks?check_run_id=2249949511). Reviewed By: janeyx99 Differential Revision: D27520412 Pulled By: samestep fbshipit-source-id: 359275c10ca600ee4ce7906e3a7587ffaa4ae1ed
2021-04-01 23:23:25 +00:00
./.git,
./build_test_custom_build,
./build,
./caffe2,
./docs/caffe2,
./docs/cpp/src,
./docs/src,
Turn on linting for functorch (#81987) Test Plan: - wait for CI Pull Request resolved: https://github.com/pytorch/pytorch/pull/81987 Approved by: https://github.com/samdow
2022-07-22 15:48:16 +00:00
./functorch/docs,
./functorch/examples,
./functorch/notebooks,
Fix accidental Flake8 excludes (#55178) Summary: [Currently](https://github.com/pytorch/pytorch/blob/faa4da49ff6fdde8411572fe907e861e95ce2c85/.flake8#L22), our `.flake8` config file has the `exclude` pattern `scripts`. I'm guessing that this is just meant to exclude the top-level `scripts` dir from Flake8, but it also applies to the following (apparently erroneously): - `.circleci/scripts` - `.github/scripts` - `test/scripts` This PR corrects the problem by making all the `exclude` patterns (except for the wildcard `*.pyi` pattern) relative to the repository root. Also, since this PR already touches all the `exclude` lines, it also sorts them to help reduce merge conflicts when `.flake8` is edited in the future. This sorting happened to reveal that the `build` pattern was previously present twice, so now it has been deduplicated. Pull Request resolved: https://github.com/pytorch/pytorch/pull/55178 Test Plan: Locally: ``` flake8 ``` And also [in CI](https://github.com/pytorch/pytorch/pull/55178/checks?check_run_id=2249949511). Reviewed By: janeyx99 Differential Revision: D27520412 Pulled By: samestep fbshipit-source-id: 359275c10ca600ee4ce7906e3a7587ffaa4ae1ed
2021-04-01 23:23:25 +00:00
./scripts,
./test/generated_type_hints_smoketest.py,
./third_party,
./torch/include,
./torch/lib,
./venv,
*.pyi
Reference in a new issue Copy permalink