saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
pytorch/.flake8

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

35 lines
1.1 KiB
Text
Raw Normal View History

[pep8] Fix most lint automatically with autopep8 Here's the command I used to invoke autopep8 (in parallel!): git ls-files | grep '\.py$' | xargs -n1 -P`nproc` autopep8 -i Several rules are ignored in setup.cfg. The goal is to let autopep8 handle everything which it can handle safely, and to disable any rules which are tricky or controversial to address. We may want to come back and re-enable some of these rules later, but I'm trying to make this patch as safe as possible. Also configures flake8 to match pep8's behavior. Also configures TravisCI to check the whole project for lint.
2017-01-27 20:52:21 +00:00
[flake8]
More type stubs (#18511) Summary: Added stubs for: * The `device` module * The `cuda` module * Parts of the `optim` module * Began adding stubs for the `autograd` module. I'll annotate more later but `no_grad` and friends are probably the most used exports from it so it seemed like a good place to start. This would close #16996, although comments on that issue reference other missing stubs so maybe it's worth keeping open as an umbrella issue. The big remaining missing package is `nn`. Also added a `py.typed` file so mypy will pick up on the type stubs. That closes #17639. Pull Request resolved: https://github.com/pytorch/pytorch/pull/18511 Differential Revision: D14715053 Pulled By: ezyang fbshipit-source-id: 9e4882ac997063650e6ce47604b3eaf1232c61c9
2019-04-01 22:56:21 +00:00
select = B,C,E,F,P,T4,W,B9
[pep8] Fix most lint automatically with autopep8 Here's the command I used to invoke autopep8 (in parallel!): git ls-files | grep '\.py$' | xargs -n1 -P`nproc` autopep8 -i Several rules are ignored in setup.cfg. The goal is to let autopep8 handle everything which it can handle safely, and to disable any rules which are tricky or controversial to address. We may want to come back and re-enable some of these rules later, but I'm trying to make this patch as safe as possible. Also configures flake8 to match pep8's behavior. Also configures TravisCI to check the whole project for lint.
2017-01-27 20:52:21 +00:00
max-line-length = 120
Suppress C408 lint (don't use dict constructor) (#17813) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/17813 We have a lot of manually written out dict() constructors, and (1) I don't think use of curly brace syntax is much of an improvement and (2) it seems like a waste of time to fix them all. Reviewed By: eellison Differential Revision: D14390136 fbshipit-source-id: 6199bef4dea75b6079bcb9d9e8acf20a2e1a86e1
2019-03-08 20:15:49 +00:00
# C408 ignored because we like the dict keyword argument syntax
Enable flake8-bugbear line length checking. (#18138) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/18138 ghimport-source-id: be62a71ef98714e6f168a00f84120f612363528e Stack from [ghstack](https://github.com/ezyang/ghstack): * **#18138 Enable flake8-bugbear line length checking.** flake8-bugbear's line length checker (B950) which permits violations of up to 10% but specifies the "true" limit when you go over. I had to ignore a bunch of flake8-bugbear's other checks when I turned this on. They're good checks though (they're turned on in fbcode) and we should fix them eventually. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Reviewed By: salexspb Differential Revision: D14508678 fbshipit-source-id: 2610ecc0dd43cc0788d77f4d024ebd85b26b8d41
2019-03-19 20:25:04 +00:00
# E501 is not flexible enough, we're using B950 instead
ignore =
Remove flake8 E303 (too many blank lines) (#20225) Summary: similar to too few blank lines, I feel like this is not important enough to warrant breaking signal for all linters when it's violated. Pull Request resolved: https://github.com/pytorch/pytorch/pull/20225 Differential Revision: D15243480 Pulled By: suo fbshipit-source-id: 37cdc18daf09e07081e42b69c72d331d81660217
2019-05-07 23:25:46 +00:00
E203,E305,E402,E501,E721,E741,F405,F821,F841,F999,W503,W504,C408,E302,W291,E303,
Upgrade lint. (#39483) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/39483 I fixed all of the new errors that occurred because of the upgrade. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D21884575 Pulled By: ezyang fbshipit-source-id: 45c8e1f1ecb410c8d7c46dd3922ad70e982a0685
2020-06-04 19:53:53 +00:00
# shebang has extra meaning in fbcode lints, so I think it's not worth trying
# to line this up with executable bit
EXE001,
Completely synchronize behavior of Facebook flake8 and public flake8. (#18538) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/18538 ghimport-source-id: 665b09f158d1c5dd94686d4212792504b55b7f73 Stack from [ghstack](https://github.com/ezyang/ghstack): * **#18538 Completely synchronize behavior of Facebook flake8 and public flake8.** Previously, developers at Facebook had the very funny experience wherein /usr/local/bin/flake8 behaved differently than a freshly installed flake8 from pip. In this commit, I add enough ignores to .flake8 and install enough plugins to make the Facebook flake8 and public flake8 line up exactly. These means you don't have to care which flake8 you use; they all will report accurate information on your Python files. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: D14652336 fbshipit-source-id: ba7776eaa139cf2e3df2e65349da6fd7c99acca4
2019-03-28 02:46:23 +00:00
# these ignores are from flake8-bugbear; please fix!
B007,B008,
# these ignores are from flake8-comprehensions; please fix!
Fix all occurrences of C416. (#33429) Summary: C416: Unnecessary (list/set) comprehension - rewrite using list/set(). See https://pypi.org/project/flake8-comprehensions/ Pull Request resolved: https://github.com/pytorch/pytorch/pull/33429 Differential Revision: D19972858 Pulled By: ezyang fbshipit-source-id: faac042a94c59d737bd5ae983121a0a029346e23
2020-02-21 16:29:32 +00:00
C400,C401,C402,C403,C404,C405,C407,C411,C413,C414,C415
Revert "[torchgen] Introduce Executorch types and signatures (#90591)" This reverts commit ddf00c803b2a99f4eec8a040b53ee18f62800fdd. Reverted https://github.com/pytorch/pytorch/pull/90591 on behalf of https://github.com/seemethere due to Part of a stack that causes internal failures, see https://www.internalfb.com/intern/sandcastle/job/4503600464398605/insights
2022-12-13 03:36:31 +00:00
per-file-ignores = __init__.py: F401 torch/utils/cpp_extension.py: B950 torchgen/api/types/__init__.py: F401,F403
Enforce PEP263 for PyTorch python codebase (#55346) Summary: All python files containing non-ASCII characters should be correctly annotated with `# -*- coding: utf-8 -*-` comment Delete number of superfluous UTF-8 characters, most commonly UTF-8 opening closing quotation mark U+2019 (’) instead of ascii apostrophe ', for example `Module’s`->`Module's` Pull Request resolved: https://github.com/pytorch/pytorch/pull/55346 Reviewed By: samestep Differential Revision: D27582044 Pulled By: malfet fbshipit-source-id: c1cd89655915858ff3a41f675cdfffff795a8e44
2021-04-07 01:29:56 +00:00
optional-ascii-coding = True
Exclude test/generated_type_hints_smoketest.py from flake8 (#50497) Summary: Similar to https://github.com/pytorch/pytorch/issues/48201, this PR excludes a file that is auto-generated by [`test/test_type_hints.py`](https://github.com/pytorch/pytorch/blob/5834438090a1b3206347e30968e48f44251a53a1/test/test_type_hints.py#L109-L111), which doesn't happen to be run before the Flake8 check is done in CI. Also, because the `exclude` list in `.flake8` has gotten fairly long, this PR splits it across multiple lines. Pull Request resolved: https://github.com/pytorch/pytorch/pull/50497 Test Plan: Run this in your shell: ```sh python test/test_type_hints.py TestTypeHints.test_doc_examples flake8 ``` - _Before:_ `flake8` prints [these 169 false positives](https://pastebin.com/qPJY24g8) and returns exit code 1 - _After:_ `flake8` prints no output and returns exit code 0 Reviewed By: mrshenli Differential Revision: D25903177 Pulled By: samestep fbshipit-source-id: 21f757ac8bfa626bb56ece2ecc55668912b71234
2021-01-13 20:22:50 +00:00
exclude =
Fix accidental Flake8 excludes (#55178) Summary: [Currently](https://github.com/pytorch/pytorch/blob/faa4da49ff6fdde8411572fe907e861e95ce2c85/.flake8#L22), our `.flake8` config file has the `exclude` pattern `scripts`. I'm guessing that this is just meant to exclude the top-level `scripts` dir from Flake8, but it also applies to the following (apparently erroneously): - `.circleci/scripts` - `.github/scripts` - `test/scripts` This PR corrects the problem by making all the `exclude` patterns (except for the wildcard `*.pyi` pattern) relative to the repository root. Also, since this PR already touches all the `exclude` lines, it also sorts them to help reduce merge conflicts when `.flake8` is edited in the future. This sorting happened to reveal that the `build` pattern was previously present twice, so now it has been deduplicated. Pull Request resolved: https://github.com/pytorch/pytorch/pull/55178 Test Plan: Locally: ``` flake8 ``` And also [in CI](https://github.com/pytorch/pytorch/pull/55178/checks?check_run_id=2249949511). Reviewed By: janeyx99 Differential Revision: D27520412 Pulled By: samestep fbshipit-source-id: 359275c10ca600ee4ce7906e3a7587ffaa4ae1ed
2021-04-01 23:23:25 +00:00
./.git,
./build_test_custom_build,
./build,
./caffe2,
./docs/caffe2,
./docs/cpp/src,
./docs/src,
Turn on linting for functorch (#81987) Test Plan: - wait for CI Pull Request resolved: https://github.com/pytorch/pytorch/pull/81987 Approved by: https://github.com/samdow
2022-07-22 15:48:16 +00:00
./functorch/docs,
./functorch/examples,
./functorch/notebooks,
Fix accidental Flake8 excludes (#55178) Summary: [Currently](https://github.com/pytorch/pytorch/blob/faa4da49ff6fdde8411572fe907e861e95ce2c85/.flake8#L22), our `.flake8` config file has the `exclude` pattern `scripts`. I'm guessing that this is just meant to exclude the top-level `scripts` dir from Flake8, but it also applies to the following (apparently erroneously): - `.circleci/scripts` - `.github/scripts` - `test/scripts` This PR corrects the problem by making all the `exclude` patterns (except for the wildcard `*.pyi` pattern) relative to the repository root. Also, since this PR already touches all the `exclude` lines, it also sorts them to help reduce merge conflicts when `.flake8` is edited in the future. This sorting happened to reveal that the `build` pattern was previously present twice, so now it has been deduplicated. Pull Request resolved: https://github.com/pytorch/pytorch/pull/55178 Test Plan: Locally: ``` flake8 ``` And also [in CI](https://github.com/pytorch/pytorch/pull/55178/checks?check_run_id=2249949511). Reviewed By: janeyx99 Differential Revision: D27520412 Pulled By: samestep fbshipit-source-id: 359275c10ca600ee4ce7906e3a7587ffaa4ae1ed
2021-04-01 23:23:25 +00:00
./scripts,
./test/generated_type_hints_smoketest.py,
./third_party,
./torch/include,
./torch/lib,
./venv,
*.pyi
Reference in a new issue Copy permalink