Commit graph

408 commits

Author SHA1 Message Date
Jireh Tan
e8ddded4fe [BUG] Ensure regressor/seasonality names are valid; fixes #996
Ensures that `add_regressor` and `add_seasonality` are valid column names
to R, to ensure that the generated columns are then used downstream to fit
the model.

Why not put it in `validate_column_names`? Because `validate_column_names` is
also used to validate if holiday names (which can be scalar values in columns) are
valid. We want to allow `c('seans-bday', 'Xmas')` as a valid holiday input, so we
cannot then put it there.

Tested these changes by using devtools::testthat().

Resolves: #996
2019-06-25 09:39:14 -07:00
Louis Potok
4225bb5fc1 Add mdape to all diagnostics, and fix rolling median behavior. 2019-06-21 15:28:29 -07:00
Louis Potok
1b01ab9f76 add function and test for rolling median 2019-06-21 15:28:29 -07:00
Jireh Tan
a554873a38 [BUG/TST] Add validation to prevent fourier.order <= 0; addresses #980
In reverse order of importance, this change addresses:
  - #980, by adding validation to ensure that `fourier.order` > 0
  - changes all the tests that `expect_error` using the argument
    `fourier_order`, as the argument is named `fourier.order`, so
    the intent of the test is to validate the holiday names rather
    than to check the use of the correct argument name

Resolves: #980
2019-06-21 15:27:31 -07:00
Jose Angel Sanchez Castillejos
ebb304680d Remove ipython from requirements since it would break test for python 2 2019-05-31 11:23:49 -07:00
Jose Angel Sanchez Castillejos
7b34ea13f2 Update README with instructions to install from Makefile 2019-05-31 11:23:49 -07:00
Jose Angel Sanchez Castillejos
27e229a1e0 reformat code 2019-05-31 11:23:49 -07:00
Jose Angel Sanchez Castillejos
2102a5421d Remove test command in make file since test are run from insede container 2019-05-31 11:23:49 -07:00
Jose Angel Sanchez Castillejos
95d203894d Add Dockerfile, docker-compose and Makefile in order to be able to use this as an isolated env 2019-05-31 11:23:49 -07:00
Daniel Scally
0e0f1a607a Adding validation to Prophet.add_seasonality to prevent user setting fourier_order <= 0 2019-05-31 10:21:09 -07:00
Alessandro Romano
b77f85ffd8 Add figsize parameter to plot methods 2019-05-23 10:29:50 -07:00
Ben Letham
b0c30454b6 Mention that plotly must be separately installed 2019-05-21 16:05:56 -07:00
Ben Letham
ea0497eb22 Update README 2019-05-21 15:50:06 -07:00
Ben Letham
5c1aa61eae Update README 2019-05-21 15:49:30 -07:00
Ben Letham
0a22055c8c Update documentation 2019-05-21 15:41:58 -07:00
Ben Letham
5df4ea3e96 Recommend source install for R 2019-05-21 11:54:11 -07:00
Ben Letham
c6b2d2ce30 update gemfile version 2019-05-21 11:41:44 -07:00
Ben Letham
7ff33137eb Change to MIT license 2019-05-21 11:40:04 -07:00
Ben Letham
aac80e1856 Update ffi requirement in Gemfile 2019-05-20 11:58:20 -07:00
Ben Letham
a087eaec84 Fix FutureWarning in plotting by deregistering matplotlib converters (the future behavior). Also fix bad date formatting in non-daily plot that started came with change in matplotlib default in 3.0.2 2019-05-14 15:26:55 -07:00
Ben Letham
73c8faf15a py version bump 2019-05-14 09:11:21 -07:00
Sean J. Taylor
6a64410646 Merge branch 'master' of github.com:facebook/prophet 2019-05-13 23:00:24 -07:00
Sean J. Taylor
39e356ddbe Readying for 0.5 release 2019-05-13 23:00:12 -07:00
Ben Letham
a6a5864686 Run travis on Xenial 2019-05-13 17:09:41 -07:00
Ben Letham
0203a465f7 Allow pystan 2.19 2019-05-13 17:09:41 -07:00
Ben Letham
f09ad61c26 R documentation updates 2019-05-13 15:47:28 -07:00
Ben Letham
526468b6e8 Fix FutureWarning in test, for sorting because non-concatenation axis is not aligned 2019-05-13 15:28:58 -07:00
Ben Letham
fdac46ad40 Fix DeprecationWarning for float64 casting 2019-05-13 15:21:54 -07:00
Ben Letham
f660264e23 Don't allow timezones in pandas datetime 2019-05-13 15:00:45 -07:00
Ben Letham
df6bef8920 Replace to_numpy() with values to maintain pd 0.23.4 support 2019-05-13 13:51:27 -07:00
Ben Letham
28cd55241f Verify that cap > floor (#807) 2019-05-13 13:11:07 -07:00
Ben Letham
269133c133 Change cross validation performance metrics to first aggregate over horizon before computing rolling average (#839, #863) 2019-05-08 10:47:26 -07:00
Ben Letham
e9c017ba01 Default to Newton optimizer if less than 100 datapoints (#842, #870, #888) 2019-05-07 11:47:36 -07:00
Ben Letham
16b0166518 Bump dplyr requirement to 0.7.7 (#781) 2019-05-06 16:44:48 -07:00
Ben Letham
26f60c0a49 If ds column is int, convert to str before pd.to_datetime to avoid nanosecond casting (#675) 2019-05-06 16:38:13 -07:00
Ben Letham
4e5e223e4f Add plotly plot to quickstart example 2019-05-06 16:15:23 -07:00
Olof Höjvall
ee14933b3f Changed returned object of plot_plotly, addressing #937 (#954) 2019-05-06 13:55:25 -07:00
Ben Letham
ec7689f03e R fallback to Newton if non-zero return code from optimization, to match existing Py behavior (#654) 2019-05-06 09:49:29 -07:00
Ben Letham
7297d98764 Use OrderedDict for seasonalities (#643) 2019-05-03 10:44:23 -07:00
Ben Letham
c8f2e8f847 Warn in cross validation if initial period is less than seasonality (#557), and fix bug that can produce error if period > initial 2019-05-03 08:40:20 -07:00
Ben Letham
35d470cbff Meaningful error message if predict is called before fit (for #462) 2019-05-02 14:53:57 -07:00
Jerry Prawiharjo
c11e668c0d Add logger.warning when falling back to Newton method (#950)
This adds logger.warning when we fall back to Newton method.
2019-05-02 14:34:24 -07:00
Ray Bell
f9adb9623e WIP: remove python Series.nonzero warning (#931)
* add to_numpy()

* remove .values
2019-05-02 11:51:35 -07:00
Ray Bell
d21b0cf4fd DOC: move anaconda section to after pypi section (#924) 2019-04-17 17:15:00 -07:00
andrealouw
0f863bf94b Update requirements.txt (#917)
pandas>=0.23.4 is required to not encounter the following error when passing a holidays argument, since earlier in earlier version pandas the concat does not have a sort argument.

File "/usr/local/lib/python3.6/dist-packages/fbprophet/forecaster.py", line 454, in construct_holiday_dataframe
all_holidays = pd.concat((all_holidays, holidays_to_add), sort=False)
TypeError: concat() got an unexpected keyword argument 'sort'
2019-04-17 17:13:42 -07:00
Ben Letham
8456cad5c0 set to pystan 2.18.1 for travis 2019-04-17 17:02:53 -07:00
Olof Höjvall
c756d20100 Added a interactive Plotly plot of the forecast (#915) 2019-04-17 16:47:16 -07:00
Sean J. Taylor
a31a93480a
Merge pull request #896 from raybellwaves/patch-1
DOC: Add link to stack overflow
2019-03-28 10:15:41 -07:00
Sean J. Taylor
a69c0cc012
Merge pull request #904 from facebook/automated_fixup_code_of_conduct_file_exists
Adding Code of Conduct file
2019-03-28 10:15:11 -07:00
Facebook Community Bot
05311a8249 OSS Automated Fix: Addition of Code of Conduct 2019-03-27 15:26:13 -07:00