Commit graph

614 commits

Author SHA1 Message Date
Sam Snarr
57230997ba
updated readme with 'contributing' info (#1782) 2021-01-14 14:39:35 -08:00
Sam Snarr
3adcf9312d
imports RcppParallel and excludes one function that is already in the namespace by importing Rcpp (#1779) 2021-01-14 14:38:36 -08:00
Sam Snarr
2d8e6c7fd1
Added growth='flat' functionality in R (#1778)
* added `flat_growth_init()` function

* added validation for 'flat'

* changed `fit.prophet()` to handle `growth='flat'`

* added `trend='flat'` capabilities to `sample_predictive_trend()` and `fit.prophet()`

* updated STAN code to handle flat trend

* [Syntax fix] Removed unnecessary bracket

* updated documentation

* undid formatting that was accidentally applied by autoformatter

* undid more formatting that was accidentally applied by autoformatter

* added tests

* typo in `sample_predictive_trend()`

* updated notebook with example in R

* updated documentation
2021-01-14 13:53:08 -08:00
sim
73b53658e1
used regex to format the name variable for plotting holiday components (#1766)
* used regex to format the `name`

Removes all singlequotes (') and doublequotes (") in the `name` variable
and replaces all whitespace with an underscore. Now, `ggplot2::aes_string()` can handle a column
name like `New Year's Day`.

* Used backticks in the `name` variable instead of regular expressions

Essentially, I escaped the string `name` with backticks so that
`ggplot2::geom_line()` and `ggplot2::ggplot()` functions can use any
arbitrary input.
2021-01-08 13:22:56 -08:00
Ben Letham
fdb6b36506 Update gem versions 2021-01-07 13:39:47 -08:00
Ben Letham
8cf0e82598
Update build badge to GH actions 2021-01-07 13:21:35 -08:00
Ben Letham
eed6aa1660
Update build-and-test.yml 2021-01-07 13:18:51 -08:00
Ben Letham
dbf8cc373d
Add github actions CI configuration 2021-01-07 12:13:39 -08:00
Tim Gates
ff68962b2a
docs: fix simple typo, aribtrary -> arbitrary (#1761)
There is a small typo in docs/_docs/seasonality,_holiday_effects,_and_regressors.md.

Should read `arbitrary` rather than `aribtrary`.
2021-01-07 10:52:14 -08:00
Mark
91bb83e93e
The README file in this repo has a bad link - [404:NotFound] - MIT License (#1759)
The markup version of the readme that is displayed for the main page in this repo contains the following bad link:

MIT License
Status code [404:NotFound] - Link: https://github.com/facebook/prophet/blob/master/LICENSE.md

It should be - https://github.com/facebook/prophet/blob/master/LICENSE

**Extra**

This bad link was found by a tool I recently created as part of an new experimental hobby project: https://github.com/MrCull/GitHub-Repo-ReadMe-Dead-Link-Finder

Re-check this Repo using the tool’s website: http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3a%2f%2fgithub.com%2ffacebook%2fprophet

If you have any feedback on the tool itself, or the information provided here, then please feel free to share your thoughts by adding a comment here, or adding a “Discussions” comment in the tool’s Repo.
2021-01-07 10:51:11 -08:00
Luke Scales
9bc7fb77b5
Added optional colour to plot_cross_validation_metric (#1758)
* Added optional colour to plot_cross_validation_metric to facilitate the comparison of different model's performance on the one plot

* use color

Change from colour to color for consistency.

Co-authored-by: Ben Letham <bletham@gmail.com>
2021-01-07 10:50:18 -08:00
Devdutt Shenoi
20f590b726
[python] code quality improvements (#1745)
* Add DeepSource config

* Simplify if statement

* Refactor use of dict() with empty literal

* Use set comprehension syntax

* Refactor chained comparison

* Rewrite instances of list literal within set() as set literals

* Add test_slow to class definition
2020-12-08 15:35:54 -08:00
Aziz Alto
ee592451f2
Fix "UserWarning" in model.plot_components (#1732)
See the issue https://github.com/facebook/prophet/issues/1721
2020-11-10 11:21:23 -08:00
Pawel Kranzberg
ad3832bb19
Add SMAPE to diagnostics.R (#1711)
* Add SMAPE to diagnostics.R

Add symmetric mean absolute percentage error.
Include mdape and smape as default performance metrics.

* Add SMAPE to diagnostics.R

Add symmetric mean absolute percentage error.
Include mdape and smape as default performance metrics.

* sMAPE minor code formatting improvements

* Fixed smape function in diagnostics.R
2020-11-09 10:42:20 -08:00
Sharon Woo
4f34de0363
'Added checks to cutoffs and error messages if checks fail using ValueError. Fixed earlier bug' (#1718)
* Update error message: Dataframe has no rows #1650, added err msgs

* Added error messages and checks for cutoffs"
2020-11-06 21:46:01 -08:00
Pawel Kranzberg
97bb057de4
Update performance_metrics() in diagnostics.py (#1710)
* Update performance_metrics() in diagnostics.py

Include smape as a valid metric.
Add support for monthly horizons.

* Update performance_metrics() docstring

* Update performance_metrics() docstring

* Include smape in test_diagnostics.py

* sMAPE code formatting improvement
2020-11-06 21:29:32 -08:00
Greg Rafferty
0a33f381ba
X axis labels in plot_seasonality (#1707)
* changed x-axis format in plot_seasonality

* changed x-axis format in plot_seasonality
2020-11-06 21:20:59 -08:00
fbonaita
3a17402585
Tqdm flag (#1706)
* add disable_tqdm flag to diagnostics.py

* add comment to cross_validation()

* Replace boolean comparison operator

Co-authored-by: Marius Theiss <justusbersten@gmail.com>

* Fix indentation

* Restore original indentation

Co-authored-by: Filippo Bonaita <filippo.bonaita@corp.badoo.com>
Co-authored-by: Marius Theiss <justusbersten@gmail.com>
2020-11-06 21:02:54 -08:00
quant9
e41ed25646
add option to disable Newton fallback via set_options method (#1702) 2020-10-08 11:13:21 -07:00
Ben Letham
77da5b8c06 Update test to match Py 2020-09-03 17:21:30 -07:00
Ben Letham
3a436ec603 Update holidays version requirement, for TR 2020-09-03 17:09:24 -07:00
Ben Letham
5faacc9fd5 Update serialize test with version change 2020-09-03 16:51:00 -07:00
Ben Letham
cb966a5244 Fix issue with holidays in some years 2020-09-03 16:47:22 -07:00
Ben Letham
5e88ede101 Merge branch 'master' of https://github.com/facebookincubator/prophet 2020-09-02 19:22:03 -07:00
Ben Letham
01ae458895 Update docs, and gem versions 2020-09-02 19:21:21 -07:00
Sean J. Taylor
1ea9ca12f2
Merge pull request #1643 from mdancho84/stanheaders
facebook/prophet#1628 - Import StanHeaders to fix dyn.load error
2020-09-02 18:54:49 -07:00
Sean J. Taylor
201230e1a5
Alphabetize import block 2020-09-02 18:40:30 -07:00
Sean Taylor
838c72fb85 Split test into fast and slow part 2020-09-02 17:38:20 -07:00
Ben Letham
96848bcc92 Fix test for python38 2020-09-02 16:34:18 -07:00
Matt Dancho
d7cd1f299d facebook/prophet#1628 - Import StanHeaders to fix dyn.load error 2020-09-01 09:46:42 -04:00
Ben Letham
2061f251f8 Clean up script for R holidays, and regenerate 2020-08-27 18:36:18 -07:00
Greg Rafferty
3d0bb6e081
fix for comma-separated holidays (#1638)
* use holidays.get_list() to return list of holidays

* make_holidays_df now accepts states
2020-08-27 17:49:19 -07:00
Bas Jacobs
e992e0b7b6
Split non-existing holiday for NL in R (#1637)
* Split NL 'Bevrijdingsdag, Hemelvaart' holiday

* Split NL 'Bevrijdingsdag, Hemelvaart' holiday in generated_holidays.rda

Co-authored-by: Bas Jacobs <bas.jacobs@bax-shop.nl>
2020-08-24 12:22:37 -07:00
Ben Letham
181933b948 Change dataset for flat growth test 2020-08-24 09:17:29 -07:00
Ben Letham
6284fc0264 Fix artifacts in diagnostics nb markdown 2020-08-20 11:20:47 -07:00
Ben Letham
5e6c6a02f8 Refresh quickstart doc 2020-08-19 20:43:50 -07:00
Ben Letham
382448b8db Refresh markdown documentation 2020-08-19 20:40:04 -07:00
Ben Letham
ffedaa4eed Add new test file to manifest 2020-08-19 19:50:33 -07:00
Ben Letham
08df4cf470 Minor clarification for multiplicative seasonality docs 2020-08-19 19:29:20 -07:00
Ben Letham
4027a2153f Update diagnostics documentation 2020-08-19 18:57:17 -07:00
Ben Letham
6d3b7bb7ae Minor updates in contributing guidelines 2020-08-19 17:48:48 -07:00
Ben Letham
809c1b5662 Add serialization documentation 2020-08-19 17:36:00 -07:00
Ben Letham
6c3a8a8e07 Move flat trend docs to additional topics 2020-08-19 16:29:50 -07:00
Ben Letham
4a989b5693 Describe the use of extra regressors for seasonality with monthly data 2020-08-19 14:27:20 -07:00
Ben Letham
ff387078f3 Use monthly start frequency in doc 2020-08-19 14:22:57 -07:00
Ben Letham
b9601918f2 Update sub-daily components figure with continuous weekly seasonality 2020-08-19 14:13:57 -07:00
Ben Letham
64f71a9afc Add documentation about holidays with aggregated data 2020-08-19 14:08:16 -07:00
Ben Letham
48148fbeb5 Add discussion about needing future values 2020-08-19 13:54:24 -07:00
Ben Letham
a77adc34bb Typo fix 2020-08-19 13:41:16 -07:00
Ben Letham
dd9a6a4161 resolve R check note 2020-08-18 19:14:16 -07:00