saymrwulf/prophet
1
0
Fork 0
mirror of https://github.com/saymrwulf/prophet.git synced 2026-05-14 20:48:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

change CMDSTAN version for Apple M2 (#2497)

Browse source
This commit is contained in:
Joanne Sun 2023-10-10 03:14:24 -07:00 committed by GitHub
parent 7b062be8fa
commit 89f30fd2fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
python/prophet/models.py
View file

@ -85,7 +85,7 @@ class IStanBackend(ABC):
class CmdStanPyBackend(IStanBackend):
CMDSTAN_VERSION = "2.31.0"
CMDSTAN_VERSION = "2.33.1"
def __init__(self):
import cmdstanpy
# this must be set before super.__init__() for load_model to work on Windows

3
python/prophet/tests/test_prophet.py
View file

@ -36,7 +36,8 @@ class TestProphetFitPredictDefault:
future = forecaster.make_future_dataframe(test_days, include_history=False)
future = forecaster.predict(future)
res = rmse(future["yhat"], test["y"])
assert res == pytest.approx(expected, 0.02), "backend: {}".format(forecaster.stan_backend)
# Higher threshold due to cmdstan 2.33.1 producing numerical differences for macOS Intel (ARM is fine).
assert res == pytest.approx(expected, 0.1), "backend: {}".format(forecaster.stan_backend)
@pytest.mark.parametrize(
"scaling,expected",

2
python/setup.py
View file

@ -20,7 +20,7 @@ from wheel.bdist_wheel import bdist_wheel
MODEL_DIR = "stan"
MODEL_TARGET_DIR = os.path.join("prophet", "stan_model")
CMDSTAN_VERSION = "2.31.0"
CMDSTAN_VERSION = "2.33.1"
BINARIES_DIR = "bin"
BINARIES = ["diagnose", "print", "stanc", "stansummary"]
TBB_PARENT = "stan/lib/stan_math/lib"