Commit graph

87 commits

Author SHA1 Message Date
Daira Hopwood
a73560c842 Book: cosmetics and minor corrections / wording improvements.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 17:10:11 +00:00
Daira Hopwood
07af9ea3e7 Book: generalize input columns to expressions in lookup argument.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 17:09:10 +00:00
str4d
c10b84ce13
Merge pull request #187 from zcash/book-fixes
Book fixes
2021-02-17 06:53:10 +13:00
str4d
e1a3cc5e9e
book: Evaluation points are elements of fields, not groups
Polynomials require both addition and multiplication, which fields have, whereas a group only specifies a single operation.
2021-02-17 06:46:28 +13:00
Daira Hopwood
c769dd0fa6 Address @str4d's review comment about advice and instance columns being treated almost identically.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-15 15:08:29 +00:00
Jack Grigg
ba9917e35c book: Linkify URLs in references 2021-02-15 14:38:46 +00:00
Jack Grigg
cf68b5ba05 book: Clarify meaning of "evaluation point" in our context
Polynomial evaluation points and elliptic curve points are both things
we rely on, but never in the same context (we either use elliptic curve
points inside circuits, or implement proving systems on top of them).
2021-02-15 14:30:12 +00:00
Daira Hopwood
760d69bd2c Rename "auxiliary column" to "instance column" in the book and in code. fixes #181
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-14 21:09:49 +00:00
Jack Grigg
4739aaae5c book: Clarify IPA inputs in tl;dr section 2021-02-12 16:05:44 +00:00
Jack Grigg
126abd151c book: Clarify why fixed columns are shown separately in commitments 2021-02-12 15:30:48 +00:00
Jack Grigg
67b6d197aa book: Tweak wording for proving system stage 1 commitments 2021-02-12 15:18:12 +00:00
Jack Grigg
576796037a book: Move lookup argument design page to have consistent URI 2021-02-12 15:15:05 +00:00
Jack Grigg
7820083c0d book: Reword paragraph about degree of relation polynomials 2021-02-12 15:13:16 +00:00
Jack Grigg
3181a21cba book: Add beta and gamma requirements for lookup permutation product
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-02-12 15:08:00 +00:00
Jack Grigg
2c647009fc book: Fix notation for committing to lookup permutation product columns 2021-02-12 15:06:33 +00:00
Jack Grigg
f30cbcbfc9 book: Fix notation in example constraint system 2021-02-12 14:48:05 +00:00
str4d
0a2fb4781d
book: Small changes from review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-02-13 03:43:35 +13:00
Jack Grigg
59010c4674 book: Document commitments to lookup and equality constraint arguments 2021-02-11 21:22:18 +00:00
Jack Grigg
7b7346c462 book: Add a placeholder page for explaining the IPA
For now, it directs readers to the existing comparision page, which
describes Halo 2's IPA relative to another work.
2021-02-11 19:54:45 +00:00
Jack Grigg
6da0adb4e1 book: Refactor the multipoint opening argument section 2021-02-11 19:54:45 +00:00
Jack Grigg
91a90f1d9d book: Renumber multipoint opening challenges to match implementation 2021-02-11 19:54:39 +00:00
Jack Grigg
ffa8dacaba book: Add section about vanishing argument 2021-02-11 19:54:38 +00:00
Jack Grigg
9e9a92a912 book: Add section about circuit commitments 2021-02-11 19:54:20 +00:00
Jack Grigg
e666f8b966 book: Add summary and succinct description of the Halo 2 protocol 2021-02-11 19:16:08 +00:00
Jack Grigg
4aceada21a book: Re-order "Proving system" sub-sections 2021-02-10 13:06:22 +00:00
Jack Grigg
425c45d96b book: Add a simple example showing how the API is used 2021-02-08 15:56:16 +00:00
Jack Grigg
bfbfa80900 book: Add a comparison to BCMS20 2021-02-04 16:04:37 +00:00
Daira Hopwood
20f33f427f Further clarify notation and make sure that the discussion is correct for non-cyclic groups.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-01-30 16:16:22 +00:00
Daira Hopwood
fc0bddad8a
Merge pull request #158 from daira/background-update
Improvements to background section
2021-01-30 03:25:24 +00:00
Daira Hopwood
13f406acc1
Fix link 2021-01-30 03:24:35 +00:00
Daira Hopwood
7a5915ab09
Apply some suggestions from code review
Co-authored-by: str4d <thestr4d@gmail.com>
2021-01-30 02:49:40 +00:00
Daira Hopwood
cda768aa00 Improvements to background section:
* describe groups in general, rather than via the example of F_p^*
* explain the isomorphism between group elements and scalars, and how it is useful
* corrections and pedantry :-)

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-01-30 01:43:24 +00:00
Jack Grigg
d84a4cbbfc book: Add a link from "Background Material" to the issue tracker
This will hopefully encourage readers to submit feedback as they read
the book, enabling us to catch things that could be explained better.
2021-01-29 20:59:39 +00:00
Daira Hopwood
723ea8feac Clarifications for background, from pairing with Kris.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-01-29 19:51:48 +00:00
Daira Hopwood
847c41d5c8 Make terminology more consistent with the ZKProof reference and Sean's usage.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-01-16 15:48:43 +00:00
Daira Hopwood
0caf66b261 [Book] Fix W numbering in SHA-256 table16 doc.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-01-12 21:50:24 +00:00
Jack Grigg
afdb4a8981 book: Add design notes about implementation of proofs
Adapted from https://github.com/zcash/halo2/pull/111
2021-01-11 21:21:05 +00:00
Jack Grigg
fb411b12e8 book: Reorganize design subsections 2021-01-11 21:07:45 +00:00
Jack Grigg
f8c5c2e28e book: Add background material
Co-authored-by: Sean Bowe <ewillbefull@gmail.com>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: ying tong <yingtong@z.cash>
2021-01-11 20:44:53 +00:00
therealyingtong
d23fcd1ccd [book] SHA-256: add compression digest gate 2021-01-11 23:56:23 +08:00
therealyingtong
34defb4577 Remove unnecessary spreads for a_new, e_new 2021-01-11 00:49:37 +08:00
therealyingtong
c920bdf9a6 Split choice table into two tables 2021-01-11 00:22:07 +08:00
therealyingtong
42988ce1d0 [book] sha256: Simplify compression region to reuse message schedule gates 2021-01-09 01:29:16 +08:00
therealyingtong
68166c27ac Remove superfluous selector columns 2021-01-08 00:24:21 +08:00
therealyingtong
1a3fccd71b [book] Fix compression table formatting 2021-01-06 20:41:13 +08:00
therealyingtong
38c78b8c50 [book] Add compression region to table16.md 2021-01-06 20:30:28 +08:00
therealyingtong
29738d4214 Add sb1 selector 2020-12-28 22:57:50 +08:00
therealyingtong
50e6920ed7 Standardise notation and add sb column to check subpieces 2020-12-28 14:57:33 +08:00
Daira Hopwood
e932352390 Rename 'Background' to 'Proof systems' and add a note about intermediate values.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-12-26 15:45:15 +00:00
Daira Hopwood
fcb176aeb1 Apply suggestions from code review
Minor fixes.
2020-12-26 15:33:59 +00:00