Commit graph

545 commits

Author SHA1 Message Date
Daira Hopwood
4d61ad8ff5 Need a borrow here.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-18 23:50:19 +00:00
ebfull
fb6111df5b
Merge pull request #176 from zcash/general-lookup
Generalise lookup argument to work over expressions
2021-02-18 16:32:48 -07:00
Sean Bowe
0316019a94
Add test for polynomial rotation in Lagrange form. 2021-02-18 16:25:00 -07:00
Sean Bowe
81af4e43d1
Update pinned verification key to account for circuit changes 2021-02-18 15:48:20 -07:00
therealyingtong
d29246b49b
Rename const_* -> constant_* 2021-02-18 15:41:36 -07:00
therealyingtong
4bf46fc349
Add Expression::Const variant 2021-02-18 15:41:36 -07:00
therealyingtong
6a7f869f66
Clippy fixes 2021-02-18 15:41:36 -07:00
therealyingtong
df2d818891
Account for Rotations of LagrangeCoeff values 2021-02-18 15:41:36 -07:00
therealyingtong
8e56b415fb
Rename column -> expression for lookups 2021-02-18 15:41:36 -07:00
therealyingtong
2f2de13887
Calculate required degree of lookup 2021-02-18 15:41:36 -07:00
therealyingtong
aca6de61f8
Evaluate Expressions and all variants
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-02-18 15:41:36 -07:00
therealyingtong
d8534e1c50
Pass Expressions to meta.lookup() 2021-02-18 15:41:35 -07:00
ebfull
9401ceb68d
Merge pull request #173 from zcash/vk-transcript
Hash verification key into transcript
2021-02-18 13:28:57 -07:00
str4d
1e73f97a24
Merge pull request #197 from zcash/bump-deps
Bump dependencies
2021-02-19 09:20:35 +13:00
Sean Bowe
5e20b0f2a7
Automatically derive PinnedVerificationKey's Debug impl. 2021-02-18 07:51:41 -07:00
Sean Bowe
7fcd302d2d
cargo fmt 2021-02-17 15:40:41 -07:00
Sean Bowe
8060a12ea4
Fix minor nit (match ergonomics) 2021-02-17 15:39:46 -07:00
Sean Bowe
2b1c319ba0
Use pretty-printing in test of verification key pinning. 2021-02-17 15:38:43 -07:00
Sean Bowe
2fe4e0d900
Change personalization of BLAKE2b used in hash_into. 2021-02-17 15:20:19 -07:00
Sean Bowe
87536cea10
Use newtypes to simplify Debug implementations for pinning verification keys. 2021-02-17 15:20:19 -07:00
Sean Bowe
2076701fc3
cargo fmt 2021-02-17 15:19:34 -07:00
Sean Bowe
34a5bfd4b1
Remove unused TryInto import. 2021-02-17 15:19:34 -07:00
Sean Bowe
6226426be0
Restore whitespace 2021-02-17 15:19:34 -07:00
ebfull
bc9d05e67b
Apply suggestions from code review
Co-authored-by: str4d <jack@electriccoin.co>
2021-02-17 15:19:34 -07:00
Sean Bowe
98f5b17359
Remove unused import 2021-02-17 15:19:34 -07:00
Sean Bowe
ea563434f4
Remove hash_into from Rotation. 2021-02-17 15:19:34 -07:00
Sean Bowe
dfa7d96fa9
Refactor verification key hashing logic to use Display impls. 2021-02-17 15:19:34 -07:00
therealyingtong
f35e190455
Hash in field modulus, curve parameters 2021-02-17 15:19:34 -07:00
therealyingtong
52c028b4da
Disambiguate naming of hash() -> hash_into() 2021-02-17 15:19:34 -07:00
therealyingtong
e7d6f67564
Rename aux -> instance after rebasing 2021-02-17 15:19:34 -07:00
therealyingtong
b204ff74a8
Do not return hash results from component hash() methods 2021-02-17 15:19:34 -07:00
therealyingtong
4aa4b4463a
Hash domain and cs into transcript 2021-02-17 15:19:34 -07:00
therealyingtong
437782e902
Hash fixed_commitments and permutations into transcript 2021-02-17 15:19:33 -07:00
Jack Grigg
776016fe53 crossbeam-utils 0.8 2021-02-17 20:43:36 +00:00
Jack Grigg
0c4f779993 ff 0.9 2021-02-17 20:42:27 +00:00
Jack Grigg
2c77eccf01 metrics 0.14.2 2021-02-17 20:40:12 +00:00
ebfull
068babe3d0
Merge pull request #193 from zcash/any-permutation
Allow permutations to be over all column types
2021-02-17 09:06:27 -07:00
ebfull
b299542eea
Merge pull request #174 from zcash/ecc-gadget
Add gadgets for elliptic curve operations
2021-02-17 08:54:02 -07:00
therealyingtong
a19dc68dee Use Column<Any> in Permutation::Argument 2021-02-17 21:32:17 +08:00
Jack Grigg
bea5f7f418 Add gadgets for elliptic curve operations 2021-02-17 00:49:22 +00:00
ebfull
0a3933b76a
Merge pull request #166 from zcash/sha-256-gadget
SHA-256 gadget
2021-02-16 12:09:11 -07:00
str4d
c10b84ce13
Merge pull request #187 from zcash/book-fixes
Book fixes
2021-02-17 06:53:10 +13:00
str4d
e1a3cc5e9e
book: Evaluation points are elements of fields, not groups
Polynomials require both addition and multiplication, which fields have, whereas a group only specifies a single operation.
2021-02-17 06:46:28 +13:00
Jack Grigg
4c5a00b767 SHA-256 gadgets and chip traits 2021-02-15 16:35:58 +00:00
ebfull
89b007336a
Merge pull request #188 from zcash/clippy-beta
CI updates
2021-02-15 09:07:37 -07:00
Daira Hopwood
22297bbc89
Merge pull request #185 from daira/aux-to-instance
Rename "auxiliary column" to "instance column" in the book and in code
2021-02-15 15:42:54 +00:00
Jack Grigg
7d81971079 CI: Warn with clippy on beta instead of nightly
We don't want the noise of changes to nightly clippy, but we _do_ want
advance warning of upcoming CI breakage. Running clippy on beta will
give us six weeks notice.
2021-02-15 15:41:35 +00:00
Jack Grigg
fb9eb3b483 CI: Run intra-doc checks on stable 2021-02-15 15:39:16 +00:00
ebfull
356ce36c71
Merge pull request #184 from zcash/fix-clippy
Disable clippy::upper_case_acronyms lint
2021-02-15 08:19:42 -07:00
Daira Hopwood
c769dd0fa6 Address @str4d's review comment about advice and instance columns being treated almost identically.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-15 15:08:29 +00:00