saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-05-15 20:50:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
onnxruntime/docs/How_To_Update_ONNX_Dev_Notes.md
Gary Miguel e8b0d24071
Support per-test tolerances for ONNX tests (#11775) 
Prior to this every test shared the same tolerances. This meant
that if an ONNX test failed due to a small but acceptable difference in
output, the only alternative was to disable the test entirely.

In op set 17, the DFT operator is being added. Without this change, the
tests for that operator fail because the output is off by about 5e-5.
It's better to keep test coverage for this new op rather than disable
the test entirely.

Also prior to this change, the global tolerances were not shared between
C++, JavaScript, and Python tests. Now they are.

Also fix various minor issues raised by linters.

Unblocks https://github.com/microsoft/onnxruntime/issues/11640.
2022-06-14 15:12:23 -07:00

2.6 KiB
Raw Blame History

How to update ONNX

This note is only for ONNX Runtime developers.

If you need to update the ONNX submodule to a different version, follow the steps below.

  1. Update the ONNX submodule
cd cmake/external/onnx
git remote update
git reset --hard <commit_id>
cd ..
git add onnx

(Change the <commit_id> to yours. If you are not sure, use 'origin/master'. Like 'git reset --hard origin/master')

  1. Update cgmanifests/generated/cgmanifest.json. This file should be generated. See cgmanifests/README for instructions.

  2. Update tools/ci_build/github/linux/docker/scripts/requirements.txt and tools/ci_build/github/linux/docker/scripts/manylinux/requirements.txt. Update the commit hash for git+http://github.com/onnx/onnx.git@targetonnxcommithash#egg=onnx.

  3. If there is any change to cmake/external/onnx/onnx/*.in.proto, you need to regenerate OnnxMl.cs. Building onnxruntime with Nuget will do this.

  4. If you are updating ONNX from a released tag to a new commit, please ask Changming (@snnn) to deploy the new test data along with other test models to our CI build machines. This is to ensure that our tests cover every ONNX opset.

  5. Send you PR, and manually queue a build for every packaging pipeline for your branch.

  6. If there is a build failure in stage "Check out of dated documents" in WebAssembly CI pipeline, update ONNX Runtime Web WebGL operator support document:

    • Make sure Node.js is installed (see Prerequisites for instructions).
    • Follow step 1 in js/Build to install dependencies).
    • Follow instructions in Generate document to update document. Commit changes applied to file docs/operators.md.

  7. Usually some newly introduced tests will fail. Then you may need to update