Commit graph

2073 commits

Author SHA1 Message Date
edgchen1
cffdff6702
Publish unit test results from Linux and Mac builds (#3480)
* Added publish test results step to Linux and Mac builds.

* Fix test result file pattern.
2020-04-10 14:51:56 -07:00
Tixxx
f5ba9c922d
fix internal loss scale (#3483)
* Changed internal loss scale to 1-D

* added test

Co-authored-by: root <root@525204a066204ea794f942530b05ae7f000000.axlncovkyjne5caro2tmz3zryb.xx.internal.cloudapp.net>
2020-04-10 14:13:48 -07:00
edgchen1
20c7dd9f5c
Remove orttraining/docker directory. (#3476)
The docker images are not publicly available yet.
Addressing PR comment: https://github.com/microsoft/onnxruntime/pull/3174#discussion_r390761308
2020-04-10 09:41:22 -07:00
Vincent Wang
03996c7c08
Fixes for Where, ConcatGrad and ReduceSumGrad (#3415)
* Fixes for Expand, Where, ConcatGrad ReduceSumGrad.

* Roll back expand, fix, add tests for reduce grad.

* Roll back CPU Expand change.

* Fix after merge.

Co-authored-by: Vincent Wang <weicwang@microsoft.com>
2020-04-10 19:35:32 +08:00
liqunfu
e7297e6c9d
create pipeline for ci frontend tests (#3422)
create pipeline for nightly python front-end e2e tests
2020-04-09 15:31:22 -07:00
ytaous
a08f16471a
Address comments around bfc arena (#3460)
* rename setting

* todo comments

* fix build

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-04-08 19:35:32 -07:00
liqunfu
a298556600
raid rtol to unblock CI (#3457)
raise rtol to avoid expected CI test failure in onnxruntime_test_ort_trainer.py
2020-04-08 17:17:44 -07:00
ytaous
f73008483a
safeint for region bytes in bfc arena and code clean up (#3447)
* PR comments

* remove build issue workaround

* SafeInt for region bytes

* fix build

* fix build

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-04-08 13:54:42 -07:00
liqunfu
1ddfe1249b
frontend test to use random seed (#3209)
frontend test to use random seed
2020-04-08 10:03:07 -07:00
ytaous
b35468289a
View Op - new unit tests and add support for tensor memcpy by offset/size (#3439)
* view ops UTs

* update per comments

* PR comments - code clean up

* code clean up per comments

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-04-07 13:07:11 -07:00
Thiago Crepaldi
15e32b44fd
Merge pull request #3383
Merge from master into ort_training
2020-04-06 19:05:01 -07:00
Edward Chen
95707d22a5 Disable gradient clipping for E2E test. 2020-04-06 23:07:28 +00:00
Sherlock
a3ab2ba036
Reapply commit 131c65d; Fix memory regression issue. (#3423)
* Reapply commit 131c65d

* fix merge error
2020-04-06 10:29:31 -07:00
edgchen1
82c1e1b3db
Enable loss scale input from Python frontend (#3327)
Made some fixes to enable loss scale to be wired up to ORT from the Python frontend. In particular, now addition of loss scaling is done unconditionally if mixed precision is enabled. The generated loss scale input name is passed back to the frontend.

Also fixed how inputs were added during the training graph configuration. Graph::SetInputs() was causing some issues - it seems to not be working correctly.

Also added some mixed precision Python frontend tests.

Co-authored-by: liqun <liqun@OrtTrainingDev4.af05slrtruoetgaxwwjv5nsq5e.px.internal.cloudapp.net>
2020-04-03 16:02:14 -07:00
Sherlock
f437665360
Revert "Addressing PR comments (#3334)" (#3412)
This reverts commit 131c65d23d.
2020-04-03 11:59:47 -07:00
Thiago Crepaldi
d89e5d91a6 Disable GradientCheckerTest tests for GPU/Debug build (#3407) 2020-04-03 01:01:58 +00:00
Thiago Crepaldi
675035b1a8
Disable GradientCheckerTest tests for GPU/Debug build (#3407) 2020-04-02 18:00:54 -07:00
Thiago Crepaldi
e2afe5e054 Revert Session and InferenceSession implementation 2020-04-02 11:47:44 -07:00
Thiago Crepaldi
0b1e3f1e10 Revert _SliceKernel cuda implementation 2020-04-01 14:28:17 -07:00
Thiago Crepaldi
28ff88ce52 Disable tests (temporary) 2020-04-01 14:28:07 -07:00
ytaous
2ce90cff4c
PR comments (#3374)
* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-04-01 10:36:16 -07:00
Sherlock
614eb438ae
Update Op's Domain and Version (#3356)
* Update Nccl ops domain opset

* Update ZeroGradient Domain OpSet

* Update InPlaceAccumulator Domain OpSet

* Update SoftmaxGrad Domain and OpSet

* Update LayerNormalizationGrad Domain and OpSet

* Update BatchNormGrad Domain and Opset

* Update IsAllFinite Domain and Opset

* Update DivGrad Domain and Opset

* Update GatherGrad Domain and Opset

* Update IsFinite Domain and OpSet

* Update ReduceAllL2 Domain and Opset

* Update MixedPrecisionScale Doman and Opset

* Update AllOp Domain and Opset

* Update GroupOp Domain and OpSet

* Update ViewOp Domain and OpSet
2020-04-01 10:10:38 -07:00
Thiago Crepaldi
6d769d47c4 Fix InferenceSession API 2020-03-31 20:10:06 -07:00
Xueyun Zhu
efc8bd738f
add pipeline graph split script (#3275)
* pipeline graph cut

* add element type

* add input wait event and shape info

* shape inference

* support multiple cuts

* format script

* address feedback

* address feedback
2020-03-31 19:30:18 -07:00
Thiago Crepaldi
83c3da3fc0 Fix code-base after breaking API changes 2020-03-31 17:59:20 -07:00
Thiago Crepaldi
759818f2c1 Merge remote-tracking branch 'origin/master' into thiagofc/ort_training_merge_from_master 2020-03-31 10:53:22 -07:00
Scott McKay
ace741680d
Constant-12 support (#3304)
1. Support the new fields for Constant in opset 12
2. Support SparseTensor in the Constant node by converting to dense tensor when lifting the Constant to an initializer. Will make a model with a sparse tensor in a Constant work but isn't an overly efficient approach.
2020-03-30 23:13:52 -07:00
stevenlix
2332a93db0
Update onnx-tensorrt parser (#3369)
* sync onnx-tensorrt parser and update TensorRT doc

* remove --msvc_toolset 14.16 in tensorrt ci pipeline
2020-03-30 20:31:59 -07:00
Jan Scholz
ce9acf0c21
iOS crosscompilation under linux (#3298)
* added support for ios crosscompilation under linux

* reverted cmake generator change

* if --ios is added protoc can be compiled for host system

* accidently reverted change to compile protoc for host system for ios if protoc exe is not set

* wdata is now used

* accidentally pasted CMAKE_OSX_ARCHITECTURES into CmakeLists.txt, also made bad merge on build.py previously

* removed print

* fixed typeo, deleted commented statements for earlier debugging

* reverted accidental delete

* added asmmacro.h for aarch64 asm
now MlasSgemmKernel**** gets underscore added if needed
no need anymote to differentiate between iOS arm64 and normal amr64 build
onnxruntime.cmake: added check if iOSCross is set to properly set RPATH

* removed 2 spaces

* fix: logcial error fixed, now protoc gets compiled if not supplied with --path_to_protoc_exe

* removed unecessarily added spaces

* removed some more spaces
2020-03-30 19:39:17 -07:00
edgchen1
fb2f97a002
Address master merge PR comments (#3348)
Address some comments from https://github.com/microsoft/onnxruntime/pull/3174.

- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r396855459
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r396855630
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r396857140
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r398094858
- https://github.com/microsoft/onnxruntime/pull/3174#issuecomment-599024924
2020-03-30 18:52:48 -07:00
Yufeng Li
af618278f6
fix bugs in quantization and calibration tools (#3329)
Fix 3 bugs:
node names duplicate in calibration augment_graph if the name of node to quantize is empty.
If output nodes are quantized, output value are quantized and not dequantized back
Gather with data type int64 should not be quantized
2020-03-30 17:50:25 -07:00
Maxim Kalinin
f2ca2b2981
Avoid "infinite" loop in optimizer (#3321)
* Avoid "infinite" loop in optimizer

When symbolic dimensions are present and can be overridden,
FreeDimensionOverrideTransformer always sets modified flag to true. As a
consequence, the optimizer loops until the iteration limit is reached.
2020-03-31 08:37:00 +10:00
Changming Sun
06fc9506fd
Thread pool changes (#3153)
1. Copy tensorflow's thread pool class to ORT, so that we can get a better implementation of thread pool based parallelfor
2. Copy Eigen's thread pool class to ORT
3. Support thread affinity
4. Remove RNN kernel’s private thread pool
5. Modify pool kernels to use the thread pool when openmp is disabled.
2020-03-30 12:18:40 -07:00
Yulong Wang
0494036006
fix tensor location mismatch in allocation planner (#3249) 2020-03-30 11:20:43 -07:00
Cassie
2b10e625f9
added public value varibale to NamedOnnxValue (#3347)
Co-authored-by: cassieview <cassie.siljander@microsoft.com>
2020-03-30 10:45:39 -07:00
George Wu
355f39ddee
fix cuda build for cmake >= 3.17.0 (#3362) 2020-03-30 00:38:57 -07:00
ytaous
d8f0a0f223
Address PR comments (#3352)
* PR comments

* revert code for a couple comments

* add negative test case

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-29 12:34:54 -07:00
Weixing Zhang
1bbc421884
Don't cast to fp16 in LayernormGrad (#3328)
Co-authored-by: Weixing Zhang <wezhan@microsoft.com>
2020-03-28 19:07:32 -07:00
Yang Chen
33b5010e62
skip optional inputs for scan subgraphs (#3349)
* skip optional inputs for scan subgraphs

We may have cases where the subgraph has optionial inputs that appear
in both subgraph's input and initializer, but not in the node's input.
In such cases, the input model might be invalid, but let's not choke
on it. Instead, let's issue a warning, skip the optional inputs,
and keep going forward.

* address CR feedback
2020-03-28 16:15:45 -07:00
Sherlock
ffb2a3359e
Implement WhereGrad (#3343) 2020-03-27 19:10:40 -07:00
Tiago Koji Castro Shibata
c3cea486d0
Port ConcurrencyTests from TAEF (#3086)
* Add ConcurrencyTests

* Make ConcurrencyTests compatible with TAEF

* Use test PCH in concurrency tests

* Fix include header

* Ignore unused code warnings on WINML_SKIP_TEST

* Remove BOM

* Remove conflicting namespace in older SDK

* Refactor duplicate code

* Fix unused DELAYLOAD

* Fix unused DELAYLOAD

* Remove link to internal bug

* Address code style fixes

* Add new concurrency tests
2020-03-27 17:39:22 -07:00
Tixxx
49e6043d07
support Huggingface's adamw (#3318)
* add weight decay mode to support both pytorch and huggingface's adamw
2020-03-27 08:04:27 -07:00
Yang Chen
5278f73202
Fixed two issues in symbolic_shape_infer script (#3332)
* Fixed two issues in symbolic_shape_infer script

This change addressed #3293

There were two issues in the script:

* We need to handle a special case for infer_Reshape, where input_shape
is empty and target shape_value is [-1]. In such case, we need to
get sympy data for the output dim (or create one if it doesn't exist).

* We need to update computed dims for newly-created shape for Range op

* also call _update_computed_dims for _infer_Expand

addressed CR feedback

* added ai.onnx into opset list

* instead of manipulating _infer_Reshape, call _update_computed_dims
from _infer_Expand to update newly-computed dims
2020-03-26 23:27:37 -07:00
Xiang Zhang
810a10b230
Enable Onnxruntime Telemetry by Default for 1.3 (#3338) 2020-03-26 20:57:39 -07:00
ytaous
131c65d23d
Addressing PR comments (#3334)
* PR comments

* PR comments

* PR comments

* error out bad shape

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-03-26 18:43:30 -07:00
Faith Xu
2e875f4e67
Delete outdated page (#3320) 2020-03-26 18:24:02 -07:00
Pranav Sharma
497e83eda5
Minor update to the issue template. Add a line to attach model where applicable. (#3339) 2020-03-26 14:28:27 -07:00
Xueyun Zhu
0a6ec0df56
Merge pull request #3285 from microsoft/xuzhu/merge_from_master
Merge from master to ort_training
2020-03-26 12:10:13 -07:00
Sherlock
d143b41b81
Expose frozen_weights in PyTorch Frontend (#3317) 2020-03-26 11:26:54 -07:00
Hector Li
0e81962e98
correct the cmake version to 3.13 for Arm build (#3333) 2020-03-26 10:20:18 -07:00