Commit graph

10340 commits

Author SHA1 Message Date
bunnie
1c1e03e036 Merge branch 'bunnie-dev' into i18n-jp 2022-01-28 16:28:25 +08:00
bunnie
f7ea782e73 fix some ergonomics around the status bar 2022-01-28 16:28:06 +08:00
bunnie
25bccd9446 THE BALDEST YAK: keyboard injection now working
I wrote in a commit yesterday how there was no ROI on doing this
yet somehow I kept on doing it. I blame poor impulse control.

Turns out there was a series of race conditions and bugs that
caused this thing to "mostly work" on the first go at it but
really hard to debug and get very right.

1. Litex UART has a weird undocumented API. You advance the Rx
FIFO by writing `1` to the PENDING bit, and no other way. However,
you determine if there are any more characters to receive by
reading the EMPTY bit and seeing if it is 1. The previous method
wrote `1` to the PENDING bit and then used the PENDING bit to
see if a character was available, under the theory that the
PENDING bit would be set again if there was still a character.
This is somewhat true, except that the PENDING bit is set only
some amount of time later which is about comparable to a few
CPU instructions, so if you had a fast loop path the PENDING
bit would show as cleared and you'd exit, which would cause
no further interrupts to fire because the interrupt was
effecitvely not acknowledged.

This isn't written up anywhere but I figured this out by
just reading the source code for Litex UART and BIOS:
e8be391504/litex/soc/cores/uart.py (L264-L279)
ccd3ab17be/litex/soc/software/libbase/uart.c (L38-L44)

2. I had the Key Injector IP block in the `sys` domain, which
would have its clock cut when the CPU went to sleep, which would
cause input characters to disappear when the CPU went into power
saving. moving this to "always on" domain fixes that.

3. I had the UART PHY in the always on block (so you could
send or receive exactly one character), but not the
separate UART block (which contained the FIFOs).
The UART block would also go into power
savings, and this would cause FIFO entries to go missing.

4. Escape sequences get sent as a burst of characters. The Key Injector
originally did not have a FIFO of its own, so it would only
remember the *last* key of the sequence that was written, causing
some keys to be dropped occassionally. Adding a 16-deep FIFO
to the injector fixes this.

5. The code I had to read out the injector's results was designed with
the "strobe" bit (to indicate that the FIFO had characters) in the
same regsiter as the character itself. Thus the loop that 1. checked
if the fifo was empty then 2. read and forwarded the character
would actually perform two reads from the FIFO. However, this "mostly worked"
I think because the FIFO retains the last value that was written
even when it was empty, so if only one character was read at a time
everything was fine. It only didn't work when you stuffed two characters
in there, as you'd drop the first one. Reading the FIFO once and
then interpreting the code with a bitmask fixes this.

6. The escape sequences, in their full glory with no dropped characters,
required a refactored parsing routine, which I have now added.

7. backspace->delete mappings, the bane of computer engineers since 1960.

OK. very bald yak. Here I lay down the shears next to several
mooshi pillows stuffed with the finest Yak hair.
2022-01-28 15:17:47 +08:00
bunnie
760bfab550 Revert "random jp chars including composed chars, for test"
This reverts commit 9a6b17cd49.
2022-01-28 14:03:27 +08:00
bunnie
fdf0e0e41a Revert "random jp chars including composed chars, for test"
This reverts commit 9a6b17cd49.
2022-01-28 14:02:14 +08:00
bunnie
77d0c00d7e
Merge pull request #94 from rowr111/i18n-jp
random jp chars including composed chars, for test
2022-01-28 13:48:51 +08:00
Jeanie
9a6b17cd49 random jp chars including composed chars, for test 2022-01-28 14:25:36 +09:00
bunnie
ea31f54a79 console escape codes working better
just couldn't let it go. figured out the issue is a race condition
in how the Litex UARTs are constructed...I don't know how Litex
normally handles this kind of situation but they have this funky
construction where reading the fifo doesn't advance it, you have
to...clear the pending bit. I think it was meant to be a "clever"
thing that saves an instruction or something like that since you
always have to clear the pending bit.

Anyways, the previous incarnation of this loop checked to see
if the pending bit was set again and if it was it'd run back
and fetch another character. This turns out to be a bad idea
because the pending bit goes through a multireg and other stuff
before it's readable which means it has a lot of delay on it.
This leads to a race condition.

This version actually checks if the fifo is empty and if it isn't,
it reads the character *and* pumps the pending bit (because
the FIFO doesn't auto-advance when you read it, you have to clear
the pending bit).

This works a lot better, but it's not at all well documented how
this works and it's very hard to tell from reading the source code
because it's written using really fancy migen abstractions that
are also poorly documented and have a lot of cursed constructions.

Anyways. At least the console doesn't die now when you type
a control character, *but* you do have the problem that the
escape codes get mis-interpreted sometimes. If it really really
becomes important later on to fix that it would involve tracing
out the sequence of keys that arrive at InjectKey and figuring
out if things are coming out of order or what is triggering the
bad escape codes.
2022-01-28 04:21:40 +08:00
bunnie
9cfffb18e9 some minor fixes to the console debug system to make it more consistent
there is still some mysterious problem involving a race condition
of the raw hardware console UART Rx path deciding it doesn't want
to report new characters anymore to the interrupt handler that
is triggered when multi-byte sequences are shoved down the
pipe. So long as you're typing simple commands it's fine, but
escape sequences tend to lock things up. I don't think there's
enough ROI to continue investigating this facility.
2022-01-28 03:36:14 +08:00
bunnie
5a1139a367 move cache flush on susres to just before the suspend event
- also nail down the interrupt handlers from firing from the COM
during suspend
- ensure that connects don't happen while scanning
2022-01-27 22:05:38 +08:00
bunnie
5daf4c4723 suppress connection manager polling when the pddb is not mounted
no point in trying to connect to APs when we have no AP list or keys.
2022-01-27 15:01:19 +08:00
bunnie
a94bb0e4d7 prevent interrupt storm on sleep from the COM 2022-01-27 15:01:01 +08:00
bunnie
5ef7126ede add better handling for wfx HIF err condition 2022-01-27 14:02:28 +08:00
bunnie
3f2f304202 refactor connection manager to be more responsive to suspend/resume 2022-01-27 13:46:43 +08:00
bunnie
71c017641a fix up some debug messages and other minor nits 2022-01-27 04:07:22 +08:00
bunnie
4c4ca1577f fix connection manager state machine
seems to work a lot better, but needs a lot more testing
2022-01-27 03:56:39 +08:00
bunnie
44dc56feb6 Merge remote-tracking branch 'origin/main' into bunnie-dev 2022-01-26 14:31:47 +08:00
Sean Cross
4a44d8d32d emulation: csproj: update targetframework to 2.1
The targetframework tag is now 2.1, in accordance with the upstream C#
code from Microsoft.

Signed-off-by: Sean Cross <sean@xobs.io>
2022-01-26 12:51:19 +08:00
Sean Cross
96d241acfd emulation: memlcd: reduce dirty bit count to 2 bytes
Previously, the memlcd had 22 bytes of dirty bits following a line. This
was reduced to 2 bytes, but the logic checking the dirty bytes had not
been updated.

Reduce the dirty byte count to 2 bytes.

Signed-off-by: Sean Cross <sean@xobs.io>
2022-01-26 12:48:04 +08:00
bunnie
2db96e17b0 modify minifb integration to use host keymaps for most printable characters
this allows e.g. dvorak key maps to work while still picking up
all of the special keys that don't correspond to to any unicode
characters
2022-01-25 23:03:57 +08:00
bunnie
2909115e3d move mini-fb's home into the betrusted-io repo
this will let more people maintain it while @xobs moves to merge
his contributions into the mainline...
2022-01-25 22:51:45 +08:00
bunnie
11f726223b update to @gsora's patch to improve hosted mode performance
We run a branch of minifb because we need the `set_key_state`
function, which is not available on the main branch. This
function is necessary to extract raw scan keycodes from the
keyboard so we can respond to e.g. menu and prediction emulation
keys (Home and Fn keys). The mainline minifb crate eats all
of those key events and does not pass them on.
2022-01-25 22:36:38 +08:00
bunnie
40dcd28b23 move the devboot line 2022-01-25 18:22:02 +08:00
bunnie
a4d84ae290 clean up cosmetic bits on uptime rendering 2022-01-25 17:09:03 +08:00
bunnie
1d27265d02 fix comma formatting in pddb lists to not put a trailing comma 2022-01-25 16:58:22 +08:00
bunnie
18b97cea83 fix battstats decimal places on wattage 2022-01-25 16:48:44 +08:00
bunnie
226281c138 clean up commented out things 2022-01-25 16:39:45 +08:00
bunnie
e55154be69 add version info for ~~xous~~ to the shellchat command
this took...way too long to figure out. Latest versions
of `vergen` for whatever reason seem totally broken for
my build hosts.
2022-01-25 16:37:50 +08:00
bunnie
077a286b42 add some pddb diagnostics shell commands 2022-01-25 15:56:06 +08:00
bunnie
75d41cfb1a fiddling with icons 2022-01-25 15:17:55 +08:00
bunnie
dc2877457e add menu wrap-around
makes nav a bit faster on deep menus
2022-01-25 15:12:33 +08:00
bunnie
65bd1d416a improve the iconography of the status bar 2022-01-25 15:02:25 +08:00
bunnie
4dbff88015 add a little more flavor to the readme file 2022-01-25 03:24:52 +08:00
bunnie
d1563aa0ab add docs and screenshots 2022-01-25 03:11:50 +08:00
bunnie
b5faa1eb55 minor tweaks to the repl demo 2022-01-25 02:31:54 +08:00
bunnie
1449f7cb7f ignore the locales build directory 2022-01-25 02:04:45 +08:00
bunnie
50064895f0 add the locales Cargo.lock file 2022-01-25 02:04:12 +08:00
bunnie
fcb27919d4 change name of the repl demo command to be more general 2022-01-25 02:03:38 +08:00
bunnie
617fc3b8f6 bug fixes in the REPL demo 2022-01-25 01:57:16 +08:00
bunnie
0557caf9be fix livelock problem in app context switching
the re-regsitration is a "send" not a "lend" now, because
the imef can't block during the context switch.

Not sure why I made it a lend in the first place, probably just
wasn't thinking...
2022-01-25 01:55:49 +08:00
bunnie
0f4743fc0b only one connection is allowed to the imef: remove multi-callback support
only cone connection is allowed to the IMEF anyways, because
the GAM does traffic control on who has authorization to access it.
So, no need for multi-callback support. Saves a tiny bit of RAM.
2022-01-25 01:05:31 +08:00
bunnie
02b2e4a6e7 deprecate request_focus api and make initial focus setting within the GAM
request_focus is "dangerous" because any random server could
request a UX context to pop up. There is a checked version
that requires a GAM token that should be used, but, this leaves
the question of how does the initial app that's supposed to be
focused gets set.

A small mod to the UxRegistration call is made to check for
the name of the default focus app, and when it is seen, a thread
is fired off to request focus for that app. That allows us
to deprecate this otherwise dangerous call.
2022-01-25 00:55:14 +08:00
bunnie
583c2e172b add a demo REPL app to help users get started with something more interactive 2022-01-24 19:06:58 +08:00
bunnie
a52f498edb change the menu order to make apps a bit easier to access 2022-01-24 17:38:02 +08:00
bunnie
7193f7003e some tweaks to improve the UX rendering quality 2022-01-24 17:07:45 +08:00
bunnie
8e13d6bcdf add drawlists to the GAM and gfx abstractions
this helps to prevent race conditions and improves performance
2022-01-24 16:33:01 +08:00
bunnie
6089672960 add localization to the demo app 2022-01-24 04:42:35 +08:00
bunnie
35fd307dbf major refactoring around how initializations are done for canvases
trust levels now default to a mid-level, with the password
modals explicitly tested for by the Context logic (the idea
being to deny any untrusted canvases the ability to render
inverted text).

ball bounce app also basically works, and context
switching between the bounce app and the main menu
is working too.
2022-01-24 01:58:48 +08:00
bunnie
0fadaf3546 trust level is stored on a per-canvas basis, removing duplicate record 2022-01-23 18:34:17 +08:00
bunnie
7addcf5f72 update a comment 2022-01-23 18:26:34 +08:00