From f53f86077d851452fb158e49fb7aa1a84580b18f Mon Sep 17 00:00:00 2001 From: bunnie Date: Wed, 12 Jan 2022 02:33:09 +0800 Subject: [PATCH] add a blank check step before issuing a sector erase this should significantly speed up the initial on-boarding for first-time users --- services/pddb/src/backend/hw.rs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/services/pddb/src/backend/hw.rs b/services/pddb/src/backend/hw.rs index 6879151b0..f0ed8250f 100644 --- a/services/pddb/src/backend/hw.rs +++ b/services/pddb/src/backend/hw.rs @@ -1238,7 +1238,18 @@ impl PddbOs { modals.update_progress(offset as u32).expect("couldn't update progress bar"); } } - self.spinor.bulk_erase(offset, SPINOR_BULK_ERASE_SIZE).expect("couldn't erase memory"); + // do a blank check first to see if the sector really needs erasing + let mut blank = true; + let slice_start = (offset - xous::PDDB_LOC) as usize / size_of::(); + for word in self.pddb_mr.as_slice::()[slice_start..slice_start + SPINOR_BULK_ERASE_SIZE as usize / size_of::()].iter() { + if *word != 0xFFFF_FFFF { + blank = false; + break; + } + } + if !blank { + self.spinor.bulk_erase(offset, SPINOR_BULK_ERASE_SIZE).expect("couldn't erase memory"); + } } if let Some(modals) = progress { modals.update_progress(xous::PDDB_LOC + PDDB_A_LEN as u32).expect("couldn't update progress bar");