From bd50819fa0186ff499fe54344afd9e8cc9fed0f1 Mon Sep 17 00:00:00 2001 From: bunnie Date: Sat, 13 Sep 2025 01:09:11 +0800 Subject: [PATCH] fix EP0 receive issue in usb-device usb-device has a limitation for this hardware in that it can't initiate an ep0-receive. It has a hook for flipping ep0 from IN to OUT (as a modal thing) but for our stack you need to explicitly setup EP0 to receive - an exact amount of data based on what's expected - exactly at the point of the setup packet arriving saying an OUT transaction is pending. The hack to work-around this is to simply intercept those setup packets in the handle_event_inner() interrupt handler and initiate the receive. In fact, the data is completely ignored (in our application it's setting a baud rate which is fictional in our system). However, clients such as windows will time out and refuse to communicate if the OUT packet is not ACK'd, even if it is ignored. --- libs/cramium-hal/src/usb/driver.rs | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libs/cramium-hal/src/usb/driver.rs b/libs/cramium-hal/src/usb/driver.rs index 1f972aa99..e79336b77 100644 --- a/libs/cramium-hal/src/usb/driver.rs +++ b/libs/cramium-hal/src/usb/driver.rs @@ -2726,8 +2726,8 @@ impl UsbBus for CorigineWrapper { /// be IN or OUT, but not both at the same time. Devices with both IN/OUT may leave this as /// an empty stub. fn set_ep0_out(&self) { - let addr = self.core().ep0_buf.load(Ordering::SeqCst) as usize; - self.core().ep0_receive(addr, 64, 0); + // let addr = self.core().ep0_buf.load(Ordering::SeqCst) as usize; + // self.core().ep0_receive(addr, 64, 0); } /// Causes the USB peripheral to enter USB suspend mode, lowering power consumption and @@ -2904,6 +2904,17 @@ pub fn handle_event_inner(this: &mut CorigineUsb, event_trb: &mut EventTrbS) -> this.setup_tag = event_trb.get_setup_tag(); #[cfg(feature = "verbose-debug")] crate::println!(" **handle_setup_pkt tag {}", this.setup_tag); + + // the driver doesn't have a provision to set up an ep0 receive, which is necessary for + // the stack to work. Any cases of EP0 receive needed for the devices to work have to be + // manually put in here. Ugh! + if setup_storage[0] == 0x21 && setup_storage[1] == 0x20 && setup_storage[6] == 0x07 { + crate::println!( + "HACK: setup ep0 receive for ACM class - we ignore the result, but the receive must exist" + ); + this.ep0_receive(this.ep0_buf.load(Ordering::SeqCst) as usize, 7, 0); + } + ret = CrgEvent::Data(0, 0, 1); } TrbType::DataStage => {