From a38ba534f15702c8d68c2a57fca6764c1c3c0697 Mon Sep 17 00:00:00 2001 From: bunnie Date: Thu, 15 Apr 2021 02:59:14 +0800 Subject: [PATCH] fix rmwf bug where mask is not shifted before use can't believe this went unnoticed for so long... --- svd2utra/src/generate.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/svd2utra/src/generate.rs b/svd2utra/src/generate.rs index e8af0ed5c..0ce7c79c3 100644 --- a/svd2utra/src/generate.rs +++ b/svd2utra/src/generate.rs @@ -579,7 +579,7 @@ where let usize_base: *mut usize = unsafe { core::mem::transmute(self.base) }; let value_as_usize: usize = value.try_into().unwrap_or_default() << field.offset; let previous = - unsafe { usize_base.add(field.register.offset).read_volatile() } & !field.mask; + unsafe { usize_base.add(field.register.offset).read_volatile() } & !(field.mask << field.offset); unsafe { usize_base .add(field.register.offset)