From 97da54437e1fda6c46a35d5bae3bca0c40cfd001 Mon Sep 17 00:00:00 2001 From: Sean Cross Date: Thu, 20 Apr 2023 13:06:02 +0800 Subject: [PATCH] kernel: allow debug of crashed processes When a process crashes, report this in the kernel console and offer to attach a debugger. Signed-off-by: Sean Cross --- kernel/src/arch/riscv/irq.rs | 2 +- kernel/src/debug/gdb.rs | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/src/arch/riscv/irq.rs b/kernel/src/arch/riscv/irq.rs index 94b64987b..be8d107a5 100644 --- a/kernel/src/arch/riscv/irq.rs +++ b/kernel/src/arch/riscv/irq.rs @@ -411,7 +411,7 @@ pub extern "C" fn trap_handler( ex ); #[cfg(any(feature = "precursor", feature = "renode"))] - panic!( + println!( "{}: CPU Exception on PID {}: {}", if is_kernel_failure { "!!! KERNEL FAILURE !!!" diff --git a/kernel/src/debug/gdb.rs b/kernel/src/debug/gdb.rs index 55fd0e2ca..1c0bf89c7 100644 --- a/kernel/src/debug/gdb.rs +++ b/kernel/src/debug/gdb.rs @@ -295,7 +295,7 @@ pub fn report_stop(_pid: xous_kernel::PID, tid: xous_kernel::TID, _pc: usize) { }; } -pub fn report_terminated(_pid: xous_kernel::PID) { +pub fn report_terminated(pid: xous_kernel::PID) { let Some(XousDebugState { mut target, server: gdb, @@ -306,7 +306,6 @@ pub fn report_terminated(_pid: xous_kernel::PID) { let new_gdb = match gdb { GdbStubStateMachine::Running(inner) => { - println!("Reporting a STOP"); match inner.report_stop( &mut target, MultiThreadStopReason::Signal(Signal::EXC_BAD_ACCESS), @@ -326,9 +325,9 @@ pub fn report_terminated(_pid: xous_kernel::PID) { println!("GDB state was in Disconnect, which shouldn't be possible!"); return; } - GdbStubStateMachine::Idle(_inner) => { - println!("GDB state was in Idle, which shouldn't be possible!"); - return; + GdbStubStateMachine::Idle(inner) => { + println!("Please connect a debugger to debug process {}", pid); + GdbStubStateMachine::Idle(inner) } };