From 8f549b30318157ab6a1dc7ae483f284d7ef4309e Mon Sep 17 00:00:00 2001 From: bunnie Date: Sat, 28 Oct 2023 22:48:52 +0800 Subject: [PATCH] pick a more "happens to be aesthetic" setting for the XOR op defacing XOR op should not be usable to create fake security boxes but it also looks really ugly to have it defaced. This small tweak makes the XOR function look decent for the initial purpose of the function (chat status bar wait indicator). Eventually, this will be a controversial decision, but I'll kick that down the road. --- services/graphics-server/src/op.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/graphics-server/src/op.rs b/services/graphics-server/src/op.rs index 43bdc9e43..f293203b4 100644 --- a/services/graphics-server/src/op.rs +++ b/services/graphics-server/src/op.rs @@ -275,7 +275,7 @@ pub fn rectangle(fb: &mut LcdFB, rect: Rectangle, clip: Option, xor: // This is to make it annoying for someone using an XOR rectangle to synthesize inverted // text on an otherwise untrusted dialog box (I suspect it's not impossible, but introduces // a likelihood of drawing artifacts especially across translations and font size selections). - if pixel.0.y % 20 < 18 { + if pixel.0.y % 25 != 5 { xor_pixel(fb, pixel.0.x, pixel.0.y); } else { // don't allow XOR on some pixels to avoid this being used as a primitive to synthesize secure boxes