From 76bb796610c9dfeacc13675f25dcd60a6b92ce56 Mon Sep 17 00:00:00 2001 From: nworbnhoj Date: Mon, 8 Aug 2022 07:39:49 +1000 Subject: [PATCH] bugfix distortion in png_decode png filter specification calls for initial prior_line = [0u8] see: https://www.w3.org/TR/PNG/#9Filters but [0u8] results in distortion ??????? so use [125u8] --- services/gam/src/bitmap/decode_png.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/services/gam/src/bitmap/decode_png.rs b/services/gam/src/bitmap/decode_png.rs index 120c6c7c6..a827f3998 100644 --- a/services/gam/src/bitmap/decode_png.rs +++ b/services/gam/src/bitmap/decode_png.rs @@ -216,7 +216,10 @@ impl DecodePng { }; self.bytes_per_pixel = (color_type.bpp(self.bit_depth) / 8).try_into().unwrap(); self.bytes_per_line = 1 + self.bytes_per_pixel * self.width as usize; - self.prior_line = vec![0u8; self.bytes_per_line]; + // png filter specification calls for initial prior_line = [0u8] + // see: https://www.w3.org/TR/PNG/#9Filters + // but [0u8] results in distortion??????? + self.prior_line = vec![125u8; self.bytes_per_line]; self.prior_px = vec![0u8; self.bytes_per_pixel]; } (_, _) => return Err(Error::new(InvalidData, "header chunk not first")), @@ -448,6 +451,7 @@ impl DecodePng { // capture the filter byte at the beginning of each png scan line 0 => { self.set_filter_type(); + self.prior_px = vec![0u8; self.bytes_per_pixel]; 0 } i => i - 1,