saymrwulf/xous-core
1
0
Fork 0
mirror of https://github.com/saymrwulf/xous-core.git synced 2026-11-15 08:30:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix dynamic resize redraw bug

Browse source 
for some reason I was setting the state of a canvas to not drawable
when the clip rectangle was being reset, causing dynamic dialog boxes
to become static if the content inside changes size.

I think this is an artifact of a previous generation of this code,
so commenting that out, but left a breadcrumb is case I'm wrong.
This commit is contained in:
bunnie 2022-06-07 16:27:16 +08:00
parent 4f915cd4df
commit 741a6ab45e
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/gam/src/canvas.rs
View file

@ -78,7 +78,13 @@ impl Canvas {
}
pub fn pan_offset(&self) -> Point { self.pan_offset }
pub fn clip_rect(&self) -> Rectangle { self.clip_rect }
pub fn set_clip(&mut self, cr: Rectangle) { self.clip_rect = cr; *self.state.borrow_mut() = CanvasState::OffScreenDrawable }
pub fn set_clip(&mut self, cr: Rectangle) {
self.clip_rect = cr;
// I think this line is in error -- I don't remember *why* we would set this, but with this line here,
// any box that dynamically updates size would become instantly not drawable, with no way to restore that state.
// log::info!("set_clip would side effect {:?} to OffScreenDrawable", self.state.borrow());
// *self.state.borrow_mut() = CanvasState::OffScreenDrawable
}
pub fn gid(&self) -> Gid { self.gid }
pub fn trust_level(&self) -> u8 { self.trust_level }
pub fn set_trust_level(&mut self, level: u8) {self.trust_level = level;}