From 5fa8f2a6a3a5cd8c143ae68264349c4f90449584 Mon Sep 17 00:00:00 2001 From: bunnie Date: Sun, 10 Oct 2021 18:32:00 +0800 Subject: [PATCH] discard errors on log write this at least removes a panic that crashes processes. it does mean that some log messages can get silently lost, but this is better than crashing if the arguments to the logger can't be parsed for some reason? --- services/log-server/src/lib.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/log-server/src/lib.rs b/services/log-server/src/lib.rs index 4d86d90b0..e053f2d92 100644 --- a/services/log-server/src/lib.rs +++ b/services/log-server/src/lib.rs @@ -69,7 +69,10 @@ impl XousLoggerBacking<'_> { } let mut wrapper = cursor::BufferWrapper::new(&mut log_record.args); - write!(wrapper, "{}", record.args()).unwrap(); + match write!(wrapper, "{}", record.args()) { + Ok(_) => {}, + Err(_e) => {}, // if there's an error on the write, just silently discard it... + } log_record.args_length = wrapper.len() as u32; }