From 5a0461cb012e6b11e69a566a91eb54e6c20ea293 Mon Sep 17 00:00:00 2001 From: bunnie Date: Sun, 24 Dec 2023 23:51:04 +0800 Subject: [PATCH] make menu building a bit more efficient by not locking when not necessary --- services/gam/src/menu.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/gam/src/menu.rs b/services/gam/src/menu.rs index 176aac0e4..c49f80c17 100644 --- a/services/gam/src/menu.rs +++ b/services/gam/src/menu.rs @@ -468,10 +468,12 @@ use std::sync::{Arc, Mutex}; /// If you want to modify the menu, pass it a Some(xous::SID) which is the private server /// address of the management interface. pub fn menu_matic(items: Vec::, menu_name: &'static str, maybe_manager: Option) -> Option { - let menu = Arc::new(Mutex::new(Menu::new(menu_name))); + log::debug!("building menu '{:?}'", menu_name); + let mut naked_menu = Menu::new(menu_name); for item in items { - menu.lock().unwrap().add_item(item); + naked_menu.add_item(item); } + let menu = Arc::new(Mutex::new(naked_menu)); let _ = thread::spawn({ let menu = menu.clone(); let sid = menu.lock().unwrap().sid.clone();