From 54648161aba9a98abc25ae022d96ea833ee4efaf Mon Sep 17 00:00:00 2001 From: bunnie Date: Tue, 19 Aug 2025 19:48:16 +0800 Subject: [PATCH] fix more rustc warnings --- apps/vault/libraries/persistent_store/src/linear.rs | 2 +- apps/vault/libraries/persistent_store/src/storage.rs | 2 +- apps/vault/src/ctap/hid/mod.rs | 2 +- apps/vault/src/env/xous/storage.rs | 2 +- loader/src/debug.rs | 2 ++ 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/vault/libraries/persistent_store/src/linear.rs b/apps/vault/libraries/persistent_store/src/linear.rs index 4657770a9..f08a55f2a 100644 --- a/apps/vault/libraries/persistent_store/src/linear.rs +++ b/apps/vault/libraries/persistent_store/src/linear.rs @@ -43,7 +43,7 @@ impl Linear { /// /// This function may allocate if the slice spans multiple pages (because they may not be /// contiguous). However, a slice is returned if the range fits within a page. - pub fn read(&self, range: Range) -> StorageResult> { + pub fn read(&self, range: Range) -> StorageResult> { if range.is_empty() { return Ok(Cow::Borrowed(&[])); } diff --git a/apps/vault/libraries/persistent_store/src/storage.rs b/apps/vault/libraries/persistent_store/src/storage.rs index 596cb51ba..99c48ac15 100644 --- a/apps/vault/libraries/persistent_store/src/storage.rs +++ b/apps/vault/libraries/persistent_store/src/storage.rs @@ -73,7 +73,7 @@ pub trait Storage { /// /// Note that we use `Cow` just because it derefs to `[u8]`. We don't really need the fact that /// one can convert it to a `Vec`. In particular we don't do it in the store implementation. - fn read_slice(&self, index: StorageIndex, length: usize) -> StorageResult>; + fn read_slice(&self, index: StorageIndex, length: usize) -> StorageResult>; /// Writes a word slice to the storage. /// diff --git a/apps/vault/src/ctap/hid/mod.rs b/apps/vault/src/ctap/hid/mod.rs index 585f5536b..82a2ad29e 100644 --- a/apps/vault/src/ctap/hid/mod.rs +++ b/apps/vault/src/ctap/hid/mod.rs @@ -360,7 +360,7 @@ impl CtapHid { } /// Helper function to parse a raw packet. - pub fn process_single_packet(packet: &HidPacket) -> (ChannelID, ProcessedPacket) { + pub fn process_single_packet(packet: &HidPacket) -> (ChannelID, ProcessedPacket<'_>) { let (&cid, rest) = array_refs![packet, 4, 60]; if rest[0] & CtapHid::PACKET_TYPE_MASK != 0 { let cmd = rest[0] & !CtapHid::PACKET_TYPE_MASK; diff --git a/apps/vault/src/env/xous/storage.rs b/apps/vault/src/env/xous/storage.rs index 4c45316bd..13c25ec4d 100644 --- a/apps/vault/src/env/xous/storage.rs +++ b/apps/vault/src/env/xous/storage.rs @@ -48,7 +48,7 @@ impl Storage for XousStorage { 100_000 } - fn read_slice(&self, _index: StorageIndex, _length: usize) -> StorageResult> { + fn read_slice(&self, _index: StorageIndex, _length: usize) -> StorageResult> { unimplemented!() } diff --git a/loader/src/debug.rs b/loader/src/debug.rs index e900728b6..74326d6dd 100644 --- a/loader/src/debug.rs +++ b/loader/src/debug.rs @@ -1,10 +1,12 @@ use utralib::generated::*; +#[allow(dead_code)] pub struct Uart { // pub base: *mut u32, } impl Uart { #[cfg(any(feature = "precursor", feature = "renode"))] + #[allow(dead_code)] pub fn putc(&self, c: u8) { let base = utra::uart::HW_UART_BASE as *mut u32; let mut uart = CSR::new(base);