diff --git a/libs/tls/README.md b/libs/tls/README.md index a0dda3812..634657a09 100644 --- a/libs/tls/README.md +++ b/libs/tls/README.md @@ -15,8 +15,8 @@ Note that hosts with self-signed Certificates may be probed and trusted (e.g. [c A small set of shellchat commands are included to enact the base functionality: - `net tls probe ` will initiate a modified tls handshake with ``, obtain the certificate chain offered by ``, and immediately terminate the connection. A call to Tls::check_trust() will present the CA certificate chain in a modal to be individually selected and saved to PDDB if trusted. -- `net tls test ` will attempt a normal tls handshake with `` based on the trusted Root CA certificates in the PDDB. If the connection is successful, then a simple `get` is emitted, the response accepted, and the connection closed. -- `net tls mozilla` trusts and saves all Root CA's in the [webpki-roots crate](https://crates.io/crates/webpki-roots) - which contains Mozilla's root certificates. (requires `--feature rootCA`) +- `net tls test ` will attempt a normal tls handshake with `` based on the trusted Root CA certificates in the PDDB. If the connection is successful, then a simple `get` is emitted, the response accepted, and the connection closed. +- `net tls mozilla` trusts and saves all Root CA's in the [webpki-roots crate](https://crates.io/crates/webpki-roots) - which contains Mozilla's root certificates. (requires `--feature rootCA`) - `net list` lists all trusted certificates in the PDDB - `net deleteall` deletes all trusted certificates in the PDDB @@ -37,5 +37,5 @@ Considerations: - there is an outstanding **issue** where the `checkbox` modal does not display options with multiple lines correctly. This impacts the display of fingerprints for some certificates with longer subjects. - It may be worth considering rendering public `pddb::KEY_NAME_LEN` to allow developer to avoid sending overly long key's which will be rejected by the pddb. - probably need a shellchat `net tls delete ` -- some broken code is included for a future fix if required [RustlsOwnedTrustAnchor::publik_key()](https://github.com/betrusted-io/xous-core/pull/394/commits/4e0298c17ad2c51aa220a88dc69bf2f56e51076f) +- some broken code is included for a future fix if required [RustlsOwnedTrustAnchor::public_key()](https://github.com/betrusted-io/xous-core/pull/394/commits/4e0298c17ad2c51aa220a88dc69bf2f56e51076f) - some hosts (eg bunnyfoo.com) emit an `unexpected eof` error during tls handshake 🤷 diff --git a/libs/tls/locales/i18n.json b/libs/tls/locales/i18n.json index f6f4cdea3..dd04aacda 100644 --- a/libs/tls/locales/i18n.json +++ b/libs/tls/locales/i18n.json @@ -40,8 +40,8 @@ "en-tts": "save host CA'a if trusted" }, "tls.probe_fail_servername": { - "en": "failed to create sever name from", - "en-tts": "failed to create sever name from" + "en": "failed to create server name from", + "en-tts": "failed to create server name from" }, "tls.probe_done": { "en": "trusted CA's", diff --git a/libs/tls/src/lib.rs b/libs/tls/src/lib.rs index c7c862221..6fd678673 100644 --- a/libs/tls/src/lib.rs +++ b/libs/tls/src/lib.rs @@ -278,7 +278,7 @@ impl Tls { root_store } - /// Probes the target and returns true is at least 1 certificate is trusted + /// Probes the target and returns a count of newly trusted 1 certificates /// /// Establishes a tls connection to the target host, extracts the /// certificates offered and immediately closes the connection.