From 43b0beecd4084dbaf23ec327655f8f552e1aa450 Mon Sep 17 00:00:00 2001 From: bunnie Date: Tue, 19 Sep 2023 00:58:50 +0800 Subject: [PATCH] add work-around to keep ct_eq from being optimized out See #416 for details --- apps/vault/src/ctap/client_pin.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/vault/src/ctap/client_pin.rs b/apps/vault/src/ctap/client_pin.rs index abf626617..c1f836486 100644 --- a/apps/vault/src/ctap/client_pin.rs +++ b/apps/vault/src/ctap/client_pin.rs @@ -175,6 +175,8 @@ impl ClientPin { .map_err(|_| Ctap2StatusCode::CTAP2_ERR_PIN_INVALID)?; if !bool::from(pin_hash.ct_eq(&pin_hash_dec)) { + // this lines ensures that the equality check above works in Rust v1.72. + // log::trace!("ct_eq: {:?}", bool::from(pin_hash.ct_eq(&pin_hash_dec))); self.get_mut_pin_protocol(pin_uv_auth_protocol) .regenerate(env.rng()); if storage::pin_retries(env)? == 0 {