From 25f7bd6f523d9038c354c5099b131a33941c20b1 Mon Sep 17 00:00:00 2001 From: bunnie Date: Sat, 26 Jul 2025 00:43:26 +0800 Subject: [PATCH] remove some redundant mmu flush commands The double-flush in activate() has a big impact on performance, and I'm pretty sure it only needs to happen after the SATP update not before, at least architecturally. Eliminating the extra flush improves the fast message passing benchmark time by 9%. --- kernel/src/arch/riscv/mem.rs | 2 +- kernel/src/swap.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/src/arch/riscv/mem.rs b/kernel/src/arch/riscv/mem.rs index 9aba47244..1cff33f0c 100644 --- a/kernel/src/arch/riscv/mem.rs +++ b/kernel/src/arch/riscv/mem.rs @@ -258,7 +258,7 @@ impl MemoryMapping { /// As such, this will only have an observable effect once code returns /// to userspace. pub fn activate(self) -> Result<(), xous_kernel::Error> { - unsafe { flush_mmu() }; + // unsafe { flush_mmu() }; // redundant - adds 9% time to context switch benchmark when present! satp::write(self.satp); unsafe { flush_mmu() }; Ok(()) diff --git a/kernel/src/swap.rs b/kernel/src/swap.rs index 3239af1e8..0544d3c09 100644 --- a/kernel/src/swap.rs +++ b/kernel/src/swap.rs @@ -431,7 +431,7 @@ impl Swap { true, ) .ok(); - unsafe { crate::arch::mem::flush_mmu() }; + // unsafe { crate::arch::mem::flush_mmu() }; // redundant? } else { already_mapped = true; }