From 0bad04856b4bd1d283c0f48220f5249e6d4bd987 Mon Sep 17 00:00:00 2001 From: bunnie Date: Thu, 14 Nov 2024 00:34:02 +0800 Subject: [PATCH] debug fixed point underflow issue --- services/bao-video/src/homography.rs | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/services/bao-video/src/homography.rs b/services/bao-video/src/homography.rs index a1c8cb7eb..80539f51a 100644 --- a/services/bao-video/src/homography.rs +++ b/services/bao-video/src/homography.rs @@ -52,7 +52,7 @@ pub fn find_homography(src_points: [(f32, f32); 4], dst_points: [(f32, f32); 4]) } } -const HOM_FP_SHIFT: i32 = 16; +const HOM_FP_SHIFT: i32 = 18; const HOM_FP_SCALE: i32 = 1 << HOM_FP_SHIFT; pub fn matrix3_to_fixp(h: Matrix3) -> Matrix3 { @@ -78,8 +78,22 @@ pub fn apply_fixp_homography(homography: &Matrix3, point: (i32, i32)) -> (i let tw = homography[(2, 0)] * x + homography[(2, 1)] * y + homography[(2, 2)]; // Normalize by w to get the final coordinates - let x_transformed = tx / tw; - let y_transformed = ty / tw; + if tw != 0 { + let x_transformed = tx / tw; + let y_transformed = ty / tw; - (x_transformed, y_transformed) + (x_transformed, y_transformed) + } else { + log::info!( + "Homography transformation would divide by 0: possible fixed-point underflow!\n\r {}, {}\n\r {} * {} + {} * {} + {}", + tx, + ty, + homography[(2, 0)], + x, + homography[(2, 1)], + y, + homography[(2, 2)] + ); + (0, 0) + } }