From d76d2a2af7babf73d6c5bc53facaccab05e912f8 Mon Sep 17 00:00:00 2001 From: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Date: Wed, 4 May 2022 07:47:57 -0400 Subject: [PATCH] Make sure telemetry arguments are not returned as unused kwargs (#17063) * Make sure telemetry arguments are not returned as unused kwargs * Fix test --- src/transformers/configuration_utils.py | 4 ++++ tests/test_configuration_common.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/transformers/configuration_utils.py b/src/transformers/configuration_utils.py index f54e1bbdb..f66b5734b 100755 --- a/src/transformers/configuration_utils.py +++ b/src/transformers/configuration_utils.py @@ -676,6 +676,10 @@ class PretrainedConfig(PushToHubMixin): [`PretrainedConfig`]: The configuration object instantiated from those parameters. """ return_unused_kwargs = kwargs.pop("return_unused_kwargs", False) + # Those arguments may be passed along for our internal telemetry. + # We remove them so they don't appear in `return_unused_kwargs`. + kwargs.pop("_from_auto", None) + kwargs.pop("_from_pipeline", None) config = cls(**config_dict) diff --git a/tests/test_configuration_common.py b/tests/test_configuration_common.py index d17ff5406..853a19c3e 100644 --- a/tests/test_configuration_common.py +++ b/tests/test_configuration_common.py @@ -356,7 +356,7 @@ class ConfigurationVersioningTest(unittest.TestCase): ) self.assertEqual(new_configuration.hidden_size, 2) # This checks `_configuration_file` ia not kept in the kwargs by mistake. - self.assertDictEqual(kwargs, {"_from_auto": True}) + self.assertDictEqual(kwargs, {}) # Testing an older version by monkey-patching the version in the module it's used. import transformers as old_transformers