stable-baselines3/tests/test_sde.py
PatrickHelm 16c6a886db
Fix squash output unscaling when using gSDE (#1652)
* prevents squash_output if not use_sde, see #1592

* update changelog

* add unscaling of actions taken during training

* add test regarding squashing and unquashing

* avoids try-except block

* format Gymnasium code with black

* makes mypy pass

* makes pytype pass

* sort imports

* makes error message in assert statement clearer

Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>

* improves code commenting

* replaces full env with wrapper

* Cleanup code

* Reformat

---------

Co-authored-by: PatrickHelm <patrick.helm@gmx.net>
Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
Co-authored-by: Antonin Raffin <antonin.raffin@dlr.de>
2023-09-01 17:58:15 +02:00

122 lines
4.2 KiB
Python

import gymnasium as gym
import numpy as np
import pytest
import torch as th
from torch.distributions import Normal
from stable_baselines3 import A2C, PPO, SAC
def test_state_dependent_exploration_grad():
"""
Check that the gradient correspond to the expected one
"""
n_states = 2
state_dim = 3
action_dim = 10
sigma_hat = th.ones(state_dim, action_dim, requires_grad=True)
# Reduce the number of parameters
# sigma_ = th.ones(state_dim, action_dim) * sigma_
# weights_dist = Normal(th.zeros_like(log_sigma), th.exp(log_sigma))
th.manual_seed(2)
weights_dist = Normal(th.zeros_like(sigma_hat), sigma_hat)
weights = weights_dist.rsample()
state = th.rand(n_states, state_dim)
mu = th.ones(action_dim)
noise = th.mm(state, weights)
action = mu + noise
variance = th.mm(state**2, sigma_hat**2)
action_dist = Normal(mu, th.sqrt(variance))
# Sum over the action dimension because we assume they are independent
loss = action_dist.log_prob(action.detach()).sum(dim=-1).mean()
loss.backward()
# From Rueckstiess paper: check that the computed gradient
# correspond to the analytical form
grad = th.zeros_like(sigma_hat)
for j in range(action_dim):
# sigma_hat is the std of the gaussian distribution of the noise matrix weights
# sigma_j = sum_j(state_i **2 * sigma_hat_ij ** 2)
# sigma_j is the standard deviation of the policy gaussian distribution
sigma_j = th.sqrt(variance[:, j])
for i in range(state_dim):
# Derivative of the log probability of the jth component of the action
# w.r.t. the standard deviation sigma_j
d_log_policy_j = (noise[:, j] ** 2 - sigma_j**2) / sigma_j**3
# Derivative of sigma_j w.r.t. sigma_hat_ij
d_log_sigma_j = (state[:, i] ** 2 * sigma_hat[i, j]) / sigma_j
# Chain rule, average over the minibatch
grad[i, j] = (d_log_policy_j * d_log_sigma_j).mean()
# sigma.grad should be equal to grad
assert sigma_hat.grad.allclose(grad)
def test_sde_check():
with pytest.raises(ValueError):
PPO("MlpPolicy", "CartPole-v1", use_sde=True)
def test_only_sde_squashed():
with pytest.raises(AssertionError, match="use_sde=True"):
PPO("MlpPolicy", "Pendulum-v1", use_sde=False, policy_kwargs=dict(squash_output=True))
@pytest.mark.parametrize("model_class", [SAC, A2C, PPO])
@pytest.mark.parametrize("use_expln", [False, True])
@pytest.mark.parametrize("squash_output", [False, True])
def test_state_dependent_noise(model_class, use_expln, squash_output):
kwargs = {"learning_starts": 0} if model_class == SAC else {"n_steps": 64}
policy_kwargs = dict(log_std_init=-2, use_expln=use_expln, net_arch=[64])
if model_class in [A2C, PPO]:
policy_kwargs["squash_output"] = squash_output
elif not squash_output:
pytest.skip("SAC can only use squashed output")
env = StoreActionEnvWrapper(gym.make("Pendulum-v1"))
model = model_class(
"MlpPolicy",
env,
use_sde=True,
seed=1,
verbose=1,
policy_kwargs=policy_kwargs,
**kwargs,
)
model.learn(total_timesteps=255)
buffer = model.replay_buffer if model_class == SAC else model.rollout_buffer
# Check that only scaled actions are stored
assert (buffer.actions <= model.action_space.high).all()
assert (buffer.actions >= model.action_space.low).all()
if squash_output:
# Pendulum action range is [-2, 2]
# we check that the action are correctly unscaled
if buffer.actions.max() > 0.5:
assert np.max(env.actions) > 1.0
if buffer.actions.max() < -0.5:
assert np.min(env.actions) < -1.0
model.policy.reset_noise()
if model_class == SAC:
model.policy.actor.get_std()
class StoreActionEnvWrapper(gym.Wrapper):
"""
Keep track of which actions were sent to the env.
"""
def __init__(self, env):
super().__init__(env)
# defines list for tracking actions
self.actions = []
def step(self, action):
# appends list for tracking actions
self.actions.append(action)
return super().step(action)