From d8148deeaad3dbd1fb2b601e6f21d71f210366b1 Mon Sep 17 00:00:00 2001 From: Corentin <111868204+corentinlger@users.noreply.github.com> Date: Fri, 5 Jul 2024 19:07:55 +0200 Subject: [PATCH] Updated DQN optimizer input to only include q_network parameters as input (#1963) * Updated DQN optimizer input to only include q_network parameters * Update version --------- Co-authored-by: Antonin RAFFIN --- docs/misc/changelog.rst | 3 ++- stable_baselines3/dqn/policies.py | 2 +- stable_baselines3/version.txt | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index 8df3211..78eb2bd 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -3,7 +3,7 @@ Changelog ========== -Release 2.4.0a4 (WIP) +Release 2.4.0a5 (WIP) -------------------------- Breaking Changes: @@ -20,6 +20,7 @@ Bug Fixes: - ``CallbackList`` now sets the ``.parent`` attribute of child callbacks to its own ``.parent``. (will-maclean) - Fixed error when loading a model that has ``net_arch`` manually set to ``None`` (@jak3122) - Set requirement numpy<2.0 until PyTorch is compatible (https://github.com/pytorch/pytorch/issues/107302) +- Updated DQN optimizer input to only include q_network parameters, removing the target_q_network ones (@corentinlger) `SB3-Contrib`_ ^^^^^^^^^^^^^^ diff --git a/stable_baselines3/dqn/policies.py b/stable_baselines3/dqn/policies.py index 9d2cf94..bfefc81 100644 --- a/stable_baselines3/dqn/policies.py +++ b/stable_baselines3/dqn/policies.py @@ -167,7 +167,7 @@ class DQNPolicy(BasePolicy): # Setup optimizer with initial learning rate self.optimizer = self.optimizer_class( # type: ignore[call-arg] - self.parameters(), + self.q_net.parameters(), lr=lr_schedule(1), **self.optimizer_kwargs, ) diff --git a/stable_baselines3/version.txt b/stable_baselines3/version.txt index 2d22b15..a1fd35b 100644 --- a/stable_baselines3/version.txt +++ b/stable_baselines3/version.txt @@ -1 +1 @@ -2.4.0a4 +2.4.0a5