From cd630a31213cd3591e09f8974d34241e811fab04 Mon Sep 17 00:00:00 2001 From: Antonin RAFFIN Date: Fri, 25 Nov 2022 15:14:55 +0100 Subject: [PATCH] Fixes for flake8 6.0 (#1181) --- docs/misc/changelog.rst | 1 + setup.cfg | 3 ++- stable_baselines3/common/base_class.py | 2 +- tests/test_utils.py | 4 ++-- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index c1d9461..f5cf0b6 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -36,6 +36,7 @@ Deprecations: Others: ^^^^^^^ - Used issue forms instead of issue templates +- Fixed flake8 config to be compatible with flake8 6+ Documentation: ^^^^^^^^^^^^^^ diff --git a/setup.cfg b/setup.cfg index b79e63a..5e30726 100644 --- a/setup.cfg +++ b/setup.cfg @@ -80,7 +80,8 @@ exclude = (?x)( ) [flake8] -ignore = W503,W504,E203,E231 # line breaks before and after binary operators +# line breaks before and after binary operators +ignore = W503,W504,E203,E231 # Ignore import not used when aliases are defined per-file-ignores = ./stable_baselines3/__init__.py:F401 diff --git a/stable_baselines3/common/base_class.py b/stable_baselines3/common/base_class.py index bb14f6a..9351bfb 100644 --- a/stable_baselines3/common/base_class.py +++ b/stable_baselines3/common/base_class.py @@ -125,7 +125,7 @@ class BaseAlgorithm(ABC): # Used for computing fps, it is updated at each call of learn() self._num_timesteps_at_start = 0 self.seed = seed - self.action_noise = None # type: Optional[ActionNoise] + self.action_noise: Optional[ActionNoise] = None self.start_time = None self.policy = None self.learning_rate = learning_rate diff --git a/tests/test_utils.py b/tests/test_utils.py index e9281c3..e74b1d0 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -298,13 +298,13 @@ def test_evaluate_policy_monitors(vec_env_class): episode_rewards, episode_lengths = evaluate_policy( model, eval_env, n_eval_episodes, return_episode_rewards=True, warn=False ) - assert all(map(lambda l: l == 1, episode_lengths)), "AlwaysDoneWrapper did not fix episode lengths to one" + assert all(map(lambda length: length == 1, episode_lengths)), "AlwaysDoneWrapper did not fix episode lengths to one" eval_env.close() # Should get longer episodes with with Monitor (true episodes) eval_env = make_eval_env(with_monitor=True, wrapper_class=AlwaysDoneWrapper) episode_rewards, episode_lengths = evaluate_policy(model, eval_env, n_eval_episodes, return_episode_rewards=True) - assert all(map(lambda l: l > 1, episode_lengths)), "evaluate_policy did not get episode lengths from Monitor" + assert all(map(lambda length: length > 1, episode_lengths)), "evaluate_policy did not get episode lengths from Monitor" eval_env.close()