From a30d36002b066a16193f4534d0aa74962225c508 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Quentin=20Gallou=C3=A9dec?= <45557362+qgallouedec@users.noreply.github.com> Date: Tue, 16 Aug 2022 10:53:22 +0200 Subject: [PATCH 1/2] Fix `DictReplayBuffer.next_observations` type (#1013) * Fix DictReplayBuffer.next_observations type * Update changelog Co-authored-by: Antonin RAFFIN --- docs/misc/changelog.rst | 1 + stable_baselines3/common/type_aliases.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index e9d4b78..3fde0be 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -26,6 +26,7 @@ Deprecations: Others: ^^^^^^^ +- Fixed ``DictReplayBuffer.next_observations`` typing (@qgallouedec) Documentation: ^^^^^^^^^^^^^^ diff --git a/stable_baselines3/common/type_aliases.py b/stable_baselines3/common/type_aliases.py index 7e69d39..f4c29ab 100644 --- a/stable_baselines3/common/type_aliases.py +++ b/stable_baselines3/common/type_aliases.py @@ -50,7 +50,7 @@ class ReplayBufferSamples(NamedTuple): class DictReplayBufferSamples(ReplayBufferSamples): observations: TensorDict actions: th.Tensor - next_observations: th.Tensor + next_observations: TensorDict dones: th.Tensor rewards: th.Tensor From 792e3bcc275cb5f71f894e55c37a374ca9b744c7 Mon Sep 17 00:00:00 2001 From: Burak Demirbilek Date: Tue, 16 Aug 2022 14:32:32 +0300 Subject: [PATCH 2/2] Fixed missing verbose parameter passing (#1011) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> --- docs/misc/changelog.rst | 3 ++- stable_baselines3/common/base_class.py | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index 3fde0be..b01d60d 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -20,6 +20,7 @@ Bug Fixes: - Fixed the issue that ``predict`` does not always return action as ``np.ndarray`` (@qgallouedec) - Fixed division by zero error when computing FPS when a small number of time has elapsed in operating systems with low-precision timers. - Added multidimensional action space support (@qgallouedec) +- Fixed missing verbose parameter passing in the ``EvalCallback`` constructor (@burakdmb) Deprecations: ^^^^^^^^^^^^^ @@ -1018,4 +1019,4 @@ And all the contributors: @eleurent @ac-93 @cove9988 @theDebugger811 @hsuehch @Demetrio92 @thomasgubler @IperGiove @ScheiklP @simoninithomas @armandpl @manuel-delverme @Gautam-J @gianlucadecola @buoyancy99 @caburu @xy9485 @Gregwar @ycheng517 @quantitative-technologies @bcollazo @git-thor @TibiGG @cool-RR @MWeltevrede -@Melanol @qgallouedec @francescoluciano @jlp-ue +@Melanol @qgallouedec @francescoluciano @jlp-ue @burakdmb diff --git a/stable_baselines3/common/base_class.py b/stable_baselines3/common/base_class.py index e8032e7..9445ee4 100644 --- a/stable_baselines3/common/base_class.py +++ b/stable_baselines3/common/base_class.py @@ -392,6 +392,7 @@ class BaseAlgorithm(ABC): log_path=log_path, eval_freq=eval_freq, n_eval_episodes=n_eval_episodes, + verbose=self.verbose, ) callback = CallbackList([callback, eval_callback])