From 977a615c824b43d28aeadb05c0a2390484145216 Mon Sep 17 00:00:00 2001 From: Matthias K Date: Sat, 20 Jun 2020 18:01:37 +0200 Subject: [PATCH] Fixed SubprocVecEnv close. (#68) Updated changelog. Co-authored-by: Matthias K --- docs/misc/changelog.rst | 1 + stable_baselines3/common/vec_env/subproc_vec_env.py | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index 565b647..baa79dc 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -15,6 +15,7 @@ New Features: Bug Fixes: ^^^^^^^^^^ +- Fixed a bug in the ``close()`` method of ``SubprocVecEnv``, causing wrappers further down in the wrapper stack to not be closed. (@NeoExtended) Deprecations: ^^^^^^^^^^^^^ diff --git a/stable_baselines3/common/vec_env/subproc_vec_env.py b/stable_baselines3/common/vec_env/subproc_vec_env.py index 3fcb4a5..b12218f 100644 --- a/stable_baselines3/common/vec_env/subproc_vec_env.py +++ b/stable_baselines3/common/vec_env/subproc_vec_env.py @@ -29,6 +29,7 @@ def _worker(remote, parent_remote, env_fn_wrapper): elif cmd == 'render': remote.send(env.render(data)) elif cmd == 'close': + env.close() remote.close() break elif cmd == 'get_spaces':