From 4f9805eeb8d4ee888b0967f05f142f72c97e1867 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=9Cbertreiber?= Date: Thu, 27 Apr 2023 19:07:53 +0200 Subject: [PATCH] Fix overly relaxed version requirement on NumPy (#1472) Since commit 489b1fda, this package has been using `numpy.typing.DTypeLike`, which was only added in [NumPy 1.20][1]. [1]: https://numpy.org/doc/stable/release/1.20.0-notes.html#numpy-is-now-typed Co-authored-by: troiganto Co-authored-by: Antonin RAFFIN --- docs/misc/changelog.rst | 3 ++- setup.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index cfe2819..9492bd7 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -35,6 +35,7 @@ New Features: Bug Fixes: ^^^^^^^^^^ - Fixed ``VecExtractDictObs`` does not handle terminal observation (@WeberSamuel) +- Set NumPy version to ``>=1.20`` due to use of ``numpy.typing`` (@troiganto) - Fixed loading DQN changes ``target_update_interval`` (@tobirohrer) Deprecations: @@ -1331,4 +1332,4 @@ And all the contributors: @carlosluis @arjun-kg @tlpss @Melanol @qgallouedec @francescoluciano @jlp-ue @burakdmb @timothe-chaumont @honglu2875 @anand-bala @hughperkins @sidney-tio @AlexPasqua @dominicgkerr @Akhilez @Rocamonde @tobirohrer @ZikangXiong -@DavyMorgan @luizapozzobon @Bonifatius94 @theSquaredError @harveybellini @DavyMorgan @FieteO @jonasreiher @npit @WeberSamuel +@DavyMorgan @luizapozzobon @Bonifatius94 @theSquaredError @harveybellini @DavyMorgan @FieteO @jonasreiher @npit @WeberSamuel @troiganto diff --git a/setup.py b/setup.py index a7a3fcc..d72e77d 100644 --- a/setup.py +++ b/setup.py @@ -103,7 +103,7 @@ setup( package_data={"stable_baselines3": ["py.typed", "version.txt"]}, install_requires=[ "gymnasium==0.28.1", - "numpy", + "numpy>=1.20", "torch>=1.11", 'typing_extensions>=4.0,<5; python_version < "3.8.0"', # For saving models