mirror of
https://github.com/saymrwulf/risc0-ed25519-verified.git
synced 2026-09-03 19:53:45 +00:00
THE GAP. The capability matrix in the control repo — built after the author
answered a capability question by grepping for a FILENAME rather than for the
property, three times in one session — asked whether each repository's auditor
enumerates itself. The four ed25519 forks answered no. Following that up found
something larger: `Proofs/Audit.lean`, the statement-binding driver from P1-a,
is compiled, is a member of the manifest, and was enumerated by NOTHING. The
kernel counted 3058 declarations where the inventory accounted for 3022, and
26 of the 36 missing were its.
THE PROPERTY, now enforced: every constant the kernel sees under this button's
manifest must appear, BY NAME, in either the corpus inventory or the
instruments' own surface. `emitDrivers` in InventoryCore walks the audit
modules and fails closed on an axiom (which would widen the trusted base
outside every cone) or on a standalone claim (which no certificate covers and
no allowlist pins), while admitting the obligations the elaborator generates
for a definition declared alongside it.
TWO WRONG FORMULATIONS FIRST, both recorded because the second is instructive:
· `kernel = corpus + instruments + N_DRIVERS`, where the last term was
justified as a per-driver "self-observation blind spot". It fitted dalek
and anza (2 drivers, residual 2) and broke on risc0 and betrusted
(1 driver, residual 2). The residual is 2 everywhere and has nothing to do
with drivers. This was curve-fitting from a sample of one, and it was named
as the highest-risk claim in the round-7 self-assessment BEFORE the data
refuted it.
· distinct-by-name counting, which collapses `CurveFieldProofs.zero_spec` —
a name that genuinely denotes two different declarations, in Proofs.Basic
and Proofs.ConstSpecs, walked by two drivers with separate environments.
THE MEASURED CAUSE of the residual. Lean materialises equation lemmas lazily,
when something forces an unfold, and each module that forces one gets its own
copy in its object file. `CurveFieldProofs.denote.eq_1` sits in both
SubNegSpec.olean and ConstSpecs.olean; `CurveFieldProofs.limbsVal.eq_1` in both
ReduceSpec.olean and ConstSpecs.olean. The kernel gate reads object files and
counts both copies; the environment holds one constant per name. Counts cannot
relate those two views in either direction — so the check compares SETS, which
is the idiom the rest of this estate already uses, and no constant remains that
could be widened to make a red run green.
Negative-tested: with the instrument walk disabled, the check names
Proofs.Audit's declarations as unaccounted.
ANZA also lacked one allowlist row, `subtle.Choice...from.eq_1`, the same
lazy-materialisation effect seen from the other side. Verified rather than
assumed before adding it: the parent is declared in gen/CurveField/
FunsExternal.lean — the model, pinned by bytes and not inventoried by
declaration — the lemma materialised in Proofs.CompressSpec which forced the
unfold, and all three other forks carry the lemma row while none carries the
parent.
CONSEQUENCE WORTH DISCLOSING: the audited declaration surface is not purely a
function of the corpus source. It depends on which proofs forced which
unfolds. This is now a known gap in the round-7 kit.
Also corrected here: Proofs/Inventory.lean's header claimed the audit drivers
were excluded from the compile manifest. They are lines 42-44 of PROOFS.
Certified by a full sweep: both buttons, all four forks, purged trees. 8/8.
170 lines
8.8 KiB
Text
170 lines
8.8 KiB
Text
/- ──────────────────────────────────────────────────────────────────────────
|
||
Proofs/InventoryCore.lean — shared machinery for the declaration inventory.
|
||
|
||
PORTED, NOT REINVENTED. This is the ltl-accumulator-verified design
|
||
(Proofs/Inventory.lean there), which survived a nine-attack self-test that
|
||
defeated a source-regex enumerator: attributed, private, indented and
|
||
`instance` declarations were all invisible to the regex, and a nested
|
||
`namespace Hidden theorem MTH` collided with the basename of an audited
|
||
declaration. Reading the compiled ENVIRONMENT sees exactly what the kernel
|
||
saw, and there is no name shape that can hide from it.
|
||
|
||
WHY TWO DRIVERS IMPORT THIS. Unlike the accumulator, this corpus cannot be
|
||
imported as one environment: `Proofs.Basic` and `Proofs.ConstSpecs` both
|
||
declare `CurveFieldProofs.zero_spec`. That is deliberate and documented —
|
||
Basic.lean is compiled by check.sh but imported by nothing, so the reuse is
|
||
harmless — but it makes a single whole-corpus import impossible. The corpus
|
||
therefore splits into the main chain and Basic, one driver each, and
|
||
check.sh concatenates their output before gating. The split is asserted in
|
||
check.sh against the compile manifest, so a module cannot fall between the
|
||
two drivers unnoticed.
|
||
|
||
The corpus module list lives in each DRIVER, not here, and is checked
|
||
textually against check.sh's manifest in both directions. A listed module
|
||
that is not actually imported is an elaboration error, not a silent skip.
|
||
────────────────────────────────────────────────────────────────────────── -/
|
||
import Lean
|
||
|
||
open Lean
|
||
|
||
namespace Ed25519Inventory
|
||
|
||
def kindOf : ConstantInfo → String
|
||
| .axiomInfo _ => "axiom"
|
||
| .defnInfo _ => "def"
|
||
| .thmInfo _ => "theorem"
|
||
| .opaqueInfo _ => "opaque"
|
||
| .quotInfo _ => "quot"
|
||
| .inductInfo _ => "inductive"
|
||
| .ctorInfo _ => "ctor"
|
||
| .recInfo _ => "recursor"
|
||
|
||
/-- Axiom cone of `n`, from the kernel's own collector — the same machinery
|
||
`#print axioms` uses.
|
||
|
||
NO INDEPENDENT SECOND WALKER HERE, and that is a deliberate REDUCTION in
|
||
strength against the ltl-accumulator design this is ported from. There, a
|
||
hand-written closure walker runs alongside `collectAxioms` and every
|
||
constant must get the same answer from both, so the two implementations
|
||
check each other. Porting that walker to this corpus was tried on
|
||
2026-07-29 and abandoned on evidence:
|
||
|
||
· without traversing inductive families it UNDER-approximated —
|
||
`CurveFieldProofs.EdPoint`: walker [] vs kernel [Classical.choice,
|
||
Quot.sound, propext];
|
||
· adding constructors, recursor rules and `all` groups made it
|
||
OVER-approximate — `CurveFieldProofs.ProjPoint`: walker
|
||
[Classical.choice, Quot.sound, propext] vs kernel [].
|
||
|
||
Disagreeing in BOTH directions means the second implementation is not an
|
||
independent check, it is a second wrong answer. Matching the kernel's
|
||
traversal exactly over mathlib's inductive shapes is a Lean-internals
|
||
project, not a gate, and shipping a walker that is wrong in two directions
|
||
would be worse than shipping none: it would fail builds for reasons that
|
||
are the checker's fault and teach everyone to ignore it.
|
||
|
||
CONSEQUENCE, stated so nobody assumes otherwise: on this corpus the cone
|
||
figures rest on `collectAxioms` alone. The accumulator's corpus is
|
||
mathlib-free, its walker agrees there, and it KEEPS the cross-check. This
|
||
is recorded in TRUSTED-BASE.md. -/
|
||
def axiomCone (n : Name) : MetaM (Array Name) := do
|
||
let cone ← collectAxioms n
|
||
return cone.qsort (fun a b => a.toString < b.toString)
|
||
|
||
/-- Emit `INV|name|kind|cone` for every constant originating in `corpus`.
|
||
EVERY constant is emitted — fully qualified, NO filtering. Compiler-
|
||
generated auxiliaries (equation lemmas, match/eq/induct helpers, private
|
||
manglings) are emitted too and pinned in the allowlist, so anything new,
|
||
renamed, removed, or with a changed cone shows up as a diff. -/
|
||
def emitInventory (corpus : Array Name) : MetaM Unit := do
|
||
let env ← getEnv
|
||
let mut idxs : Array Nat := #[]
|
||
for m in corpus do
|
||
match env.getModuleIdx? m with
|
||
| some i => idxs := idxs.push i
|
||
| none => throwError "INVENTORY ERROR: corpus module {m} is not imported"
|
||
let mut lines : Array String := #[]
|
||
for (n, ci) in env.constants.toList do
|
||
if let some i := env.getModuleIdxFor? n then
|
||
if idxs.contains i then
|
||
let cone ← axiomCone n
|
||
let coneStr := ",".intercalate (cone.toList.map (·.toString))
|
||
-- The ORIGINATING MODULE is part of the record, unlike the accumulator's
|
||
-- format. It has to be: this corpus contains two distinct declarations
|
||
-- both named `CurveFieldProofs.zero_spec` (Proofs.Basic and
|
||
-- Proofs.ConstSpecs), inventoried by different drivers. Keyed on name
|
||
-- alone their records were byte-identical, so the merged allowlist held
|
||
-- 3021 entries for 3022 declarations and one real declaration was
|
||
-- covered by an entry describing a different one. The count trailer
|
||
-- caught it; the module field is what fixes it.
|
||
let mdl := env.header.moduleNames[i]!
|
||
lines := lines.push s!"INV|{mdl}|{n}|{kindOf ci}|{coneStr}"
|
||
let sorted := lines.qsort (· < ·)
|
||
for l in sorted do
|
||
IO.println l
|
||
-- Output-integrity trailer: a truncated or crashed run must never pass as an
|
||
-- empty diff. inventory_gate.sh compares this against the lines it actually
|
||
-- received, in both directions.
|
||
IO.println s!"INV-COUNT|{sorted.size}"
|
||
|
||
/-- THE INSTRUMENTS' OWN SURFACE.
|
||
|
||
`emitInventory` walks the CORPUS. It says nothing about the modules that
|
||
perform the audit, and until 2026-07-31 nothing else enumerated them either:
|
||
the kernel counted 3058 declarations across this button's 43 modules while
|
||
the inventory accounted for 3022, and the 36-declaration difference — the
|
||
drivers' own machinery — was covered by no allowlist row.
|
||
|
||
That difference was never a soundness hole. The drivers ARE members of
|
||
check.sh's compile manifest, so Phase 2b's kernel-side gate reads their
|
||
`.olean`s and an axiom in one is rejected whatever its indentation. What was
|
||
missing is the weaker but still real property: that an instrument declares
|
||
nothing but inert machinery, and that every declaration the kernel sees is
|
||
ACCOUNTED FOR by exactly one of the two walks.
|
||
|
||
The policy is not "declare nothing" — these files legitimately declare their
|
||
own functions. It is that an instrument may not declare an AXIOM (which
|
||
would widen the trusted base outside every cone) nor a standalone CLAIM
|
||
(which no certificate covers and no allowlist pins). A theorem whose name
|
||
extends a constant declared alongside it is an artefact the elaborator
|
||
generated for a definition — well-founded recursion emits these — and is
|
||
allowed; a theorem whose parent is not a declared constant is not. -/
|
||
def emitDrivers (drivers : Array Name) : MetaM Unit := do
|
||
let env ← getEnv
|
||
let mut idxs : Array Nat := #[]
|
||
for m in drivers do
|
||
match env.getModuleIdx? m with
|
||
| some i => idxs := idxs.push i
|
||
| none => throwError "DRIVER SURFACE ERROR: driver module {m} is not imported"
|
||
-- Two passes: collect the names first, so the artefact test can ask whether a
|
||
-- theorem's parent is itself declared by an instrument.
|
||
let mut names : Std.HashSet Name := {}
|
||
let mut here : Array (Name × ConstantInfo) := #[]
|
||
for (n, ci) in env.constants.toList do
|
||
let mine : Bool :=
|
||
match env.getModuleIdxFor? n with
|
||
| some i => idxs.contains i
|
||
| none => true -- declared by the module being elaborated: this driver
|
||
if mine then
|
||
names := names.insert n
|
||
here := here.push (n, ci)
|
||
let mut lines : Array String := #[]
|
||
for (n, ci) in here do
|
||
let k := kindOf ci
|
||
if k == "axiom" then
|
||
throwError "DRIVER SURFACE VIOLATION: {n} is an axiom declared by the audit \
|
||
infrastructure. An instrument may not widen the trusted base."
|
||
if k == "theorem" && !names.contains n.getPrefix then
|
||
throwError "DRIVER SURFACE VIOLATION: {n} is a standalone theorem declared by \
|
||
the audit infrastructure. An instrument may declare definitions \
|
||
and whatever the elaborator generates for them — never a claim \
|
||
of its own."
|
||
lines := lines.push s!"DRV|{n}|{k}"
|
||
let sorted := lines.qsort (· < ·)
|
||
for l in sorted do
|
||
IO.println l
|
||
IO.println s!"DRV-COUNT|{sorted.size}"
|
||
|
||
|
||
|
||
end Ed25519Inventory
|