From 4cbff3983db315f09e8bc72ab077c79861c95491 Mon Sep 17 00:00:00 2001 From: Henry de Valence Date: Wed, 3 Jan 2018 14:01:48 -0800 Subject: [PATCH] Remove fixme notes --- src/backend/avx2/edwards.rs | 12 ++++-------- src/backend/avx2/field.rs | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/backend/avx2/edwards.rs b/src/backend/avx2/edwards.rs index 83dc683..d995859 100644 --- a/src/backend/avx2/edwards.rs +++ b/src/backend/avx2/edwards.rs @@ -37,14 +37,12 @@ use backend::avx2; #[derive(Copy, Clone, Debug)] pub struct ExtendedPoint(pub(super) FieldElement32x4); -// XXX need to cfg gate here to handle FieldElement64 impl From for ExtendedPoint { fn from(P: edwards::ExtendedPoint) -> ExtendedPoint { ExtendedPoint(FieldElement32x4::new(&P.X, &P.Y, &P.Z, &P.T)) } } -// XXX need to cfg gate here to handle FieldElement64 impl From for edwards::ExtendedPoint { fn from(P: ExtendedPoint) -> edwards::ExtendedPoint { let tmp = P.0.split(); @@ -608,17 +606,15 @@ pub mod vartime { Q.into() } - /// Given a vector of public scalars and a vector of (possibly secret) - /// points, compute `c_1 P_1 + ... + c_n P_n`. + /// Given a vector of public scalars and a vector of public points, compute + /// $$ + /// Q = c\_1 P\_1 + \cdots + c\_n P\_n. + /// $$ /// /// # Input /// /// A vector of `Scalar`s and a vector of `ExtendedPoints`. It is an /// error to call this function with two vectors of different lengths. - /// - /// XXX need to clear memory - /// - /// XXX see note on consttime multiscalar mul #[cfg(any(feature = "alloc", feature = "std"))] pub fn multiscalar_mult<'a, 'b, I, J>(scalars: I, points: J) -> edwards::ExtendedPoint where I: IntoIterator, diff --git a/src/backend/avx2/field.rs b/src/backend/avx2/field.rs index cf6533e..29ae3ee 100644 --- a/src/backend/avx2/field.rs +++ b/src/backend/avx2/field.rs @@ -120,7 +120,6 @@ impl FieldElement32x4 { } /// Negate variables in lanes where mask is set - /// XXX fix up api pub fn negate(&mut self, mask: u8) { let mask = mask as i32; unsafe {