saymrwulf/risc0-curve25519-dalek-source
1
0
Fork 0
mirror of https://github.com/saymrwulf/risc0-curve25519-dalek-source.git synced 2026-09-07 20:30:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add note to StaticSecret that EphemeralSecret is recommended.

Browse source
This commit is contained in:
Isis Lovecruft 2021-09-14 20:23:38 +00:00
parent 27c73fdb57
commit 3924797b59
No known key found for this signature in database
GPG key ID: AB41313533E8E812
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/x25519.rs
View file

@ -102,6 +102,8 @@ impl<'a> From<&'a EphemeralSecret> for PublicKey {
/// Diffie-Hellman operation multiple times throughout the protocol, while the /// Diffie-Hellman operation multiple times throughout the protocol, while the
/// protocol run at a higher level is only conducted once per key. /// protocol run at a higher level is only conducted once per key.
/// ///
/// # Warning
///
/// If you're uncertain about whether you should use this, then you likely /// If you're uncertain about whether you should use this, then you likely
/// should not be using this. Our strongly recommended advice is to use /// should not be using this. Our strongly recommended advice is to use
/// [`EphemeralSecret`] at all times, as that type enforces at compile-time that /// [`EphemeralSecret`] at all times, as that type enforces at compile-time that
@ -153,6 +155,14 @@ impl<'a> From<&'a ReusableSecret> for PublicKey {
/// ``` /// ```
/// since the only difference between the two is that [`StaticSecret`] does not enforce at /// since the only difference between the two is that [`StaticSecret`] does not enforce at
/// compile-time that the key is only used once. /// compile-time that the key is only used once.
///
/// # Warning
///
/// If you're uncertain about whether you should use this, then you likely
/// should not be using this. Our strongly recommended advice is to use
/// [`EphemeralSecret`] at all times, as that type enforces at compile-time that
/// secret keys are never reused, which can have very serious security
/// implications for many protocols.
#[cfg_attr(feature = "serde", serde(crate = "our_serde"))] #[cfg_attr(feature = "serde", serde(crate = "our_serde"))]
#[cfg_attr( #[cfg_attr(
feature = "serde", feature = "serde",