pytorch/tools
Sam Estep e5179e960e Share VS Code settings/extensions nicely (#57671)
Summary:
This is a second attempt at https://github.com/pytorch/pytorch/issues/51214. It should achieve the same goals with (as far as I can tell) no disadvantages, but the advantages are a bit less pronounced than in the more dictatorial approach that https://github.com/pytorch/pytorch/issues/51214 took:

- Unfortunately, I was unable to figure out how to include [the `mypy` configuration given in the docstring of `tools.mypy_wrapper.main`](7115a4b870/tools/mypy_wrapper.py (L81-L89)), because as walterddr pointed out, `"${env:HOME}/miniconda3/envs/pytorch/bin/python"` is not guaranteed to be correct on everyone's machine:
  ```json
  {
    "python.linting.enabled": true,
    "python.linting.mypyEnabled": true,
    "python.linting.mypyPath": "${env:HOME}/miniconda3/envs/pytorch/bin/python",
    "python.linting.mypyArgs": [
      "${workspaceFolder}/tools/mypy_wrapper.py"
    ]
  }
  ```

  Importantly, this does not work:
  ```json
  "python.linting.mypyPath": "${workspaceFolder}/tools/mypy_wrapper.py"
  ```
  This is because VS Code does not run the given `mypy` command inside of the user's specified virtual environment, so for instance, on my system, setting the `mypy` command to directly call `tools/mypy_wrapper.py` results in using `mypy 0.782` instead of the correct `mypy 0.812`.

  Sadly, [this](https://code.visualstudio.com/docs/editor/variables-reference#_configuration-variables) does not work either, although I'm not sure why:
  ```json
  {
    "python.linting.mypyPath": "${config:python.pythonPath}",
    "python.linting.mypyArgs": [
      "${workspaceFolder}/tools/mypy_wrapper.py"
    ]
  }
  ```

- As a result, `git clean -fdx; tools/vscode_settings.py` still results in some loss of useful configuration.

One other thing to note: as `.vscode/settings_recommended.json` shows, there are some configuration sections that only take effect within the context of a `"[language]"`, so currently, if a dev already has one of those settings, it would be entirely overwritten by `tools/vscode_settings.py` rather than a graceful merge. This could probably be fixed by using a deep merge instead of the current shallow merge strategy.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/57671

Test Plan:
If you want, you can typecheck the small script added by this PR (no output is expected):
```sh
tools/mypy_wrapper.py $PWD/tools/vscode_settings.py
```
You can also try running it to update your own VS Code workspace settings:
```sh
tools/vscode_settings.py
```
This should have minimal impact on your existing `tools/settings.json` file other than enabling the few explicitly recommended settings (e.g. it should not reorder or remove any of your existing settings).

Reviewed By: malfet

Differential Revision: D28230390

Pulled By: samestep

fbshipit-source-id: 53a7907229e5807c77531cae4f9ab9d469fd7684
2021-05-05 15:19:59 -07:00
..
amd_build [ROCm] rename HIP_HCC_FLAGS to HIP_CLANG_FLAGS (#50917) 2021-01-22 07:24:05 -08:00
autograd Make torch.linalg.eigvalsh differentiable (#57189) 2021-05-05 13:12:18 -07:00
clang_format_hash [tools] Remove newline from clang-format reference hashes (#55328) 2021-04-06 17:17:19 -07:00
code_analyzer [CUDA graphs] [BC-breaking] Makes torch.cuda.amp.GradScaler scale updates in-place for better composability with graph capture (#55562) 2021-04-30 13:03:05 -07:00
code_coverage [reland] Report test time regressions (#50171) 2021-02-08 15:35:21 -08:00
codegen Support auto generation of device check (#56872) 2021-05-01 12:02:09 -07:00
config
coverage_plugins_package Name .coverage.jit with timestamp to prevent loss of stats (#56829) 2021-04-26 08:43:17 -07:00
docker Forbid trailing whitespace (#53406) 2021-03-05 17:22:55 -08:00
fast_nvcc Use .gv instead of .dot for Graphviz in fast_nvcc (#53208) 2021-03-03 15:01:21 -08:00
gdb Fix Flake8 (#54540) 2021-03-23 13:50:03 -07:00
jit Remove generated_unboxing_wrappers and setManuallyBoxedKernel (#49251) 2021-01-06 14:22:50 -08:00
lite_interpreter Un-ignore F403 in .flake8 (#55838) 2021-04-13 09:24:07 -07:00
pyi torch.clamp with tensor min and max (#52695) 2021-05-03 12:56:16 -07:00
rules [codemod][fbcode][1/n] Apply buildifier 2021-04-12 11:04:32 -07:00
setup_helpers Remove distutils (#57040) 2021-04-29 12:10:11 -07:00
shared matches_jit_signatures is dead (#53637) 2021-04-15 12:31:19 -07:00
stats_utils fix boto3 resource not close (#55082) 2021-03-31 16:49:15 -07:00
test Add quicklint make target (#56559) 2021-04-21 13:47:25 -07:00
__init__.py
actions_local_runner.py Local lint fixes - missing steps, pin to bash (#56752) 2021-04-23 13:10:14 -07:00
build_libtorch.py
build_pytorch_libs.py Remove distutils (#57040) 2021-04-29 12:10:11 -07:00
build_variables.bzl [PyTorch][Edge] Add api to get bytecode model version (#56801) 2021-05-05 09:17:26 -07:00
clang_format_all.py [PyTorch] Autoformat c10 (#56830) 2021-04-30 21:23:28 -07:00
clang_format_ci.sh [PyTorch] Autoformat c10 (#56830) 2021-04-30 21:23:28 -07:00
clang_format_utils.py [tools] Remove newline from clang-format reference hashes (#55328) 2021-04-06 17:17:19 -07:00
clang_tidy.py Fix clang-tidy for native CPU ops (#57037) 2021-04-27 18:56:47 -07:00
download_mnist.py
export_slow_tests.py Sort slow tests json by test name (#55862) 2021-04-12 20:08:56 -07:00
extract_scripts.py Harden "Add annotations" workflow (#56071) 2021-04-16 07:46:20 -07:00
flake8_hook.py
generate_torch_version.py Remove distutils (#57040) 2021-04-29 12:10:11 -07:00
generated_dirs.txt
git-clang-format
git-pre-commit
git_add_generated_dirs.sh
git_reset_generated_dirs.sh
mypy_wrapper.py Use mypy internals instead of fnmatch for mypy wrapper (#55702) 2021-04-12 11:30:16 -07:00
nightly.py Add lint for unqualified type: ignore (#56290) 2021-04-21 08:07:23 -07:00
print_test_stats.py Actually report mac stats (#57511) 2021-05-03 18:35:30 -07:00
pytorch.version
README.md Share VS Code settings/extensions nicely (#57671) 2021-05-05 15:19:59 -07:00
render_junit.py Speedup render_junit (#57641) 2021-05-05 09:45:47 -07:00
run_shellcheck.sh Run ShellCheck on scripts in GitHub Actions workflows (#55486) 2021-04-08 13:15:00 -07:00
test_history.py Clarify tools/test_history.py output for re-runs (#55106) 2021-03-31 14:54:38 -07:00
trailing_newlines.py Lint trailing newlines (#54737) 2021-03-30 13:09:52 -07:00
translate_annotations.py Translate annotation line numbers from merge to head (#55569) 2021-04-09 11:12:40 -07:00
vscode_settings.py Share VS Code settings/extensions nicely (#57671) 2021-05-05 15:19:59 -07:00

This folder contains a number of scripts which are used as part of the PyTorch build process. This directory also doubles as a Python module hierarchy (thus the __init__.py).

Overview

Modern infrastructure:

  • autograd - Code generation for autograd. This includes definitions of all our derivatives.
  • jit - Code generation for JIT
  • shared - Generic infrastructure that scripts in tools may find useful.
    • module_loader.py - Makes it easier to import arbitrary Python files in a script, without having to add them to the PYTHONPATH first.

Legacy infrastructure (we should kill this):

  • cwrap - Implementation of legacy code generation for THNN/THCUNN. This is used by nnwrap.

Build system pieces:

  • setup_helpers - Helper code for searching for third-party dependencies on the user system.
  • build_pytorch_libs.py - cross-platform script that builds all of the constituent libraries of PyTorch, but not the PyTorch Python extension itself.
  • build_libtorch.py - Script for building libtorch, a standalone C++ library without Python support. This build script is tested in CI.
  • fast_nvcc - Mostly-transparent wrapper over nvcc that parallelizes compilation when used to build CUDA files for multiple architectures at once.
    • fast_nvcc.py - Python script, entrypoint to the fast nvcc wrapper.

Developer tools which you might find useful:

  • clang_tidy.py - Script for running clang-tidy on lines of your script which you changed.
  • extract_scripts.py - Extract scripts from .github/workflows/*.yml into a specified dir, on which linters such as run_shellcheck.sh can be run. Assumes that every run script has shell: bash unless a different shell is explicitly listed on that specific step (so defaults doesn't currently work), but also has some rules for other situations such as actions/github-script. Exits with nonzero status if any of the extracted scripts contain GitHub Actions expressions: ${{<expression> }}
  • git_add_generated_dirs.sh and git_reset_generated_dirs.sh - Use this to force add generated files to your Git index, so that you can conveniently run diffs on them when working on code-generation. (See also generated_dirs.txt which specifies the list of directories with generated files.)
  • mypy_wrapper.py - Run mypy on a single file using the appropriate subset of our mypy*.ini configs.
  • run_shellcheck.sh - Find *.sh files (recursively) in the directories specified as arguments, and run ShellCheck on all of them.
  • test_history.py - Query S3 to display history of a single test across multiple jobs over time.
  • trailing_newlines.py - Take names of UTF-8 files from stdin, print names of nonempty files whose contents don't end in exactly one trailing newline, exit with status 1 if no output printed or 0 if some filenames were printed.
  • translate_annotations.py - Read Flake8 or clang-tidy warnings (according to a --regex) from a --file, convert to the JSON format accepted by pytorch/add-annotations-github-action, and translate line numbers from HEAD back in time to the given --commit by running git diff-index --unified=0 appropriately.
  • vscode_settings.py - Merge .vscode/settings_recommended.json into your workspace-local .vscode/settings.json, preferring the former in case of conflicts but otherwise preserving the latter as much as possible.

Important if you want to run on AMD GPU:

  • amd_build - HIPify scripts, for transpiling CUDA into AMD HIP. Right now, PyTorch and Caffe2 share logic for how to do this transpilation, but have separate entry-points for transpiling either PyTorch or Caffe2 code.
    • build_amd.py - Top-level entry point for HIPifying our codebase.

Tools which are only situationally useful: