pytorch/tools
Brian Hirsh 77f98ea5e0 assert no duplicate yaml keys in codegen (#66238)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/66238

The codegen should error if it sees two yaml entries with the same key. The default behavior of python's yaml loader is to overwrite duplicate keys with the new value.

This would have caught a nasty bug that showed up in https://github.com/pytorch/pytorch/pull/66225/files#r723796194.

I tested it on that linked PR, to confirm that it errors correctly (and gives the line number containing the duplicate).

Test Plan: Imported from OSS

Reviewed By: dagitses, albanD, sean-ngo

Differential Revision: D31464585

Pulled By: bdhirsh

fbshipit-source-id: 5b35157ffa9a933bf4b344c4b9fe2878698370a3
2021-10-14 08:28:20 -07:00
..
amd_build Kill THCUNN (#63429) 2021-08-23 12:07:16 -07:00
autograd Autograd: Delay warnings until the end of backward execution (#66235) 2021-10-13 15:38:04 -07:00
clang_format_hash
code_analyzer [PyTorch Edge][tracing-based] use operator.yaml to build libtorch library (#66237) 2021-10-10 14:07:01 -07:00
code_coverage [codemod][lint][caffe2] Extend BLACK coverage 2021-08-13 09:28:10 -07:00
codegen assert no duplicate yaml keys in codegen (#66238) 2021-10-14 08:28:20 -07:00
config [bazel] GPU-support: add @local_config_cuda and @cuda (#63604) 2021-08-27 09:33:42 -07:00
coverage_plugins_package
fast_nvcc
gdb
jit
linter Skip interactive_embedded_interpreter.cpp for clang-tidy (#66569) 2021-10-13 13:27:56 -07:00
lite_interpreter [easy] [PyTorch Edge] Remove double pragma once directive in the generated code (#65620) 2021-09-24 13:14:37 -07:00
lldb [torch deploy] add support for Python C extension modules (#58117) 2021-07-23 19:58:54 -07:00
pyi [oss][pytorch] Add quint2x4 dtype (#65545) 2021-10-06 14:22:00 -07:00
rules [codemod][fbcode/caffe2] Apply all buildifier fixes 2021-09-23 14:03:19 -07:00
setup_helpers Make permission errors more human readable (#66492) 2021-10-12 18:31:24 -07:00
shared
stats Upload test failures to RDS (#65873) 2021-10-01 16:25:51 -07:00
test Fix Windows ninja builds when MAX_JOBS is specified (#65444) 2021-09-22 14:04:31 -07:00
testing [Dist/CI] Remove dist from target determinator (#64721) 2021-09-09 12:07:43 -07:00
__init__.py
actions_local_runner.py Update progress and error reporting in clang-tidy (#61672) 2021-07-19 11:19:06 -07:00
build_libtorch.py enable increment build for build_libtorch (#63074) 2021-08-20 16:30:34 -07:00
build_pytorch_libs.py
build_variables.bzl Autograd: Delay warnings until the end of backward execution (#66235) 2021-10-13 15:38:04 -07:00
download_mnist.py Fix ConnectionError in download_mnist (#61789) 2021-07-16 17:02:13 -07:00
extract_scripts.py
generate_torch_version.py Update version.txt file path (#61177) 2021-07-12 07:30:10 -07:00
generated_dirs.txt
git-pre-commit Fix clang-tidy error in pre-commit script (#61918) 2021-07-20 12:40:56 -07:00
git_add_generated_dirs.sh
git_reset_generated_dirs.sh
nightly.py Fix type annotation in tools/nightly.py (#64202) 2021-08-30 13:27:43 -07:00
nvcc_fix_deps.py Add workaround for nvcc header dependecies bug (#62550) 2021-10-11 09:07:12 -07:00
pytorch.version
README.md Kill THCUNN (#63429) 2021-08-23 12:07:16 -07:00
render_junit.py
vscode_settings.py

This folder contains a number of scripts which are used as part of the PyTorch build process. This directory also doubles as a Python module hierarchy (thus the __init__.py).

Overview

Modern infrastructure:

  • autograd - Code generation for autograd. This includes definitions of all our derivatives.
  • jit - Code generation for JIT
  • shared - Generic infrastructure that scripts in tools may find useful.
    • module_loader.py - Makes it easier to import arbitrary Python files in a script, without having to add them to the PYTHONPATH first.

Build system pieces:

  • setup_helpers - Helper code for searching for third-party dependencies on the user system.
  • build_pytorch_libs.py - cross-platform script that builds all of the constituent libraries of PyTorch, but not the PyTorch Python extension itself.
  • build_libtorch.py - Script for building libtorch, a standalone C++ library without Python support. This build script is tested in CI.
  • fast_nvcc - Mostly-transparent wrapper over nvcc that parallelizes compilation when used to build CUDA files for multiple architectures at once.
    • fast_nvcc.py - Python script, entrypoint to the fast nvcc wrapper.

Developer tools which you might find useful:

  • linter/clang_tidy - Script for running clang-tidy on lines of your script which you changed.
  • extract_scripts.py - Extract scripts from .github/workflows/*.yml into a specified dir, on which linters such as linter/run_shellcheck.sh can be run. Assumes that every run script has shell: bash unless a different shell is explicitly listed on that specific step (so defaults doesn't currently work), but also has some rules for other situations such as actions/github-script. Exits with nonzero status if any of the extracted scripts contain GitHub Actions expressions: ${{<expression> }}
  • git_add_generated_dirs.sh and git_reset_generated_dirs.sh - Use this to force add generated files to your Git index, so that you can conveniently run diffs on them when working on code-generation. (See also generated_dirs.txt which specifies the list of directories with generated files.)
  • linter/mypy_wrapper.py - Run mypy on a single file using the appropriate subset of our mypy*.ini configs.
  • linter/run_shellcheck.sh - Find *.sh files (recursively) in the directories specified as arguments, and run ShellCheck on all of them.
  • stats/test_history.py - Query S3 to display history of a single test across multiple jobs over time.
  • linter/trailing_newlines.py - Take names of UTF-8 files from stdin, print names of nonempty files whose contents don't end in exactly one trailing newline, exit with status 1 if no output printed or 0 if some filenames were printed.
  • linter/translate_annotations.py - Read Flake8 or clang-tidy warnings (according to a --regex) from a --file, convert to the JSON format accepted by pytorch/add-annotations-github-action, and translate line numbers from HEAD back in time to the given --commit by running git diff-index --unified=0 appropriately.
  • vscode_settings.py - Merge .vscode/settings_recommended.json into your workspace-local .vscode/settings.json, preferring the former in case of conflicts but otherwise preserving the latter as much as possible.

Important if you want to run on AMD GPU:

  • amd_build - HIPify scripts, for transpiling CUDA into AMD HIP. Right now, PyTorch and Caffe2 share logic for how to do this transpilation, but have separate entry-points for transpiling either PyTorch or Caffe2 code.
    • build_amd.py - Top-level entry point for HIPifying our codebase.

Tools which are only situationally useful: