mirror of
https://github.com/saymrwulf/pytorch.git
synced 2026-05-14 20:57:59 +00:00
483f748dd5
This PR enables `-Winconsistent-missing-destructor-override` and `-Winconsistent-missing-override` and fixes violations. <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 47e904e</samp> This pull request updates the code of various classes and operators in the `caffe2` and `aten` subdirectories to use the `override` specifier instead of the `virtual` keyword for destructors and other virtual functions that override a base class function. This improves the code readability, quality, and consistency with C++ best practices. It also modifies the `./CMakeLists.txt` file to enable warnings for these specifiers, but disable errors. Pull Request resolved: https://github.com/pytorch/pytorch/pull/104032 Approved by: https://github.com/malfet
37 lines
972 B
C++
37 lines
972 B
C++
#ifndef BATCHPERMUTATION_OP_H_
|
|
#define BATCHPERMUTATION_OP_H_
|
|
|
|
#include "caffe2/core/context.h"
|
|
#include "caffe2/core/export_caffe2_op_to_c10.h"
|
|
#include "caffe2/core/logging.h"
|
|
#include "caffe2/core/operator.h"
|
|
#include "caffe2/utils/math.h"
|
|
|
|
C10_DECLARE_EXPORT_CAFFE2_OP_TO_C10(BatchPermutation)
|
|
|
|
namespace caffe2 {
|
|
|
|
template <typename T, class Context>
|
|
class BatchPermutationOp final : public Operator<Context> {
|
|
public:
|
|
template <class... Args>
|
|
explicit BatchPermutationOp(Args&&... args)
|
|
: Operator<Context>(std::forward<Args>(args)...) {}
|
|
USE_OPERATOR_CONTEXT_FUNCTIONS;
|
|
|
|
bool RunOnDevice() override;
|
|
};
|
|
|
|
template <typename T, class Context>
|
|
class BatchPermutationGradientOp final : public Operator<Context> {
|
|
public:
|
|
BatchPermutationGradientOp(const OperatorDef& def, Workspace* ws)
|
|
: Operator<Context>(def, ws) {}
|
|
USE_OPERATOR_CONTEXT_FUNCTIONS;
|
|
|
|
bool RunOnDevice() override;
|
|
};
|
|
|
|
} // namespace caffe2
|
|
|
|
#endif // BATCHPERMUTATION_OP_H_
|