c56464d13e
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/24331 Currently our logs are something like 40M a pop. Turning off warnings and turning on verbose makefiles (to see the compile commands) reduces this to more like 8M. We could probably reduce log size more but verbose makefile is really useful and we'll keep it turned on for Windows. Some findings: 1. Setting `CMAKE_VERBOSE_MAKEFILE` inside CMakelists.txt itself as suggested in https://github.com/ninja-build/ninja/issues/900#issuecomment-417917630 does not work on Windows. Setting `-DCMAKE_VERBOSE_MAKEFILE=1` does work (and we respect this environment variable.) 2. The high (`/W3`) warning level is by default on MSVC is due to cmake inserting this in the default flags. On recent versions of cmake, CMP0092 can be used to disable this flag in the default set. The string replace trick sort of works, but the standard snippet you'll find on the internet won't disable the flag from nvcc. I inspected the CUDA cmake code and verified it does respect CMP0092 3. `EHsc` is also in the default flags; this one cannot be suppressed via a policy. The string replace trick seems to work... 4. ... however, it seems nvcc implicitly inserts an `/EHs` after `-Xcompiler` specified flags, which means that if we add `/EHa` to our set of flags, you'll get a warning from nvcc. So we probably have to figure out how to exclude EHa from the nvcc flags set (EHs does seem to work fine.) 5. To suppress warnings in nvcc, you must BOTH pass `-w` and `-Xcompiler /w`. Individually these are not enough. The patch applies these things; it also fixes a bug where nvcc verbose command printing doesn't work with `-GNinja`. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D17131746 Pulled By: ezyang fbshipit-source-id: fb142f8677072a5430664b28155373088f074c4b |
||
|---|---|---|
| .. | ||
| upstream | ||
| FindCUDA.cmake | ||
| FindCUDNN.cmake | ||
| README.md | ||
This ./upstream subfolder contains fixes for FindCUDA that are introduced in
later versions of cmake but cause generator expression errors in earlier CMake
versions. Specifically:
-
a problem where a generator expression for include directories was passed to NVCC, where the generator expression itself was prefixed by
-I. As the NNPACK include directory generator expression expands to multiple directories, the second and later ones were not prefixed by-I, causing NVCC to return an error. First fixed in CMake 3.7 (see Kitware/CMake@7ded655f). -
Windows VS2017 fixes that allows one to define the ccbin path differently between earlier versions of Visual Studio and VS2017. First introduced after 3.10.1 master version (see Kitware/CMake@bc88329e).
The downside of using these fixes is that ./upstream/CMakeInitializeConfigs.cmake,
defining some new CMake variables (added in
Kitware/CMake@48f7e2d3),
must be included before ./upstream/FindCUDA.cmake to support older CMake
versions. A wrapper ./FindCUDA.cmake is created to do this automatically, and
to allow submodules to use these fixes because we can't patch their
CMakeList.txt.
If you need to update files under ./upstream folder, we recommend you issue PRs
against the CMake mainline branch,
and then backport it here for earlier CMake compatibility.