mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00

History

Aaron Orenstein 07669ed960 PEP585 update - benchmarks tools torchgen (#145101 ) This is one of a series of PRs to update us to PEP585 (changing Dict -> dict, List -> list, etc). Most of the PRs were completely automated with RUFF as follows: Since RUFF UP006 is considered an "unsafe" fix first we need to enable unsafe fixes: ``` --- a/tools/linter/adapters/ruff_linter.py +++ b/tools/linter/adapters/ruff_linter.py @@ -313,6 +313,7 @@ "ruff", "check", "--fix-only", + "--unsafe-fixes", "--exit-zero", *([f"--config={config}"] if config else []), "--stdin-filename", ``` Then we need to tell RUFF to allow UP006 (as a final PR once all of these have landed this will be made permanent): ``` --- a/pyproject.toml +++ b/pyproject.toml @@ -40,7 +40,7 @@ [tool.ruff] -target-version = "py38" +target-version = "py39" line-length = 88 src = ["caffe2", "torch", "torchgen", "functorch", "test"] @@ -87,7 +87,6 @@ "SIM116", # Disable Use a dictionary instead of consecutive `if` statements "SIM117", "SIM118", - "UP006", # keep-runtime-typing "UP007", # keep-runtime-typing ] select = [ ``` Finally running `lintrunner -a --take RUFF` will fix up the deprecated uses. Pull Request resolved: https://github.com/pytorch/pytorch/pull/145101 Approved by: https://github.com/bobrenjc93		2025-01-18 05:05:07 +00:00
..
__init__.py
check_disabled_tests.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00
export_test_times.py	Revert "Use absolute path `path.resolve()` -> `path.absolute()` (#129409 )"	2025-01-04 14:17:20 +00:00
import_test_stats.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00
monitor.py	[Utilization Log] Concurrently collect aggregate data during the output interval (#143235 )	2025-01-16 23:52:43 +00:00
README.md
sccache_stats_to_benchmark_format.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00
test_dashboard.py	Upload all run attempts when in upload_test_stats_intermediate (#140459 )	2024-11-18 21:40:10 +00:00
upload_artifacts.py	Revert "Use absolute path `path.resolve()` -> `path.absolute()` (#129409 )"	2025-01-04 14:17:20 +00:00
upload_dynamo_perf_stats.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00
upload_external_contrib_stats.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00
upload_metrics.py
upload_sccache_stats.py
upload_stats_lib.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00
upload_test_stats.py	Fix flaky "Upload test stats" job (#143991 )	2024-12-30 21:40:01 +00:00
upload_test_stats_intermediate.py	Upload all run attempts when in upload_test_stats_intermediate (#140459 )	2024-11-18 21:40:10 +00:00
upload_test_stats_running_jobs.py	PEP585 update - benchmarks tools torchgen (#145101 )	2025-01-18 05:05:07 +00:00

README.md

PyTorch CI Stats

We track various stats about each CI job.

Jobs upload their artifacts to an intermediate data store (either GitHub Actions artifacts or S3, depending on what permissions the job has). Example: a9f6a35a33/.github/workflows/_linux-build.yml (L144-L151)
When a workflow completes, a workflow_run event triggers upload-test-stats.yml.
upload-test-stats downloads the raw stats from the intermediate data store and uploads them as JSON to s3, which then uploads to our database backend

graph LR
    J1[Job with AWS creds<br>e.g. linux, win] --raw stats--> S3[(AWS S3)]
    J2[Job w/o AWS creds<br>e.g. mac] --raw stats--> GHA[(GH artifacts)]

    S3 --> uts[upload-test-stats.yml]
    GHA --> uts

    uts --json--> s3[(s3)]
    s3 --> DB[(database)]

Why this weird indirection? Because writing to the database requires special permissions which, for security reasons, we do not want to give to pull request CI. Instead, we implemented GitHub's recommended pattern for cases like this.

For more details about what stats we export, check out upload-test-stats.yml