mirror of
https://github.com/saymrwulf/pytorch.git
synced 2026-05-15 21:00:47 +00:00
9470059766
Allow `viable/strict` promotion even if `periodic` or `docker-release-builds` jobs are failing **Why?** Those jobs only run occasionally and for all we know the current viable/strict commit may already include the errors that the above cron based workflows may have later detected. Blocking the viable/strict upgrade because of these scheduled jobs doesn't really offer any value, it just leads to people getting older PRs when they try to fork off of viable/strict without guaranteeing an improvement in test quality Though frankly, the current situation is worse than that. Assume the branch history looks like A -> B A is the current `viable/strict` commit B is a commit that failed some `periodic` test, so `viable/strict` wasn't upgraded to B Now lets say there's a commit C that gets merged. C neither contains a fix for the failing periodic build, nor does a scheduled periodic workflow run against C. The branch becomes A -> B -> C In the above scenario, today we will promote `viable/strict` to C since there was no failing workflow there!!! Even though it didn't actually fix what was broken with B! In short, avoiding the upgrade to B really doesn't make any sense today and we shouldn't do it. Pull Request resolved: https://github.com/pytorch/pytorch/pull/86827 Approved by: https://github.com/janeyx99
121 lines
3.4 KiB
Python
121 lines
3.4 KiB
Python
import sys
|
|
from typing import Any, Dict, List, NamedTuple, Tuple
|
|
from gitutils import _check_output
|
|
|
|
import rockset # type: ignore[import]
|
|
import os
|
|
import re
|
|
|
|
def eprint(msg: str) -> None:
|
|
print(msg, file=sys.stderr)
|
|
|
|
class WorkflowCheck(NamedTuple):
|
|
workflowName: str
|
|
name: str
|
|
jobName: str
|
|
conclusion: str
|
|
|
|
def get_latest_commits() -> List[str]:
|
|
latest_viable_commit = _check_output(
|
|
[
|
|
"git",
|
|
"log",
|
|
"-n",
|
|
"1",
|
|
"--pretty=format:%H",
|
|
"origin/viable/strict",
|
|
],
|
|
encoding="ascii",
|
|
)
|
|
commits = _check_output(
|
|
[
|
|
"git",
|
|
"rev-list",
|
|
f"{latest_viable_commit}^..HEAD",
|
|
"--remotes=*origin/master",
|
|
],
|
|
encoding="ascii",
|
|
).splitlines()
|
|
|
|
return commits
|
|
|
|
def query_commits(commits: List[str], qlambda: Any) -> Any:
|
|
params = rockset.ParamDict()
|
|
params['shas'] = ",".join(commits)
|
|
results = qlambda.execute(parameters=params)
|
|
|
|
return results
|
|
|
|
def print_commit_status(commit: str, results: Dict[str, Any]) -> None:
|
|
print(commit)
|
|
for check in results['results']:
|
|
if check['sha'] == commit:
|
|
print(f"\t{check['conclusion']:>10}: {check['name']}")
|
|
|
|
def get_commit_results(commit: str, results: Dict[str, Any]) -> List[Dict[str, Any]]:
|
|
workflow_checks = []
|
|
for check in results['results']:
|
|
if check['sha'] == commit:
|
|
workflow_checks.append(WorkflowCheck(
|
|
workflowName=check['workflowName'],
|
|
name=check['name'],
|
|
jobName=check['jobName'],
|
|
conclusion=check['conclusion'],
|
|
)._asdict())
|
|
return workflow_checks
|
|
|
|
def isGreen(commit: str, results: Dict[str, Any]) -> Tuple[bool, str]:
|
|
workflow_checks = get_commit_results(commit, results)
|
|
|
|
regex = {
|
|
"pull": False,
|
|
"trunk": False,
|
|
"lint": False,
|
|
"linux-binary": False,
|
|
"windows-binary": False,
|
|
}
|
|
|
|
for check in workflow_checks:
|
|
workflowName = check['workflowName']
|
|
conclusion = check['conclusion']
|
|
for required_check in regex:
|
|
if re.match(required_check, workflowName, flags=re.IGNORECASE):
|
|
if conclusion not in ["success", "skipped"]:
|
|
return (False, workflowName + " checks were not successful")
|
|
else:
|
|
regex[required_check] = True
|
|
|
|
missing_workflows = [x for x in regex.keys() if not regex[x]]
|
|
if len(missing_workflows) > 0:
|
|
return (False, "missing required workflows: " + ", ".join(missing_workflows))
|
|
|
|
return (True, "")
|
|
|
|
def get_latest_green_commit(commits: List[str], results: Dict[str, Any]) -> Any:
|
|
for commit in commits:
|
|
eprint(f"Checking {commit}")
|
|
is_green, msg = isGreen(commit, results)
|
|
if is_green:
|
|
eprint("GREEN")
|
|
return commit
|
|
else:
|
|
eprint("RED: " + msg)
|
|
return None
|
|
|
|
def main() -> None:
|
|
rs = rockset.Client(
|
|
api_server="api.rs2.usw2.rockset.com", api_key=os.environ["ROCKSET_API_KEY"]
|
|
)
|
|
qlambda = rs.QueryLambda.retrieve(
|
|
'commit_jobs_batch_query',
|
|
version='8003fdfd18b64696',
|
|
workspace='commons')
|
|
|
|
commits = get_latest_commits()
|
|
results = query_commits(commits, qlambda)
|
|
|
|
latest_viable_commit = get_latest_green_commit(commits, results)
|
|
print(latest_viable_commit)
|
|
|
|
if __name__ == "__main__":
|
|
main()
|