mirror of
https://github.com/saymrwulf/pytorch.git
synced 2026-05-14 20:57:59 +00:00
41e36e2b46
Fixes the workflow when meta-exported diff (co-dev) doesn't have the required labels, but the signal is suppressed due to job failure (e.g. [see this run](https://github.com/pytorch/pytorch/actions/runs/10590994706/job/29347663526?pr=134484)). With this change the workflow status correctly reflects the status of the check. # Testing * [illegal pr_num](https://github.com/pytorch/pytorch/actions/runs/10603163898/job/29386843591) * [successful run](https://github.com/pytorch/pytorch/actions/runs/10603279052/job/29387230110) (topic label present) * no labels: [check fails](https://github.com/pytorch/pytorch/actions/runs/10603310368/job/29387333864) Pull Request resolved: https://github.com/pytorch/pytorch/pull/134711 Approved by: https://github.com/clee2000
62 lines
1.8 KiB
Python
Executable file
62 lines
1.8 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
"""Check whether a PR has required labels."""
|
|
|
|
import sys
|
|
from typing import Any
|
|
|
|
from github_utils import gh_delete_comment, gh_post_pr_comment
|
|
from gitutils import get_git_remote_name, get_git_repo_dir, GitRepo
|
|
from label_utils import has_required_labels, is_label_err_comment, LABEL_ERR_MSG
|
|
from trymerge import GitHubPR
|
|
|
|
|
|
def delete_all_label_err_comments(pr: "GitHubPR") -> None:
|
|
for comment in pr.get_comments():
|
|
if is_label_err_comment(comment):
|
|
gh_delete_comment(pr.org, pr.project, comment.database_id)
|
|
|
|
|
|
def add_label_err_comment(pr: "GitHubPR") -> None:
|
|
# Only make a comment if one doesn't exist already
|
|
if not any(is_label_err_comment(comment) for comment in pr.get_comments()):
|
|
gh_post_pr_comment(pr.org, pr.project, pr.pr_num, LABEL_ERR_MSG)
|
|
|
|
|
|
def parse_args() -> Any:
|
|
from argparse import ArgumentParser
|
|
|
|
parser = ArgumentParser("Check PR labels")
|
|
parser.add_argument("pr_num", type=int)
|
|
# add a flag to return a non-zero exit code if the PR does not have the required labels
|
|
parser.add_argument(
|
|
"--exit-non-zero",
|
|
action="store_true",
|
|
help="Return a non-zero exit code if the PR does not have the required labels",
|
|
)
|
|
|
|
return parser.parse_args()
|
|
|
|
|
|
def main() -> None:
|
|
args = parse_args()
|
|
repo = GitRepo(get_git_repo_dir(), get_git_remote_name())
|
|
org, project = repo.gh_owner_and_name()
|
|
pr = GitHubPR(org, project, args.pr_num)
|
|
|
|
try:
|
|
if not has_required_labels(pr):
|
|
print(LABEL_ERR_MSG)
|
|
add_label_err_comment(pr)
|
|
if args.exit_non_zero:
|
|
sys.exit(1)
|
|
else:
|
|
delete_all_label_err_comments(pr)
|
|
except Exception as e:
|
|
if args.exit_non_zero:
|
|
sys.exit(1)
|
|
|
|
sys.exit(0)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|