Commit graph

6 commits

Author SHA1 Message Date
cyy
806f22b167 find backtrace by cmake module (#36017)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/36017

Reviewed By: zou3519, albanD

Differential Revision: D20870233

Pulled By: ezyang

fbshipit-source-id: b11daf22a900e47b5b72272fb2f096d78c075bf8
2020-04-21 16:00:33 -07:00
Xiang Gao
15c7486416 Canonicalize includes in c10, and add tests for it (#36299)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/36299

Test Plan: Imported from OSS

Differential Revision: D20943005

Pulled By: ezyang

fbshipit-source-id: 9dd0a58824bd0f1b5ad259942f92954ba1f63eae
2020-04-10 12:07:52 -07:00
peter
5061ef63f4 Revert "Revert D20885968: [pytorch][PR] Enable backtrace with MSVC" (#36205)
Summary:
This reverts commit 8afa001d89 and made a few improvements including the following items.
1. return `std::string` for `get_module_base_name`
2. eliminate `module should always be true` warning
3. do `SymInitialize` and `SymCleanup` once to save time
Pull Request resolved: https://github.com/pytorch/pytorch/pull/36205

Reviewed By: malfet

Differential Revision: D20919672

Pulled By: ezyang

fbshipit-source-id: 0063a478779feb106459af48063485ef676008a5
2020-04-09 09:48:41 -07:00
Edward Yang
8afa001d89 Revert D20885968: [pytorch][PR] Enable backtrace with MSVC
Test Plan: revert-hammer

Differential Revision:
D20885968

Original commit changeset: 6ad3822af31e

fbshipit-source-id: 468199cae2178b17b7ff63114e274b6844eecb7f
2020-04-07 12:10:45 -07:00
peter
7e84a30ad6 Enable backtrace with MSVC (#36039)
Summary:
Make it possible to report the C++ exceptions in console.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/36039

Differential Revision: D20885968

Pulled By: ezyang

fbshipit-source-id: 6ad3822af31e5a64c4a93f16627fbefb7750e1c8
2020-04-07 07:25:12 -07:00
Yangqing Jia
713e706618 Move exception to C10 (#12354)
Summary:
There are still a few work to be done:

- Move logging and unify AT_WARN with LOG(ERROR).
- A few header files are still being plumbed through, need cleaning.
- caffe2::EnforceNotMet aliasing is not done yet.
- need to unify the macros. See c10/util/Exception.h

This is mainly a codemod and not causing functional changes. If you find your job failing and trace back to this diff, usually it can be fixed by the following approaches:

(1) add //caffe2/c10:c10 to your dependency (or transitive dependency).
(2) change objects such as at::Error, at::Optional to the c10 namespace.
(3) change functions to the c10 namespace. Especially, caffe2::MakeString is not overridden by the unified c10::str function. Nothing else changes.

Please kindly consider not reverting this diff - it involves multiple rounds of rebasing and the fix is usually simple. Contact jiayq@ or AI Platform Dev for details.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/12354

Reviewed By: orionr

Differential Revision: D10238910

Pulled By: Yangqing

fbshipit-source-id: 7794d5bf2797ab0ca6ebaccaa2f7ebbd50ff8f32
2018-10-15 13:33:18 -07:00
Renamed from aten/src/ATen/core/Backtrace.cpp (Browse further)