Commit graph

25 commits

Author SHA1 Message Date
zhouzhuojie
7756cb6a5b Migrate pytorch_python_doc_build to github action (#57371)
Summary:
# Changes

This PR migrates `pytorch_python_doc_build` from circleci to github actions.

Noticeable changes
- Refactor `docker cp` into a single `docker run` with volume mount, because the in circleci volume is not accessible from its remote docker engine
- `pytorch_python_doc_push` job will have a race condition with circleci, which will be migrated in separate PRs

Pull Request resolved: https://github.com/pytorch/pytorch/pull/57371

Reviewed By: samestep

Differential Revision: D28416289

Pulled By: zhouzhuojie

fbshipit-source-id: 04caccccf3d7eb7e2225846a406a53ccda356d44
2021-05-13 15:42:52 -07:00
Sam Estep
e1cbc43f50 Use tools/print_test_stats.py in GHA (#57647)
Summary:
Judging from https://github.com/pytorch/pytorch/issues/57584, it seems like the test-reports artifact was originally intended to be downloaded to `$PWD/test-reports` instead of just directly into `$PWD`. To minimize confusion, this PR changes it to download into `test/test-reports`, which should match where the files came from in the `test` step anyway.

TODOs:

- [x] change the extract path for test-reports
- [x] install Python dependencies
- [x] call `tools/print_test_stats.py`
- [x] use deep clone to allow `git` commands
- [x] correctly set `CIRCLE_*` environment variables
- [x] set Scribe credentials
- [x] set AWS credentials

Pull Request resolved: https://github.com/pytorch/pytorch/pull/57647

Test Plan: CI.

Reviewed By: seemethere

Differential Revision: D28325833

Pulled By: samestep

fbshipit-source-id: cc322bad76747f59b764a1a0a863153bb26095e7
2021-05-10 12:29:40 -07:00
Sam Estep
52d1b91d38 Give Python sub-version in GHA CUDA workflow name (#57770)
Summary:
Addresses part of https://github.com/pytorch/pytorch/issues/57686#issuecomment-833672132. Evidence that the Python version is indeed 3.6: https://github.com/pytorch/pytorch/runs/2520276328

Pull Request resolved: https://github.com/pytorch/pytorch/pull/57770

Test Plan: CI would be nice, but this workflow does not currently run on PRs.

Reviewed By: malfet

Differential Revision: D28265048

Pulled By: samestep

fbshipit-source-id: 513caf52a8f18d6e529e0934bf024f49e1571926
2021-05-06 15:16:37 -07:00
Xu Zhao
d68ad3cb1e Add a shortcut to test all torchbench models. (#57311)
Summary:
This PR adds a shortcut of specifying all models in TorchBench CI

Pull Request resolved: https://github.com/pytorch/pytorch/pull/57311

Test Plan:
CI

RUN_TORCHBENCH: ALL

Reviewed By: bitfort

Differential Revision: D28160198

Pulled By: xuzhao9

fbshipit-source-id: 67c292bc98868979d868d4cf1e599c38e0da94b5
2021-05-03 13:50:27 -07:00
Xu Zhao
c72f01ab6b Add CI workflow and script to test torchbench. (#56957)
Summary:
This PR adds TorchBench (pytorch/benchmark) CI workflow to pytorch. It tests PRs whose body contains a line staring with "RUN_TORCHBENCH: " followed by a list of torchbench model names. For example, this PR will create a Torchbench job of running pytorch_mobildnet_v3 and yolov3 model.

For security reasons, only the branch on pytorch/pytorch will run. It will not work on forked repositories.

The model names have to match the exact names in pytorch/benchmark/torchbenchmark/models, separated by comma symbol. Only the first line starting with "RUN_TORCHBENCH: " is respected. If nothing is specified after the magic word, no test will run.

Known issues:
1. Build PyTorch from scratch and do not reuse build artifacts from other workflows. This is because GHA migration is still in progress.
2. Currently there is only one worker, so jobs are serialized. We will review the capacity issue after this is deployed.
3. If the user would like to rerun the test, she has to push to the PR. Simply updating the PR body won't work.
4. Only supports environment CUDA 10.2 + python 3.7

RUN_TORCHBENCH: yolov3, pytorch_mobilenet_v3

Pull Request resolved: https://github.com/pytorch/pytorch/pull/56957

Reviewed By: janeyx99

Differential Revision: D28079077

Pulled By: xuzhao9

fbshipit-source-id: e9ea73bdd9f35e650b653009060d477b22174bba
2021-04-29 11:02:38 -07:00
Eli Uriegas
911852ffe2 .github: Only add @generated on generated workflows (#57063)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/57063

Removes the generated tag from the original template so the diff shows
up correctly on internal Phab

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: H-Huang

Differential Revision: D28040694

Pulled By: seemethere

fbshipit-source-id: c6ec0520fbc4ea169abefc7df2ff925ecc0474cc
2021-04-28 11:28:57 -07:00
Eli Uriegas
11d455fa8b .github: Enable Linux CPU GHA on PRs (#56942)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56942

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: walterddr

Differential Revision: D28018455

Pulled By: seemethere

fbshipit-source-id: 2b4ba3d616c217b4e960871f1428dda03f2ad92a
2021-04-27 09:16:33 -07:00
Eli Uriegas
b2b9efb33a .github: Add initial Linux CI for CUDA (#56494)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56494

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D27953781

Pulled By: seemethere

fbshipit-source-id: bce9298dc40d035bfbb5057e48b99d15c13733bc
2021-04-23 18:09:08 -07:00
Eli Uriegas
31677c5fcb [reland] .github: Add initial linux CI workflow (#56280)
Summary:
This reverts commit 6b5ed5ec45.

There'll also probably be fixes here, see diff from original PR: https://github.com/pytorch/pytorch/compare/f2abce0...ci-all/add-initial-linux-ci-gha

Pull Request resolved: https://github.com/pytorch/pytorch/pull/56280

Reviewed By: walterddr

Differential Revision: D27826012

Pulled By: seemethere

fbshipit-source-id: 71cad1d7f840ede5025b1bb4a33d628aa74686d1
2021-04-19 17:36:09 -07:00
Luca Wehrstedt
6b5ed5ec45 Revert D27803529: [pytorch][PR] .github: Add initial linux CI workflow
Test Plan: revert-hammer

Differential Revision:
D27803529 (7d410bc3c8)

Original commit changeset: 52a65ec8f7a8

fbshipit-source-id: ce968654f2aecd8b36b5f86e0fe5ed6056f0fb8a
2021-04-16 02:53:31 -07:00
Sam Estep
7d410bc3c8 .github: Add initial linux CI workflow (#55176)
Summary:
This is a commandeer of https://github.com/pytorch/pytorch/issues/54091.

TODO:

- [x] understand why the build is [failing](https://github.com/pytorch/pytorch/pull/55176/checks?check_run_id=2254742265) here when it was [succeeding](https://github.com/pytorch/pytorch/pull/54091/checks?check_run_id=2177844748) on https://github.com/pytorch/pytorch/issues/54091
- [x] fix the build failure
- [x] fix the test failure(s)
- [x] add CI check to generate YAML workflows from templates, similar to https://github.com/pytorch/pytorch/issues/55171
- [ ] uncomment the rest of the matrix

Pull Request resolved: https://github.com/pytorch/pytorch/pull/55176

Reviewed By: walterddr

Differential Revision: D27803529

Pulled By: seemethere

fbshipit-source-id: 52a65ec8f7a83b929fed47f0bbdca544210ec9c2
2021-04-15 16:54:04 -07:00
Jane Xu
a60dca8e80 Make the script generate cancel_redundant_workflows.yml (#56092)
Summary:
This way, the user would just have to run the `regenerate_cancel_redundant_workflow.py` script to fix the inconsistency (instead of manual stuff).

Lots of the indentation changes were caused by regenerating the file, which I don't think is terrible, and ruamel.yaml did great at preserving comments and order and such!

Pull Request resolved: https://github.com/pytorch/pytorch/pull/56092

Reviewed By: samestep

Differential Revision: D27780877

Pulled By: janeyx99

fbshipit-source-id: dd2996a88cd70a83d8daac33ba6659f93add8b92
2021-04-15 09:36:49 -07:00
Edward Yang
44e2c2cdfb Add a lint for native_functions.yaml (#56059)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56059

The lint doesn't do very much, mostly it enforces that indentation
is consistent.  The real point of the lint is to just make sure
that we can still do surgery on codemod with tools like ruamel,
by reusing the configuration in this script.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Reviewed By: walterddr

Differential Revision: D27774590

Pulled By: ezyang

fbshipit-source-id: c26bc6c95a478bd9b86387b18de7e906e7d13193
2021-04-14 15:20:29 -07:00
Eli Uriegas
50bd6a3640 ci: Remove CUDA 10.1 builds (#56056)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56056

Since internal systems as well as colab have updated beyond CUDA 10.1
I'd say it's safe to remove CUDA 10.1 builds entirely

As mentioned in https://github.com/pytorch/pytorch/issues/55829#issuecomment-818236019

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: walterddr

Differential Revision: D27772826

Pulled By: seemethere

fbshipit-source-id: 1599bba26b73b909b2575130219e2708ade5654c
2021-04-14 14:24:56 -07:00
Jane Xu
1127bab828 Make GHA for consistency cancel_redundant_workflow return useful err msg (#55961)
Summary:
This way, the user gets more useful actionable results from the GHA.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/55961

Test Plan: CI

Reviewed By: samestep

Differential Revision: D27749013

Pulled By: janeyx99

fbshipit-source-id: bb0edbcdab29ba8ef99005f6fcf52de6782b468d
2021-04-14 09:54:08 -07:00
Jane Xu
faa4da49ff Add code to ensure workflow consistency for autocanceling (#55171)
Summary:
Currently, we only have three GHA workflows that need to be canceled on reruns. To anticipate for future workflows, this PR enables a check that will make sure any new workflow that should be autocanceled on reruns will be included in the cancel_redundant_workflows.yml GHA workflow.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/55171

Test Plan: Succeeded quick-checks https://github.com/pytorch/pytorch/runs/2249162035?check_suite_focus=true

Reviewed By: samestep

Differential Revision: D27514294

Pulled By: janeyx99

fbshipit-source-id: 27da321f648b97a090052823ec955caffeb6ae97
2021-04-01 14:11:32 -07:00
Sam Estep
fa07d0c8eb .github: Add workflow to build libtorch (#53292)
Summary:
Based on https://github.com/pytorch/pytorch/issues/50633 and https://github.com/pytorch/pytorch/issues/51243.

Things left to do:

- [x] modify `.github/scripts/generate_binary_build_matrix.py` further
  - [x] add option for not iterating over Python version
  - [x] add `LIBTORCH_VARIANT`
  - [x] add option for cxx11
  - [x] fix the artifact uploading
  - [x] remove `pull_request` hook before merging

Pull Request resolved: https://github.com/pytorch/pytorch/pull/53292

Test Plan: [CI](https://github.com/pytorch/pytorch/actions/runs/665781075).

Reviewed By: seemethere

Differential Revision: D27189150

Pulled By: samestep

fbshipit-source-id: ec91e1f0b75b8c93613d55801585ed975697be03
2021-03-19 12:39:36 -07:00
Xu Zhao
7763bb6cb3 Use the conda channel defined in docker.Makefile to install cudatoolkit (#53316)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/53316

Test Plan:
Nightly Docker build CI

This is a follow-up PR after docker moved default CUDA => 11.1. Only merge this after https://github.com/pytorch/pytorch/issues/53299 is committed.

Reviewed By: albanD

Differential Revision: D26996287

Pulled By: xuzhao9

fbshipit-source-id: 0c2e03da41d036d7aada3e07d479a3dede219f58
2021-03-12 11:18:05 -08:00
Eli Uriegas
b8546bde09 ci: Remove special versioning privileges for cu102 (#53133)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/53133

In light of some issues where users were having trouble installing CUDA
specific versions of pytorch we should no longer have special privileges
for CUDA 10.2.

Recently I added scripts/release/promote/prep_binary_for_pypi.sh (https://github.com/pytorch/pytorch/pull/53056) to make
it so that we could theoretically promote any wheel we publish to
download.pytorch.org to pypi

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: walterddr

Differential Revision: D26759823

Pulled By: seemethere

fbshipit-source-id: 2d2b29e7fef0f48c23f3c853bdca6144b7c61f22
2021-03-09 13:16:56 -08:00
Eli Uriegas
569d4fe3f9 .github: Add workflow to build conda packages (#51243)
Summary:
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/51243

Reviewed By: walterddr

Differential Revision: D26669795

Pulled By: seemethere

fbshipit-source-id: 1e54aa8cab2b0b5324815fa4f1706e468f9f57dd
2021-02-25 16:50:02 -08:00
Xu Zhao
2d4354423e Revert nightly docker build cuda version to 11.1.1. (#52234)
Summary:
CUDA 11.2 has a performance regression, so revert to CUDA 11.1.1.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/52234

Test Plan: [CI](https://github.com/pytorch/pytorch/actions?query=workflow%3A%22Build+PyTorch+nightly+Docker+image+and+push+to+GitHub+Container+Registry%22)

Reviewed By: glaringlee

Differential Revision: D26519105

Pulled By: xuzhao9

fbshipit-source-id: d1e1ecb7904c196292d83767b71000b465de73ce
2021-02-18 12:30:07 -08:00
Xu Zhao
0de7a4582e Fix Pytorch docker image name by adding the registry prefix (#52089)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/52089

Test Plan:
Manually trigger the CI

Fixes the [nightly docker pipeline failure](https://github.com/pytorch/pytorch/actions?query=workflow%3A%22Build+PyTorch+nightly+Docker+image+and+push+to+GitHub+Container+Registry%22)

Reviewed By: albanD

Differential Revision: D26390660

Pulled By: xuzhao9

fbshipit-source-id: 5259fe35ffd154fc6684753f358ec5a63f31428f
2021-02-11 09:12:45 -08:00
Xu Zhao
03e82f7944 Use CUDA 11.2 for nightly docker build. (#51990)
Summary:
Set CUDA_VERSION to 11.2.0 since Nvidia name their docker image on Ubuntu 18.04 to be nvidia/cuda:11.2.0-cudnn8-devel-ubuntu18.04.

Note that cudatoolkit 11.2.0 is not yet on [conda](https://repo.anaconda.com/pkgs/main/linux-64/), and we need to wait for that before merging this PR.

- https://hub.docker.com/r/nvidia/cuda/

Pull Request resolved: https://github.com/pytorch/pytorch/pull/51990

Reviewed By: samestep

Differential Revision: D26371193

Pulled By: xuzhao9

fbshipit-source-id: 76915490dc30ddb03ceeeadb3c45a6c02b60401e
2021-02-10 10:46:20 -08:00
Xu Zhao
1e70b4bb73 Add GH Actions CI to build nightly Docker and push to GitHub Container Registry (#51755)
Summary:
Currently PyTorch repository provides Dockerfile to build Docker with nightly builds, but it doesn't have CI to actually build those Dockers.
This PR adds a GitHub action workflow to create PyTorch nightly build Docker and publish them to GitHub Container Registry.
Also, add "--always" option to the `git describe --tags` command that generates the Docker image tag.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/51755

Test Plan: Manually trigger the workflow build in the GitHub Actions web UI.

Reviewed By: seemethere

Differential Revision: D26320180

Pulled By: xuzhao9

fbshipit-source-id: e00b472df14f5913cab9b06a41e837014e87f1c7
2021-02-08 14:59:30 -08:00
Eli Uriegas
1b7a4f9cde .github: Add GitHub Actions workflow to build wheels (#50633)
Summary:
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Fixes #{issue number}

Pull Request resolved: https://github.com/pytorch/pytorch/pull/50633

Reviewed By: samestep

Differential Revision: D26083492

Pulled By: seemethere

fbshipit-source-id: c133671b9cf5074539133ee79fca5c680793a85d
2021-01-27 11:52:28 -08:00