Catherine Lee
01694eaa56
Move cuda 12.4 jobs to periodic for both pull and inductor ( #127825 )
...
Moves 12.4 sm86/a10g jobs in pull to trunk
Moves 12.4 cuda non sm86 jobs to periodic
Moves 12.4 jobs in inductor to inductor-periodic, except inductor_timm which seems to give important signal
There has been a lot of queueing for cuda runners due to the addition of jobs for cuda 12.4, so move those jobs to other workflows that are run less often
Co-authored-by: Andrey Talman <atalman@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127825
Approved by: https://github.com/ZainRizvi , https://github.com/nWEIdia , https://github.com/atalman , https://github.com/malfet
2024-06-05 21:01:36 +00:00
atalman
6e545392cd
Move nongpu workflows from trunk to periodic ( #128049 )
...
We don't need to run them on every PR. These are used to test for graceful degradation of GPU.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128049
Approved by: https://github.com/clee2000
2024-06-05 18:31:26 +00:00
Huy Do
8992141dba
Restore MPS testing on MacOS 13 and m2 metal ( #127853 )
...
The runners are ready now https://github.com/organizations/pytorch/settings/actions/runners?qr=label%3Amacos-m1-13 , we want to keep some MacOS 13 runner for mps coverage until MacOS 15 is out.
This also fixes the `macos-m2-14` mistake from https://github.com/pytorch/pytorch/pull/127582 .
The current `macos-m2-14` runner is on 14.2 while our `macos-m1-14` has 14.4.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127853
Approved by: https://github.com/malfet
2024-06-05 14:44:00 +00:00
PyTorch MergeBot
9a8ab778d3
Revert "[BE]: Update cudnn to 9.1.0.70 ( #123475 )"
...
This reverts commit c490046693https://github.com/pytorch/pytorch/pull/123475 on behalf of https://github.com/huydhn due to CUDA trunk jobs are pretty red after this change, and the forward fix https://github.com/pytorch/pytorch/pull/127984 does not look working ([comment](https://github.com/pytorch/pytorch/pull/123475#issuecomment-2149258430 ))
2024-06-05 08:59:53 +00:00
Eddie Yan
c490046693
[BE]: Update cudnn to 9.1.0.70 ( #123475 )
...
cuDNN has managed to upload cu11 and cu12 wheels for ~~9.0.0.312~~ 9.1.0.70, so trying this out...
CC @Skylion007 @malfet
Co-authored-by: Wei Wang <weiwan@nvidia.com>
Co-authored-by: atalman <atalman@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/123475
Approved by: https://github.com/Skylion007 , https://github.com/malfet , https://github.com/nWEIdia
2024-06-04 16:33:06 +00:00
Nikita Shulga
ddef7c350f
Add comments about runner labels ( #127827 )
...
To distinguish between org-wide and repo-specific runners as well as highlight where they are hosted (by DevInfra, LF or various partners
Delete unused `bm-runner`
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127827
Approved by: https://github.com/huydhn
2024-06-04 02:06:43 +00:00
Zain Rizvi
badf898df2
Remove unstable ARC jobs ( #127563 )
...
Disable these jobs since we're no longer trying to enable ARC
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127563
Approved by: https://github.com/huydhn
2024-06-03 15:30:06 +00:00
diwei sun
2d1ad0c31a
[CI] Add freezing for cpu inductor accuracy test in inductor CI ( #124715 )
...
This PR is to enable '--freezing' when running dynamo accuracy check in CI.
Backgroud:
ISSUES[#124286 ](https://github.com/pytorch/pytorch/issues/124286 ) is not captured by CI since freezing is not enabled for cpu-inductor.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124715
Approved by: https://github.com/chuanqi129 , https://github.com/jgong5 , https://github.com/atalman , https://github.com/desertfire
2024-06-03 07:37:30 +00:00
Xuehai Pan
67ef2683d9
[BE] wrap deprecated function/class with typing_extensions.deprecated ( #127689 )
...
Use `typing_extensions.deprecated` for deprecation annotation if possible. Otherwise, add `category=FutureWarning` to `warnings.warn("message")` if the category is missing.
Note that only warnings that their messages contain `[Dd]eprecat(ed|ion)` are updated in this PR.
Resolves #126888
- #126888
This PR is split from PR #126898 .
- #126898
------
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127689
Approved by: https://github.com/Skylion007
2024-06-02 12:30:43 +00:00
Zain Rizvi
a8c9b26534
[BE] Fix dependabot security errors ( #127567 )
...
Fixes https://github.com/pytorch/pytorch/security/dependabot/36 and https://github.com/pytorch/pytorch/security/dependabot/37 by deleting spurious dependency
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127567
Approved by: https://github.com/malfet
2024-05-31 23:00:07 +00:00
Huy Do
57baae9c9b
Migrating CI/CD jobs to macOS 14 ( #127582 )
...
We have half the fleet in MacoS 14 already and it has been running fine so far https://github.com/pytorch/pytorch/issues/127490 . So, I'm preparing the final push to replace the rest of them. This also switches release build from 13 to 14 (GitHub runners)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127582
Approved by: https://github.com/atalman
2024-05-31 22:30:59 +00:00
Zain Rizvi
02248b73eb
[EZ] Port over all test-infra scale configs to lf runners ( #127645 )
...
Follow up to https://github.com/pytorch/pytorch/pull/127578
Since GPU builds seem to be working correctly, porting over all remaining scale configs from [the org-wide scale config file](https://github.com/pytorch/test-infra/blob/main/.github/scale-config.yml )
The naming convention here is all temporary. We'll figure out something better before completing the migration
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127645
Approved by: https://github.com/malfet
2024-05-31 22:24:41 +00:00
PyTorch MergeBot
033e733021
Revert "[BE] wrap deprecated function/class with typing_extensions.deprecated ( #126898 )"
...
This reverts commit 749a132fb0https://github.com/pytorch/pytorch/pull/126898 on behalf of https://github.com/fbgheith due to switching typing-extensions=4.3.0 to 4.9.0 causes internal failure ([comment](https://github.com/pytorch/pytorch/pull/126898#issuecomment-2142884456 ))
2024-05-31 19:47:24 +00:00
Catherine Lee
121c55d8d1
Old branch deletion script to also delete old ciflow tags ( #127625 )
...
Change branch deletion script to also delete left over ciflow tags that the bot doesn't get to, as well as the one created by triggering a workflow on HUD
Example run https://github.com/pytorch/pytorch/actions/runs/9322082915/job/25662376463?pr=127625
(didn't actually delete the tag, but lists what tags it would delete)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127625
Approved by: https://github.com/huydhn
2024-05-31 18:54:54 +00:00
Svetlana Karslioglu
4a0d96e496
Add a GH action to autolabel docathon PRs ( #127569 )
...
To ease oncall burden for the docathon PR reviewers and ensure all PRs are correctly labeled, adding this GH action that will look for the issue number in the PR and if that issue has a docathon-h1-2024 label, then it would propagate the labels from the issues into the PR. It should not conflict with the existing labelers because we use ``pull_request.add_to_labels`` - credit @kit1980.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127569
Approved by: https://github.com/kit1980
2024-05-31 17:57:07 +00:00
Wang, Eikan
8d7393cb5e
Update triton-xpu commit pin merge rules for XPU ( #127203 )
...
Add the ".ci/docker/ci_commit_pins/triton-xpu.txt" to the XPU merge rules.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127203
Approved by: https://github.com/atalman
2024-05-31 17:19:19 +00:00
Wei Wang
67f0807042
[Inductor] [CI] [CUDA] Skip the failed models and tests the better way ( #127150 )
...
Address subtasks in https://github.com/pytorch/pytorch/issues/126692
After enabling the disabled shards, the following two models regressed (for cu124 configuration):
dynamic_inductor_timm_training.csv
cspdarknet53,pass,7 (expected) | cspdarknet53,fail_accuracy,7 (actual)
eca_botnext26ts_256,pass,7 (expected) | eca_botnext26ts_256,fail_accuracy,7 (actual)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127150
Approved by: https://github.com/huydhn , https://github.com/eqy , https://github.com/atalman
2024-05-31 16:35:57 +00:00
Zain Rizvi
ae47152ca8
Expand supported labels to most self-hosted linux pull.yml workflows ( #127578 )
...
Initial set of runners added in https://github.com/pytorch/pytorch/pull/127566 seem to be working.
Expanding to include more machine types, especially GPU machines
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127578
Approved by: https://github.com/huydhn
2024-05-31 05:40:16 +00:00
Zain Rizvi
ad1b18ab2f
Add repo-specific scale config files ( #127566 )
...
Part of moving pytorch/pytorch CI infra to a Linux foundation run AWS account.
For self-hosted runners that can run jobs from just a single repo, the runner scalers expect them to be stored in the repo itself.
These scale-config files define how the linux foundation's self-hosted runners are configured. These will apply to runners that only are available to the pytorch/pytorch and pytorch/pytorch-canary repos
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127566
Approved by: https://github.com/zxiiro , https://github.com/huydhn , https://github.com/atalman
2024-05-30 21:08:45 +00:00
PyTorch MergeBot
e9a6bbbf7c
Revert "[CI] add xpu test in periodic workflow ( #126410 )"
...
This reverts commit 30d98611a3https://github.com/pytorch/pytorch/pull/126410 on behalf of https://github.com/malfet due to Let's sync up on the test strategy/policies here ([comment](https://github.com/pytorch/pytorch/pull/126410#issuecomment-2140269549 ))
2024-05-30 17:01:02 +00:00
PyTorch MergeBot
ea5c17de90
Revert "Add torchao nightly testing workflow ( #126885 )"
...
This reverts commit d938170314https://github.com/pytorch/pytorch/pull/126885 on behalf of https://github.com/atalman due to Broke inductor periodic test ([comment](https://github.com/pytorch/pytorch/pull/126885#issuecomment-2140139486 ))
2024-05-30 16:23:06 +00:00
chuanqiw
30d98611a3
[CI] add xpu test in periodic workflow ( #126410 )
...
Works for https://github.com/pytorch/pytorch/issues/114850
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126410
Approved by: https://github.com/EikanWang , https://github.com/atalman
2024-05-30 12:10:15 +00:00
Nikita Shulga
3174e6cb8e
[Temp][CI] Run older MPS tests/Mac builds on MacOS 13 ( #127428 )
...
To avoid ambiguity while migration outlined in https://github.com/pytorch-labs/pytorch-gha-infra/pull/399 is in progress. Otherwise, MPS jobs for Ventura can be accidentally scheduled on Sonoma or builds, which might result in flaky failures on trunk.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127428
Approved by: https://github.com/huydhn
2024-05-29 22:58:41 +00:00
Catherine Lee
d99b115eb3
Fix delete old branches workflow ( #127442 )
...
The ubuntu runner started using 2.45.1 (prev 2.43.2), which includes 1f49f7506fhttps://github.com/pytorch/pytorch/pull/127442
Approved by: https://github.com/huydhn , https://github.com/malfet
2024-05-29 21:17:09 +00:00
Xu Zhao
d938170314
Add torchao nightly testing workflow ( #126885 )
...
Add and test torchao nightly testing workflow.
This workflow will be triggered under the following conditions:
1. If the PR has ciflow/torchao label
2. Manual trigger
It will run the torchao benchmark on torchbench/timm/huggingface model workloads with 5 configs (noquant, autoquant, int8dynamic, int8weightonly, int4weightonly). The output will be updated to the PT2 Dashboard: https://hud.pytorch.org/benchmark/compilers
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126885
Approved by: https://github.com/huydhn
2024-05-29 18:22:29 +00:00
Xuehai Pan
749a132fb0
[BE] wrap deprecated function/class with typing_extensions.deprecated ( #126898 )
...
Use `typing_extensions.deprecated` for deprecation annotation if possible. Otherwise, add `category=FutureWarning` to `warnings.warn("message")` if the category is missing.
Note that only warnings that their messages contain `[Dd]eprecat(ed|ion)` are updated in this PR.
UPDATE: Use `FutureWarning` instead of `DeprecationWarning`.
Resolves #126888
- #126888
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126898
Approved by: https://github.com/albanD
2024-05-29 12:09:27 +00:00
Jon Janzen
781f26240a
Add script to copy distributed commits to stable branch ( #126918 )
...
This will be used as part of a prototype of a stable pytorch with a fast-moving distributed folder
Tasks: T189915739
Test plan:
I ran the script in a few configurations on my local machine. It worked as expected
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126918
Approved by: https://github.com/seemethere , https://github.com/malfet
2024-05-29 03:33:44 +00:00
Ting Lu
1c2e221e25
CUDA 12.4 ARM wheel integration to CD - nightly build ( #126174 )
...
rebasing https://github.com/pytorch/pytorch/pull/124112 .
too many conflict files, so starting a new PR.
Test https://github.com/pytorch/builder/pull/1775 (merged) for ARM wheel addition
Test https://github.com/pytorch/builder/pull/1828 (merged) for setting MAX_JOBS
Current issue to follow up:
https://github.com/pytorch/pytorch/issues/126980
Co-authored-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126174
Approved by: https://github.com/nWEIdia , https://github.com/atalman
2024-05-27 05:50:36 +00:00
Xuehai Pan
ba3b05fdf3
[1/N][Easy] fix typo for usort config in pyproject.toml (kown -> known): sort stdlib ( #127122 )
...
The `usort` config in `pyproject.toml` has no effect due to a typo. Fixing the typo make `usort` do more and generate the changes in the PR. Except `pyproject.toml`, all changes are generated by `lintrunner -a --take UFMT --all-files`.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127122
Approved by: https://github.com/kit1980
2024-05-25 08:25:50 +00:00
Huy Do
9ef6f8dfc1
Fix typo in inductor workflow for CUDA 12.4 jobs ( #127121 )
...
Discovered by @clee2000. The change was introduced in https://github.com/pytorch/pytorch/pull/121956
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127121
Approved by: https://github.com/clee2000 , https://github.com/Skylion007
2024-05-25 02:36:39 +00:00
Svetlana Karslioglu
f508cd6e00
Update assigntome job ( #127027 )
...
Updating for the new docathon
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127027
Approved by: https://github.com/kit1980
2024-05-24 19:04:51 +00:00
Catherine Lee
09a73da190
Downgrade requests to 2.31.0 for ios and android ( #126989 )
...
Ex https://github.com/pytorch/pytorch/actions/runs/9211850483/job/25342181353
https://github.com/pytorch/pytorch/actions/runs/9211850483/job/25342182105
2.32.0 isn't on the conda channels yet?
Is there a way to add them?
If not here's a PR to downgrad
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126989
Approved by: https://github.com/atalman , https://github.com/malfet
2024-05-23 21:02:50 +00:00
Wei Wang
0902929d58
[CUDA] [CI]: Enable CUDA 12.4 CI ( #121956 )
...
Reference PR: https://github.com/pytorch/pytorch/pull/93406
Co-authored-by: Aidyn-A <31858918+Aidyn-A@users.noreply.github.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121956
Approved by: https://github.com/atalman
2024-05-23 20:37:47 +00:00
Nikita Shulga
2b57652278
Update requests to 2.32.2 ( #126805 )
...
To address CVE-2024-35195 (though it does not really affect PyTorch, only CI)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126805
Approved by: https://github.com/atalman , https://github.com/kit1980 , https://github.com/seemethere , https://github.com/Skylion007
2024-05-23 00:21:28 +00:00
Catherine Lee
5ccc634603
[CI] Pin uv==0.1.45 for lintrunner ( #126908 )
...
e4623de4cf/1https://github.com/pytorch/pytorch/pull/126908
Approved by: https://github.com/huydhn
2024-05-22 21:41:21 +00:00
Sergii Dymchenko
fc594ed219
Remove lint from retryable_workflows ( #126806 )
...
Related to https://github.com/pytorch/test-infra/pull/4934
Lint workflow now uses Docker, so there should not be network-related errors for pip installing stuff.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126806
Approved by: https://github.com/seemethere , https://github.com/ZainRizvi , https://github.com/huydhn
2024-05-21 19:47:23 +00:00
Catherine Lee
ac2c547838
[TD] Upload names of failures to s3 for pytest cache ( #126315 )
...
Some tests don't get run through pytest and pytest crashes when a test segfaults, so in both caess, the pytest cache won't have an entry (similar to https://github.com/pytorch/test-infra/pull/5205 ).
Instead, manually upload/download an extra file that lists the failing test files
Technically this would be more general than the pytest cache
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126315
Approved by: https://github.com/ZainRizvi
2024-05-21 16:29:31 +00:00
PyTorch MergeBot
8bca0847c2
Revert "[TD] Upload names of failures to s3 for pytest cache ( #126315 )"
...
This reverts commit 655038687ahttps://github.com/pytorch/pytorch/pull/126315 on behalf of https://github.com/clee2000 due to broke inductor ([comment](https://github.com/pytorch/pytorch/pull/126315#issuecomment-2121133045 ))
2024-05-20 20:15:08 +00:00
Catherine Lee
655038687a
[TD] Upload names of failures to s3 for pytest cache ( #126315 )
...
Some tests don't get run through pytest and pytest crashes when a test segfaults, so in both caess, the pytest cache won't have an entry (similar to https://github.com/pytorch/test-infra/pull/5205 ).
Instead, manually upload/download an extra file that lists the failing test files
Technically this would be more general than the pytest cache
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126315
Approved by: https://github.com/ZainRizvi
2024-05-20 17:36:30 +00:00
Catherine Lee
31ea8290e7
Workflow for uploading additional test stats on workflow dispatch ( #126080 )
...
This kind of an experiment for uploading test stats during the run, and also for test dashboard stuff so it can re calculate the info
Add workflow that is callable via workflow dispatch for uploading additional test stats
Adds script that only calculates the additional info
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126080
Approved by: https://github.com/ZainRizvi
2024-05-17 17:29:44 +00:00
William Wen
f17572fcf6
add 3.12 inductor CI tests ( #126218 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126218
Approved by: https://github.com/huydhn , https://github.com/desertfire
2024-05-16 22:29:24 +00:00
Jithun Nair
a55d63659a
Add 2nd shard to ROCm trunk workflow for core distributed UTs ( #121716 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121716
Approved by: https://github.com/ezyang , https://github.com/huydhn
2024-05-16 16:50:02 +00:00
Huy Do
d61a81a9e7
Fix lint failures coming from #126035 ( #126378 )
...
MYPY somehow shows lots of local failures for me. The issue is tracked in https://github.com/pytorch/pytorch/issues/126361 . This is only to keep trunk sane. These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126378
Approved by: https://github.com/kit1980
2024-05-16 06:05:47 +00:00
PyTorch MergeBot
cdcba4dee5
Revert "Fix lint failures coming from #126035 ( #126378 )"
...
This reverts commit 5fa1f4c6e4https://github.com/pytorch/pytorch/pull/126378 on behalf of https://github.com/huydhn due to Trying to add yet another lint fix from https://hud.pytorch.org/pr/pytorch/pytorch/126357 and will reland this ([comment](https://github.com/pytorch/pytorch/pull/126378#issuecomment-2114060547 ))
2024-05-16 05:32:19 +00:00
Huy Do
5fa1f4c6e4
Fix lint failures coming from #126035 ( #126378 )
...
MYPY somehow shows lots of local failures for me. The issue is tracked in https://github.com/pytorch/pytorch/issues/126361 . This is only to keep trunk sane. These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126378
Approved by: https://github.com/kit1980
2024-05-16 05:12:27 +00:00
cyy
18cbaf6dbf
Remove Caffe2 python code ( #126035 )
...
Follows the recent changes of Caffe2.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126035
Approved by: https://github.com/r-barnes , https://github.com/Skylion007
2024-05-15 21:51:11 +00:00
zengxian
ad7316b4c2
[CI] Add AMP models in inductor cpu smoketest for performance ( #125830 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125830
Approved by: https://github.com/chuanqi129 , https://github.com/jgong5 , https://github.com/huydhn , https://github.com/desertfire , https://github.com/atalman
2024-05-15 21:46:58 +00:00
Catherine Lee
d74c89fb10
2 rocm shards on trunk.yml ( #125933 )
...
after test removal for windows cpu + avx related configs, it's going to be the long pole for trunk
Just checked: without rocm, avg tts for trunk is 2.5 hrs last week, with rocm its about 3
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125933
Approved by: https://github.com/ZainRizvi
2024-05-15 20:22:14 +00:00
Wei Wang
8f30f367d0
[CUDA] [CI] Add cu124 docker images ( #125944 )
...
Fixes issues encountered in https://github.com/pytorch/pytorch/pull/121956
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125944
Approved by: https://github.com/atalman
2024-05-15 09:52:38 +00:00
PyTorch UpdateBot
2d35b4564a
[audio hash update] update the pinned audio hash ( #126248 )
...
This PR is auto-generated nightly by [this action](https://github.com/pytorch/pytorch/blob/main/.github/workflows/nightly.yml ).
Update the pinned audio hash.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126248
Approved by: https://github.com/pytorchbot
2024-05-15 05:45:16 +00:00
